move session redial logic into session
Bug #1276199 reported by
John Lenton
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Push Notifications |
Fix Released
|
High
|
John Lenton | ||
Bug Description
move session redial logic into session.
Also, make the session retry channel thing unbuffered: set Stop to nil on exit of Retry.
Related branches
lp:~chipaca/ubuntu-push/client-session-redialer-mash
- Samuele Pedroni: Approve
-
Diff: 709 lines (+267/-160)10 files modifiedbus/connectivity/connectivity.go (+2/-1)
bus/endpoint.go (+0/-7)
bus/testing/testing_endpoint.go (+0/-3)
bus/testing/testing_endpoint_test.go (+0/-6)
client/client.go (+21/-48)
client/client_test.go (+0/-7)
client/session/session.go (+34/-1)
client/session/session_test.go (+76/-1)
util/redialer.go (+71/-36)
util/redialer_test.go (+63/-50)
| Changed in ubuntu-push: | |
| assignee: | nobody → John Lenton (chipaca) |
Revision history for this message
| Samuele Pedroni (pedronis) wrote | #1 |
| Changed in ubuntu-push: | |
| status: | New → In Progress |
| importance: | Undecided → High |
Revision history for this message
| John Lenton (chipaca) wrote | #2 |
| Changed in ubuntu-push: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
make closing a session also deal with synchronously stopping retrying