opal-prd occ reset causes hardlockup

[bugproxy]

[Impact]

- Without the fix, the system will crash on upstream hostboot with NMI enabled systems when opal-prd occ reset is triggered on OpenBMC boxes
- This patch enables HBRT to use HYP special wakeup register in openBMC which until now was only used in FSP based machines

[Testcase]

- opal-prd occ reset

[Regression Potential]
- Failure of OCC reset command

[Other Info]

 * Original bug report.

== Comment: #0 - Shilpasri G. Bhat <email address hidden> - 2018-12-14 00:14:51 ==
On upstream hostboot with NMI enabled, opal-prd occ reset crashes. The following upstream patch needs to be backported to the package to avoid the error.

commit 05dc67bf4f3d85fc6212d1644d46ce6d8bd71140
opal-prd: hservice: Enable hservice->wakeup() in BMC

Contact Information = <email address hidden>

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-02-14 23:44 EDT-------
Canonical, Could you please pick up those patches ?

[Dimitri John Ledkov (xnox)]

Disco has skiboot 6.2 and should have this patch in.

Cosmic & Bionic do not, and will need SRU.

[Andrew Cloke (andrew-cloke)]

Next steps: Manoj to fill in SRU template, and transfer ownership back to Foundations to action the SRU.

[Dimitri John Ledkov (xnox)]

Upload was rejected from the unapproved queue

Rejected:
Rejected by Brian Murray: Missing SRU information in the description

skiboot (6.1-2ubuntu0.1) cosmic; urgency=medium

  * Enable HBRT to use HYP special wakeup register in openBMC. LP:
    #1808498

Date: Thu, 21 Feb 2019 12:20:21 +0100
Changed-By: Dimitri John Ledkov <email address hidden>
Maintainer: Ubuntu Developers <email address hidden>

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-03-07 04:36 EDT-------
(In reply to comment #10)
> Upload was rejected from the unapproved queue
>
> Rejected:
> Rejected by Brian Murray: Missing SRU information in the description
>
> skiboot (6.1-2ubuntu0.1) cosmic; urgency=medium
>
> * Enable HBRT to use HYP special wakeup register in openBMC. LP:
> #1808498

Does this mean its accepted -OR- you need more justification?

-Vasant

>
> Date: Thu, 21 Feb 2019 12:20:21 +0100
> Changed-By: Dimitri John Ledkov <email address hidden>
> Maintainer: Ubuntu Developers <email address hidden>

[Dimitri John Ledkov (xnox)]

@Vasant

If you can open https://bugs.launchpad.net/ubuntu/+source/skiboot/+bug/1808498 you will see that the bug description is lacking SRU documentation of [Impact], [Test Case], [Regression Potential]. A sample template of what is expected in each section is documented at: https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-03-07 15:16 EDT-------
[Impact]

- Without the fix, the system will crash on upstream hostboot with NMI enabled systems when opal-prd occ reset is triggered on OpenBMC boxes
- This patch enables HBRT to use HYP special wakeup register in openBMC which until now was only used in FSP based machines

[Testcase]

- opal-prd occ reset

[Regression Potential]
- Failure of OCC reset command

[Brian Murray (brian-murray)]

Hello bugproxy, or anyone else affected,

Accepted skiboot into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/skiboot/6.1-2ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello bugproxy, or anyone else affected,

Accepted skiboot into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/skiboot/5.10~rc4-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-03-11 05:20 EDT-------
I have verified the patch in source tar file https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/skiboot/5.10~rc4-1ubuntu1.2/skiboot_5.10~rc4.orig.tar.gz

[Andrew Cloke (andrew-cloke)]

Thanks. I've adjusted the bionic verification tags accordingly.

Are you also able to verify the cosmic candidate package referenced in comment #8, and available from https://launchpad.net/ubuntu/+source/skiboot/6.1-2ubuntu0.1?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-03-18 17:58 EDT-------
I checked and the patch is in the package. I also tried this on cosmic and bionic and worked fine. From cosmic:
ubuntu@ltc-boston25:~$ dpkg --list |grep opal-prd
ii opal-prd 6.1-2ubuntu0.1 ppc64el OPAL Processor Recovery Diagnostics daemon
ubuntu@ltc-boston25:~$ sudo opal-prd occ reset 08h
ubuntu@ltc-boston25:~$ cat /etc/*release* |grep VER
VERSION="18.10 (Cosmic Cuttlefish)"
VERSION_ID="18.10"
VERSION_CODENAME=cosmic

[Brian Murray (brian-murray)]

Checking the source package for the patch is not enough for the verification of an SRU. The binary package needs to be tested from the official Ubuntu archive. Subsequently, I am flipping the bionic tags back to verification-needed.

[Launchpad Janitor (janitor)]

This bug was fixed in the package skiboot - 6.1-2ubuntu0.1

---------------
skiboot (6.1-2ubuntu0.1) cosmic; urgency=medium

  * Enable HBRT to use HYP special wakeup register in openBMC. LP:
    #1808498

 -- Dimitri John Ledkov <email address hidden> Thu, 21 Feb 2019 12:20:21 +0100

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for skiboot has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2019-03-21 04:54 EDT-------
Hello Canonical,

We have verified/tested the fix and it looks good. It fixes the issue reported in this defect.

Thanks!

-Vasant

[Launchpad Janitor (janitor)]

This bug was fixed in the package skiboot - 5.10~rc4-1ubuntu1.2

---------------
skiboot (5.10~rc4-1ubuntu1.2) bionic; urgency=medium

  * Enable HBRT to use HYP special wakeup register in openBMC. LP:
    #1808498

 -- Dimitri John Ledkov <email address hidden> Thu, 21 Feb 2019 12:23:32 +0100