Minimized css is not the "preferred form of modification"
Bug #1201636 reported by
Andrew Starr-Bochicchio
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Packaging Guide |
Fix Released
|
High
|
Andrew Starr-Bochicchio | ||
| ubuntu-packaging-guide (Debian) |
Fix Released
|
Unknown
|
|||
Bug Description
Debian FTP master's commented in the NEW review:
On Mon, Jul 15, 2013 at 8:07 PM, Paul Richards Tagliamonte <email address hidden> wrote:
> themes\
> a binary, and should be removed (or better yet; full sources added and minified
> at build time)
Looks like this refers to /themes/
We should fix this in the next upload.
Related branches
lp:~andrewsomething/ubuntu-packaging-guide/lp1201636
- Daniel Holbach (community): Approve
-
Diff: 561 lines (+478/-15)6 files modifieddebian/changelog (+2/-1)
themes/ubuntu/layout.html (+3/-3)
themes/ubuntu/sidebar.html (+1/-1)
themes/ubuntu/static/960.css (+343/-1)
themes/ubuntu/static/base.css (+2/-2)
themes/ubuntu/static/reset.css (+127/-7)
Revision history for this message
| Paul Tagliamonte (paultag) wrote | #1 |
Revision history for this message
| Paul Tagliamonte (paultag) wrote | #2 |
| Changed in ubuntu-packaging-guide: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| Changed in ubuntu-packaging-guide: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Andrew Starr-Bochicchio (andrewsomething) |
| Changed in ubuntu-packaging-guide (Debian): | |
| status: | Unknown → New |
| Changed in ubuntu-packaging-guide: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-packaging-guide (Debian): | |
| status: | New → Fix Committed |
| Changed in ubuntu-packaging-guide (Debian): | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-packaging-guide: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I also spotted a few others too - that yahoo one, IIRC - I'd look through the source and get rid of minified JS / CSS from the source tarball :)