"Func-TestPR" commit message header does not work for layered/reactive charms

[Frode Nordahl]

The zaza-integration code inspects git commit messages to trigger switch of branch for zaza.

To do this it uses git -C <path to checked out assets>.

However, neither CO_DIR nor BUILT_ASSET_DIR appears to be available in the context that code is executed any more.

Log excerpt:
15:41:25 ====> Checking asset type of /var/lib/jenkins/workspace/test_charm_func_smoke/asset/ceph-rbd-mirror <=======================
15:41:25 charm (built)
15:41:25 ====> f_openstack_update_zaza_test_requirements <=======================
15:41:25 ====> f_openstack_get_zaza_github_func_test_pr <=======================
15:41:25 fatal: Cannot change to 'show': No such file or directory
15:41:25 No GitHub Func-Test-PR found...

Note that this also failed before r414 and r415, but it did work at the time of the initial commit in r406.

[Frode Nordahl (fnordahl)]

OTOH, reviewing how the f_layerci and built asset stuff works I am not sure how this ever worked as by the time we get to the smoke / full test run there is no git repository checked out.

Got to find a better way to approach this.

[Frode Nordahl (fnordahl)]

I get it now, this was added to the gate as we were in the process of convertnig a couple of classic charms from ``Amulet`` to ``Zaza``. So the feature works for classic charms but not reactive charms.