return value of check_call wrapper is ignored

[Paul Collins]

This charm wraps subprocess.check_call in a function called check_call, and uses the latter exclusively.

The wrapper catches CalledProcessError, logs on failure, and returns CalledProcessError.returncode.

None of the charm code checks the return value of the check_call wrapper, so many potential problems are silently ignored.