Ambiance theme Gtk2 apps dark toolbar background

[Piotr Jurkiewicz]

Gtk2 apps (that is all MATE apps in particular) should have dark toolbar background. It will look better and will be consistent with Gtk3 apps.

For example, this: http://ubuntu-mate.org/gallery/Screenshots/09_Eye_of_MATE.png
should look like this: http://i.imgur.com/BMbwL4l.png

[Adolfo Jayme Barrientos (fitojb)]

I would advise against this.

Applying dark colors to GTK+2 toolbars never works OK, and makes many apps look ugly, as these parse toolbar colors in unexpected ways (just imagine LibreOffice). And this happens because GTK+2 only has one class of toolbars (cf. GTK+3 where you can specify different theming styles for toolbars according to their class: "inline-toolbar", "primary-toolbar", etc.

Also, MATE is being ported to GTK+3 anyway.

[Martin Wimpress  (flexiondotorg)]

I've taken a look at the implementing dark GTK 2.x toolbars and as Adolfo explained, the results can be unpredictable. Sorry, but I won't be implementing the requested change.

[Adam Smith (adamsmith)]

I had am attempt at this quite sometime ago (before Ubuntu-Mate was born I think). Attached is pluma, caja and pcmanfm with dark toolbars. It wouldn't be hard to support the mate apps. What other gtk2 apps were problematic?

[Adam Smith (adamsmith)]

This is essentially bug https://bugs.launchpad.net/light-themes/+bug/829218 from back in the day.

Another example is here http://www.webupd8.org/2011/12/light-themes-evolved-ambiance-and.html

I haven't looked at in ages, but I seem to remember my solution was more elegant than the light-themes-evolved one (which I started with). It's something else I can dig out if there is interest in it.

[Adam Smith (adamsmith)]

A quick patch.... probably needs more work......