ctrl+z key combination does not restore picture to its original setting

[Istimsak]

Testcase: 1428

The shotwell testcase for ubuntu desktop has a few errors.

First, the "red-eye" edit button did not show a red circle when the "apply" button is pressed. Instead it shows a green circle when pressed.

Second, after a picture has been cropped, the ctrl+z key combination does not restore the image back to its current setting. When pressing the ctrl+z combo, the rotate button begins shifting from right to left rotate. Sometimes, it will actually rotate the image.

shotwell:
  Installed: 0.22.0-0ubuntu4

[Ubuntu QA Website (ubuntuqa)]

This bug has been reported on the Ubuntu Package testing tracker.

A list of all reports related to this bug can be found here:
http://packages.qa.ubuntu.com/qatracker/reports/bugs/1493908

[Kev Bowring (flocculant)]

Is this a bug with shotwell - that is, is this behaviour wrong for the program?

If the shotwell behaviour is correct - then the bug is with testcase, we can change the Affects once we know where the bug is.

[Istimsak (saqman2060)]

I believe it might be both. Not sure if the green dot has always been part of shotwell. The key combos look more like a testcase bug

[Kev Bowring (flocculant)]

Ctrl+z rotated image ok here on Xubuntu.

Red eye circle wasn't green, but was uncoloured.

Can you check again please.

[Istimsak (saqman2060)]

I checked and the red-eye circle still colors green. The ctrl-z key combo restored a cropped image back to its original state. It does not rotate the image. Ctrl-r does that.

[Kev Bowring (flocculant)]

My mistake.

However definitely not a coloured circle here.

Looking at the wording of the testcase - it's ambiguous.

"A small circle appears near a region of the photo that looks red"

Maybe reword the testcase to

A small circle appears near a red region of the photo.

Because I think this is what's meant. Not that the circle is red.

[Nicholas Skaggs (nskaggs)]

For me on wily,

ctrl+z works properly.
the small circle is white, not red or green.

To clarify the testcase, we should simply state a small circle will appear. It appears the default behavoir is that the circle will appear on an area it feels it affected by red eye; otherwise it defaults to the center of the image. I don't think we need to / want to test for this however.

[Kev Bowring (flocculant)]

ok - ack that.

so to sum up - ctrl+z appears to be working properly in wily so no need to change that. Remove the red-eye section of the test.