Feature request CI: mention in changelogs when adds package dependencies

Bug #1441638 reported by Timo Jyrinki on 2015-04-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Landing Team
Wishlist
Unassigned

Bug Description

This occurred today and would be a nice feature for some future iteration of CI:

- When MP adds a build or runtime dependency on some new package in debian/control, automatically add a text for it in debian/changelog

Example:

Commit message: Add settings page, per design specification. (LP: #1351183)

diff:
--- webbrowser-app-0.23+15.04.20150331.2/debian/control
+++ webbrowser-app-0.23+15.04.20150407.4/debian/control
@@ -36,6 +36,8 @@
          fonts-liberation,
          liboxideqt-qmlplugin (>= 1.5),
          libqt5sql5-sqlite,
+ qml-module-qt-labs-settings,
          qml-module-qtquick2 (>= 5.4) | qtdeclarative5-qtquick2-plugin (>= 5.4),
          qml-module-qtquick-dialogs | qtdeclarative5-dialogs-plugin,
          qml-module-qtquick-window2 | qtdeclarative5-window-plugin,

Changelog entry:

  * Add settings page, per design specification. (LP: #1351183)
     [adds a runtime dependency on qml-module-qt-labs-settings]

I don't see how this would even be possible. The diff doesn't even show
where that line is being added. This feature would require a great deal of
semantic knowledge about the debian/control file that just isn't there.

Oliver Grawert (ogra) wrote :

how about we instead add a blocking test that denies a landing if a change in debian/control is detected but the package name is not greppable in the chanelog ?

Because the train doesn't run any tests of any kind, it just runs "bzr bd"
and uploads the result. You're asking for a significant increase in
overhead on the train side. It's not clear to me how to implement this in a
sensible way.
On Apr 10, 2015 4:20 AM, "Oliver Grawert" <email address hidden> wrote:

> how about we instead add a blocking test that denies a landing if a
> change in debian/control is detected but the package name is not
> greppable in the chanelog ?
>
> --
> You received this bug notification because you are a member of Landing
> Team Trackers, which is subscribed to Ubuntu Landing Team.
> https://bugs.launchpad.net/bugs/1441638
>
> Title:
> Feature request CI: mention in changelogs when adds package
> dependencies
>
> Status in Ubuntu Landing Team tasks:
> New
>
> Bug description:
> This occurred today and would be a nice feature for some future
> iteration of CI:
>
> - When MP adds a build or runtime dependency on some new package in
> debian/control, automatically add a text for it in debian/changelog
>
> Example:
>
> Commit message: Add settings page, per design specification. (LP:
> #1351183)
>
> diff:
> --- webbrowser-app-0.23+15.04.20150331.2/debian/control
> +++ webbrowser-app-0.23+15.04.20150407.4/debian/control
> @@ -36,6 +36,8 @@
> fonts-liberation,
> liboxideqt-qmlplugin (>= 1.5),
> libqt5sql5-sqlite,
> + qml-module-qt-labs-settings,
> qml-module-qtquick2 (>= 5.4) | qtdeclarative5-qtquick2-plugin
> (>= 5.4),
> qml-module-qtquick-dialogs | qtdeclarative5-dialogs-plugin,
> qml-module-qtquick-window2 | qtdeclarative5-window-plugin,
>
> Changelog entry:
>
> * Add settings page, per design specification. (LP: #1351183)
> [adds a runtime dependency on qml-module-qt-labs-settings]
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu-lt/+bug/1441638/+subscriptions
>

Changed in ubuntu-lt:
status: New → Won't Fix
Timo Jyrinki (timo-jyrinki) wrote :

Ok, thanks for the comments!

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers