Reconfiguration options ~broken

[Timo Jyrinki]

Either randomly:
- The Reconfigure button for landers gives you 404. No known way to fix other than try again.
- The prepare-silo way of reconfiguring for trainguards gives you 404. I noticed that if I change the "parambuild?" with "buildWithParameters?" it worked, but maybe it was just the reload.

Or:
- Both of them work in some way, but the MERGE_PROPOSAL field is missing whitespaces that need to be added manually.

[Robert Bruce Park (robru)]

Ok, so there's two different issues here:

1. If you separate your MPs with newlines instead of spaces, the 'parambuild' page chokes on that and lists the URLs without any spaces in between.

2. If you aren't logged in, the 'parambuild' page 404s instead of redirecting you to SSO.

I've fixed #1 by putting in some regexes that replace newlines with spaces before presenting the URL to users (both in the assignment and the reconfigure links), so now the parambuild page correctly spaces the merge URLs.

Number #2 I'm not so sure about, the plugin doesn't offer any sort of config interface for customizing behavior like that, it seems the best we can hope for is to just add a note saying 'log in before clicking this link' or similar.

So it seems we are faced with a choice: Either we can just accept that this will 404 when you aren't logged in, or we can stop using this plugin and go back to the "click Proceed and then see a white screen even though the job is running invisibly in the background".

[Robert Bruce Park (robru)]

For #2, I've added a couple warnings (one on the 'assign silo' dialogue and one above the 'Reconfigure silo' column header) that explain you need to log in first, and give a link to the login url, making logins as easy as possible.

Closing this for now, feel free to reopen if you would prefer I remove the plugin and we revert to the "white screen of death" bug instead.

[Robert Bruce Park (robru)]

Ok scratch that, I've found a way to force the sso login and then configure sso to redirect back to the buildparam page with all the values filled out. It's a bit ugly because now the URL is doubly-urlencoded, but I've tested it and it's working, if you're logged out, it logs you in then shows you the build form with values filled in.