ubuntu-keyboard

The keyboard sound should be stored in a setting

Bug #1271947 reported by Sebastien Bacher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-keyboard
Fix Released
High
Łukasz Zemczak
ubuntu-keyboard (Ubuntu)
Fix Released
High
Łukasz Zemczak

Bug Description

The keyboard sound (the key press one) is current in the code and can't be changed.

It would be nice to have that stored in gsettings instead. The settings need to play that sound when the option is enabled, and we would prefer reading a configuration rather than having to keep code in sync. That would also make sense in case somebody wants to override/customize that sound.

Related branches

lp:~sil2100/ubuntu-keyboard/feedback_sound_gsettings
Michael Sheldon (community): Approve
PS Jenkins bot: Approve (continuous-integration)
Sebastien Bacher: Needs Fixing
Diff: 226 lines (+60/-8)
8 files modified
data/schemas/com.canonical.keyboard.maliit.gschema.xml (+5/-0)
qml/KeyboardContainer.qml (+6/-1)
src/plugin/inputmethod.cpp (+10/-0)
src/plugin/inputmethod.h (+4/-0)
src/plugin/inputmethod_p.h (+6/-0)
src/plugin/keyboardsettings.cpp (+14/-0)
src/plugin/keyboardsettings.h (+2/-0)
tests/unittests/ut_keyboardsettings/ut_keyboardsettings.cpp (+13/-7)
Bill Filler (bfiller)
Changed in ubuntu-keyboard (Ubuntu):
status: New → Confirmed
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → High
Bill Filler (bfiller)
Changed in ubuntu-keyboard (Ubuntu):
assignee: Bill Filler (bfiller) → Łukasz Zemczak (sil2100)
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Completely missed this bug, mostly because it's filled only on the ubuntu-keyboard source side. Looking into it right now.

Changed in ubuntu-keyboard (Ubuntu):
status: Confirmed → In Progress
Changed in ubuntu-keyboard:
status: New → In Progress
assignee: nobody → Łukasz Zemczak (sil2100)
importance: Undecided → High
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Should I also prepare the system-settings part?

Revision history for this message
Sebastien Bacher (seb128) wrote :

if you want sure, thanks!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-keyboard - 0.99.trunk.phablet2+14.10.20140616-0ubuntu1

---------------
ubuntu-keyboard (0.99.trunk.phablet2+14.10.20140616-0ubuntu1) utopic; urgency=low

  [ Łukasz 'sil2100' Zemczak ]
  * Store the keyboard feedback sound in gsettings, making it
    configurable. Are there any related MPs required for this MP to
    build/function as expected? Please list. -> No. Is your branch in
    sync with latest trunk (e.g. bzr pull lp:trunk -> no changes). ->
    Yes. Did you perform an exploratory manual test run of your code
    change and any related functionality on device or emulator? -> Yes.
    Did you successfully run all tests found in your component's Test
    Plan on device or emulator? -> All testing has been performed on a
    Mako device. If you changed the UI, was the change
    specified/approved by design? -> N/A. If you changed the packaging
    (debian), did you subscribe a core-dev to this MP? -> N/A (LP:
    #1271947)
 -- Ubuntu daily release <email address hidden> Mon, 16 Jun 2014 17:26:23 +0000

Changed in ubuntu-keyboard (Ubuntu):
status: In Progress → Fix Released
Michael Sheldon (michael-sheldon)
Changed in ubuntu-keyboard:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.