ubuntu-keyboard

[osk] Shift key icon is sometimes offset

Bug #1251285 reported by Jouni Helminen on 2013-11-14

This bug affects 4 people

	Status	Importance	Assigned to
Ubuntu UX	Fix Released	Undecided	Jouni Helminen
ubuntu-keyboard	Fix Released	High	Łukasz Zemczak
ubuntu-keyboard (Ubuntu)	Fix Released	High	Łukasz Zemczak
ubuntu-themes (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

Current situation:

The shift key icon is sometimes offset by a few grid units - see attached png

Solution:

fix it

Related branches

lp:~sil2100/ubuntu-themes/orange_shift_key

Merged into lp:ubuntu-themes at revision 338

Bill Filler (community): Approve on 2014-01-29

PS Jenkins bot (community): Approve (continuous-integration) on 2014-01-28

lp:~sil2100/ubuntu-keyboard/workaround_shift_positioning

Merged into lp:ubuntu-keyboard at revision 135

Bill Filler (community): Approve on 2014-01-29

PS Jenkins bot: Approve (continuous-integration) on 2014-01-28

lp:ubuntu/trusty-proposed/ubuntu-themes

lp:ubuntu/trusty-proposed/ubuntu-keyboard

Revision history for this message

Jouni Helminen (jounihelminen) wrote on 2013-11-14:

test.png Edit (57.5 KiB, image/png)

Changed in ubuntu-ux:
status:	New → Fix Committed
assignee:	nobody → Jouni Helminen (jounihelminen)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2013-11-14:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ubuntu-keyboard (Ubuntu):
status:	New → Confirmed

Bill Filler (bfiller) on 2014-01-27

Changed in ubuntu-keyboard (Ubuntu):
importance:	Undecided → High
assignee:	nobody → Łukasz Zemczak (sil2100)
Changed in ubuntu-keyboard:
status:	New → Confirmed
assignee:	Thomas Moenicke (thomas-moenicke) → Łukasz Zemczak (sil2100)
importance:	Undecided → High

Łukasz Zemczak (sil2100) on 2014-01-27

Changed in ubuntu-keyboard:
status:	Confirmed → In Progress

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2014-01-28:

So, I have been looking into this issue and found ways to reproduce it and some bits that might be responsible. The whole issue is a bit bizarre - it seems like a small and easy issue but it's not. It seems that the keyboard state is changed correctly, things work ok, but the problem seems to appear when we use the Icon coloring through Icon.color. This then switches the Icon to use a shader instead - and once this is used all hell goes loose.

So, when ActionKey.qml does not have the iconImage.color = colorShifted line in the SHIFTED case - all is working correctly all the time. Even when the color is changed by a timer after a massive delay, it still causes the problem to happen. I even asked Gerry about advice regarding this problem - for now he also thinks it might be a ShaderEffect bug, so pointing more into the insides.

We can work-around it easily by not using the coloring and simply creating a colored icon to use instead in the SHIFTED case for the shift key. If it would really be an inside bug, then I guess this will be the only logical solution here.

Revision history for this message

Łukasz Zemczak (sil2100) wrote on 2014-01-28:

Attached two branches for a workaround. It requires adding a new icon - it looks the same as what was done in software, but still, we might need design input there.

Łukasz Zemczak (sil2100) on 2014-02-06

Changed in ubuntu-keyboard (Ubuntu):
status:	Confirmed → In Progress

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-02-06:

This bug was fixed in the package ubuntu-themes - 13.04+14.04.20140206.1-0ubuntu1

---------------
ubuntu-themes (13.04+14.04.20140206.1-0ubuntu1) trusty; urgency=low

  [ Łukasz 'sil2100' Zemczak ]
  * To work-around the bug of LP: #1251285, we actually need a manually
    orange-colored caps/shift key. In the past we were doing that in
    software, but it seems to cause some problems right now. (LP:
    #1251285)

  [ Andrés G. Aragoneses ]
  * Ambiance: GtkTreeView enhancements to be less widget specific Rules
    should aimed to be applied to classes rather than specific widgets.
    For example a good way to start doing this is in the Treeview rules
    that define zebra stripping: by making them target the .view class,
    we make zebra stripping compatible with other Treeview-like widgets,
    like Banshee's ListView. This also goes more in sync with GTK
    upstream, i.e. you can take its default theme as an example:
    https://github.com/GNOME/gtk/blob/3.10.7/gtk/gtk-default.css#L72 .

  [ Marco Trevisan (Treviño) ]
  * Ambiance, Radiance: add UnityDecorations css to match previous
    metacity themes.

  [ Lars Uebernickel ]
  * GtkFrame: don't draw a background. (LP: #1276098)
  * Radiance: use dark checks and radio images in menu items.

[ Ubuntu daily release ]
* Automatic snapshot from revision 341
-- Ubuntu daily release <email address hidden> Thu, 06 Feb 2014 10:07:12 +0000

Changed in ubuntu-themes (Ubuntu):
status:	New → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2014-02-14:

This bug was fixed in the package ubuntu-keyboard - 0.99.trunk.phablet2+14.04.20140213-0ubuntu1

---------------
ubuntu-keyboard (0.99.trunk.phablet2+14.04.20140213-0ubuntu1) trusty; urgency=low

  [ Łukasz 'sil2100' Zemczak ]
  * Disable the shift button coloring, as it breaks things in certain
    cases - use a custom colored icon instead. (LP: #1251285)
-- Ubuntu daily release <email address hidden> Thu, 13 Feb 2014 16:48:17 +0000