udpgro_fwd.sh / pmtu.sh from ubuntu_kselftests_net needs net_helper.sh on Mantic

[Po-Hsu Lin]

[Impact]
Since upstream commit 4acffb6 "selftests: net: explicitly wait for listener ready" landed on our Mantic 6.5.0-40.40 via stable update, a new "net_helper.sh" script will be needed for this change.

Otherwise the udpgro_fwd.sh script will complain about:
 # timeout set to 0
 # selftests: net: udpgro_fwd.sh
 # ./udpgro_fwd.sh: line 4: net_helper.sh: No such file or directory
 # IPv4
 # No GRO ./udpgro_fwd.sh: line 124: wait_local_port_listen: command not found

[Fix]
* 3bdd9fd2 "selftests/net: synchronize udpgro tests' tx and rx connection"
* 9d851dd4 "selftests: net: Remove executable bits from library scripts"
* a71d0908 "selftests: net: more strict check in net_helper"
* f5173fe3 "selftests: net: included needed helper in the install targets"

The first patch is the fix that we need, it can be applied with -C2. The other 2 are follow-up enhancements and can be clean cherry-picked.

For f5173fe3 it needs to be backported to skip the non-existing lib.sh script.

Patch 4

[Test Plan]
Run the tools/testing/selftests/net/udpgro_fwd.sh script in the patched tree and this "command not found issue" should be gone.

[Where problems could occur]
As it will implement this wait_local_port_listen() to other tests like udpgro.sh, udpgro_bench.sh and udpgro_frglist.sh as well. We might see failures from them if this change is incorrect. However all these changes are limited to test code in the kernel tree. No actual changes to any real kernel functions, the impact should be low.

[Po-Hsu Lin (cypressyew)]

This is affecting mainline 6.6.y as well. Let me try if I can get it fixed there first.

https://<email address hidden>/T/#t

[Po-Hsu Lin (cypressyew)]

Patch submitted to upstream but no response so far, since this is the last cycle for Mantic I will have myself unassigned.

In 6.5.0-44 this is affecting pmtu.sh as well, it's complaining missing helper.sh:
 Running 'make run_tests -C net TEST_PROGS=pmtu.sh TEST_GEN_PROGS='' TEST_CUSTOM_PROGS='''
 make: Entering directory '/home/ubuntu/autotest/client/tmp/ubuntu_kselftests_net/src/linux/tools/testing/selftests/net'
 TAP version 13
 1..1
 # timeout set to 0
 # selftests: net: pmtu.sh
 # ./pmtu.sh: line 201: lib.sh: No such file or directory
 # ./pmtu.sh: line 202: net_helper.sh: No such file or directory
 # ./pmtu.sh: line 941: cleanup_all_ns: command not found
 # ./pmtu.sh: line 536: setup_ns: command not found
 # Error: argument "type" is wrong: Invalid "netns" value

[Po-Hsu Lin (cypressyew)]

It will need this set as well:
https://<email address hidden>/T/#t