test_resolved_domain_restricted_dns in networkd-test.py from systemd ADT failed with J-oem-6.0.0-1007

[Po-Hsu Lin]

This issue does not exist with J-oem-6.0.0-1006

With systemd 249.11-0ubuntu3.6

ubuntu@curly:~/systemd-249.11/test$ sudo ./networkd-test.py ; uname -a
systemd-network:x:100:102:systemd Network Management,,,:/run/systemd:/usr/sbin/nologin
test_bridge_init (__main__.BridgeTest) ... ok
test_bridge_port_priority (__main__.BridgeTest) ... ok
test_bridge_port_priority_set_zero (__main__.BridgeTest)
It should be possible to set the bridge port priority to 0 ... ok
test_bridge_port_property (__main__.BridgeTest)
Test the "[Bridge]" section keys ... ok
test_coldplug_dhcp_ip4_only (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_ip4_only_no_ra (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_ip6 (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_yes_ip4 (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_yes_ip4_no_ra (__main__.DnsmasqClientTest) ... ok
test_hotplug_dhcp_ip4 (__main__.DnsmasqClientTest) ... ok
test_hotplug_dhcp_ip6 (__main__.DnsmasqClientTest) ... ok
test_resolved_domain_restricted_dns (__main__.DnsmasqClientTest)
resolved: domain-restricted DNS servers ... ERROR
test_resolved_etc_hosts (__main__.DnsmasqClientTest)
resolved queries to /etc/hosts ... ok
test_route_only_dns (__main__.DnsmasqClientTest) ... ok
test_route_only_dns_all_domains (__main__.DnsmasqClientTest) ... ok
test_transient_hostname (__main__.DnsmasqClientTest)
networkd sets transient hostname from DHCP ... ok
test_transient_hostname_with_static (__main__.DnsmasqClientTest)
transient hostname is not applied if static hostname exists ... ok
test_basic_matching (__main__.MatchClientTest)
Verify the Name= line works throughout this class. ... ok
test_inverted_matching (__main__.MatchClientTest)
Verify that a '!'-prefixed value inverts the match. ... ok
test_coldplug_dhcp_ip4_only (__main__.NetworkdClientTest) ... ok
test_coldplug_dhcp_ip4_only_no_ra (__main__.NetworkdClientTest) ... ok
test_coldplug_dhcp_ip6 (__main__.NetworkdClientTest) ... skipped 'networkd does not have DHCPv6 server support'
test_coldplug_dhcp_yes_ip4 (__main__.NetworkdClientTest) ... ok
test_coldplug_dhcp_yes_ip4_no_ra (__main__.NetworkdClientTest) ... ok
test_dhcp_timezone (__main__.NetworkdClientTest)
networkd sets time zone from DHCP ... ok
test_dropin (__main__.NetworkdClientTest) ... ok
test_hotplug_dhcp_ip4 (__main__.NetworkdClientTest) ... ok
test_hotplug_dhcp_ip6 (__main__.NetworkdClientTest) ... skipped 'networkd does not have DHCPv6 server support'
test_route_only_dns (__main__.NetworkdClientTest) ... ok
test_route_only_dns_all_domains (__main__.NetworkdClientTest) ... ok
test_search_domains (__main__.NetworkdClientTest) ... ok
test_catchall_config (__main__.UnmanagedClientTest)
Verify link states with a catch-all config, hot-plug. ... ok
test_catchall_config_coldplug (__main__.UnmanagedClientTest)
Verify link states with a catch-all config, cold-plug. ... ok
test_unmanaged_setting (__main__.UnmanagedClientTest)
Verify link states with Unmanaged= settings, hot-plug. ... ok
test_unmanaged_setting_coldplug (__main__.UnmanagedClientTest)
Verify link states with Unmanaged= settings, cold-plug. ... ok

======================================================================
ERROR: test_resolved_domain_restricted_dns (__main__.DnsmasqClientTest)
resolved: domain-restricted DNS servers
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/ubuntu/systemd-249.11/test/./networkd-test.py", line 678, in test_resolved_domain_restricted_dns
    out = subprocess.check_output(['resolvectl', 'query', 'math.lab'])
  File "/usr/lib/python3.10/subprocess.py", line 420, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/usr/lib/python3.10/subprocess.py", line 524, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['resolvectl', 'query', 'math.lab']' returned non-zero exit status 1.

----------------------------------------------------------------------
Ran 35 tests in 156.268s

FAILED (errors=1, skipped=2)
Linux curly 6.0.0-1007-oem #7-Ubuntu SMP PREEMPT_DYNAMIC Tue Oct 25 18:05:20 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Here is the test log with J-oem-6.0.0-1006
ubuntu@curly:~/systemd-249.11/test$ sudo ./networkd-test.py ; uname -a
systemd-network:x:100:102:systemd Network Management,,,:/run/systemd:/usr/sbin/nologin
test_bridge_init (__main__.BridgeTest) ... ok
test_bridge_port_priority (__main__.BridgeTest) ... ok
test_bridge_port_priority_set_zero (__main__.BridgeTest)
It should be possible to set the bridge port priority to 0 ... ok
test_bridge_port_property (__main__.BridgeTest)
Test the "[Bridge]" section keys ... ok
test_coldplug_dhcp_ip4_only (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_ip4_only_no_ra (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_ip6 (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_yes_ip4 (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_yes_ip4_no_ra (__main__.DnsmasqClientTest) ... ok
test_hotplug_dhcp_ip4 (__main__.DnsmasqClientTest) ... ok
test_hotplug_dhcp_ip6 (__main__.DnsmasqClientTest) ... ok
test_resolved_domain_restricted_dns (__main__.DnsmasqClientTest)
resolved: domain-restricted DNS servers ... ok
test_resolved_etc_hosts (__main__.DnsmasqClientTest)
resolved queries to /etc/hosts ... ok
test_route_only_dns (__main__.DnsmasqClientTest) ... ok
test_route_only_dns_all_domains (__main__.DnsmasqClientTest) ... ok
test_transient_hostname (__main__.DnsmasqClientTest)
networkd sets transient hostname from DHCP ... ok
test_transient_hostname_with_static (__main__.DnsmasqClientTest)
transient hostname is not applied if static hostname exists ... ok
test_basic_matching (__main__.MatchClientTest)
Verify the Name= line works throughout this class. ... ok
test_inverted_matching (__main__.MatchClientTest)
Verify that a '!'-prefixed value inverts the match. ... ok
test_coldplug_dhcp_ip4_only (__main__.NetworkdClientTest) ... ok
test_coldplug_dhcp_ip4_only_no_ra (__main__.NetworkdClientTest) ... ok
test_coldplug_dhcp_ip6 (__main__.NetworkdClientTest) ... skipped 'networkd does not have DHCPv6 server support'
test_coldplug_dhcp_yes_ip4 (__main__.NetworkdClientTest) ... ok
test_coldplug_dhcp_yes_ip4_no_ra (__main__.NetworkdClientTest) ... ok
test_dhcp_timezone (__main__.NetworkdClientTest)
networkd sets time zone from DHCP ... ok
test_dropin (__main__.NetworkdClientTest) ... ok
test_hotplug_dhcp_ip4 (__main__.NetworkdClientTest) ... ok
test_hotplug_dhcp_ip6 (__main__.NetworkdClientTest) ... skipped 'networkd does not have DHCPv6 server support'
test_route_only_dns (__main__.NetworkdClientTest) ... ok
test_route_only_dns_all_domains (__main__.NetworkdClientTest) ... ok
test_search_domains (__main__.NetworkdClientTest) ... ok
test_catchall_config (__main__.UnmanagedClientTest)
Verify link states with a catch-all config, hot-plug. ... ok
test_catchall_config_coldplug (__main__.UnmanagedClientTest)
Verify link states with a catch-all config, cold-plug. ... ok
test_unmanaged_setting (__main__.UnmanagedClientTest)
Verify link states with Unmanaged= settings, hot-plug. ... ok
test_unmanaged_setting_coldplug (__main__.UnmanagedClientTest)
Verify link states with Unmanaged= settings, cold-plug. ... ok

----------------------------------------------------------------------
Ran 35 tests in 178.496s

OK (skipped=2)
Linux curly 6.0.0-1006-oem #6-Ubuntu SMP PREEMPT_DYNAMIC Tue Oct 18 20:01:16 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

[Po-Hsu Lin (cypressyew)]

The offending line is:
  678 out = subprocess.check_output(['resolvectl', 'query', 'math.lab'])

With -1006:
$ sudo pdb3 ./networkd-test.py
> /home/ubuntu/systemd-249.11/test/networkd-test.py(21)<module>()
-> import errno
(Pdb) b 678
Breakpoint 1 at /home/ubuntu/systemd-249.11/test/networkd-test.py:678
(Pdb) c
systemd-network:x:100:102:systemd Network Management,,,:/run/systemd:/usr/sbin/nologin
test_bridge_init (__main__.BridgeTest) ... ok
test_bridge_port_priority (__main__.BridgeTest) ... ok
test_bridge_port_priority_set_zero (__main__.BridgeTest)
It should be possible to set the bridge port priority to 0 ... ok
test_bridge_port_property (__main__.BridgeTest)
Test the "[Bridge]" section keys ... ok
test_coldplug_dhcp_ip4_only (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_ip4_only_no_ra (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_ip6 (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_yes_ip4 (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_yes_ip4_no_ra (__main__.DnsmasqClientTest) ... ok
test_hotplug_dhcp_ip4 (__main__.DnsmasqClientTest) ... ok
test_hotplug_dhcp_ip6 (__main__.DnsmasqClientTest) ... ok
test_resolved_domain_restricted_dns (__main__.DnsmasqClientTest)
resolved: domain-restricted DNS servers ... > /home/ubuntu/systemd-249.11/test/networkd-test.py(678)test_resolved_domain_restricted_dns()
-> out = subprocess.check_output(['resolvectl', 'query', 'math.lab'])
(Pdb)

(in another terminal)
ubuntu@curly:~$ resolvectl query math.lab
math.lab: 10.241.3.3 -- link: testvpnrouter

-- Information acquired via protocol DNS in 10.4732s.
-- Data is authenticated: no; Data was acquired via local or encrypted transport: no
-- Data from: network

With -1007
$ sudo pdb3 ./networkd-test.py
> /home/ubuntu/systemd-249.11/test/networkd-test.py(21)<module>()
-> import errno
(Pdb) b 678
Breakpoint 1 at /home/ubuntu/systemd-249.11/test/networkd-test.py:678
(Pdb) c
systemd-network:x:100:102:systemd Network Management,,,:/run/systemd:/usr/sbin/nologin
test_bridge_init (__main__.BridgeTest) ... ok
test_bridge_port_priority (__main__.BridgeTest) ... ok
test_bridge_port_priority_set_zero (__main__.BridgeTest)
It should be possible to set the bridge port priority to 0 ... ok
test_bridge_port_property (__main__.BridgeTest)
Test the "[Bridge]" section keys ... ok
test_coldplug_dhcp_ip4_only (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_ip4_only_no_ra (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_ip6 (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_yes_ip4 (__main__.DnsmasqClientTest) ... ok
test_coldplug_dhcp_yes_ip4_no_ra (__main__.DnsmasqClientTest) ... ok
test_hotplug_dhcp_ip4 (__main__.DnsmasqClientTest) ... ok
test_hotplug_dhcp_ip6 (__main__.DnsmasqClientTest) ... ok
test_resolved_domain_restricted_dns (__main__.DnsmasqClientTest)
resolved: domain-restricted DNS servers ... > /home/ubuntu/systemd-249.11/test/networkd-test.py(678)test_resolved_domain_restricted_dns()
-> out = subprocess.check_output(['resolvectl', 'query', 'math.lab'])
(Pdb)

(in another terminal)
ubuntu@curly:~$ resolvectl query math.lab
math.lab: resolve call failed: Lookup failed due to system error: No...

[Timo Aaltonen (tjaalton)]

b064edad2c46ef8e16b7e42ae9bc14bbeb30bb82 is the first bad commit
commit b064edad2c46ef8e16b7e42ae9bc14bbeb30bb82
Author: Richard Gobert <email address hidden>
Date: Mon Aug 29 13:18:51 2022 +0200

    net-next: Fix IP_UNICAST_IF option behavior for connected sockets

[Kleber Sacilotto de Souza (kleber-souza)]

The commit mentioned by Timo has upstream sha1 0e4d354762cefd3e16b4cff8988ff276e45effc4 ("net-next: Fix IP_UNICAST_IF option behavior for connected sockets"), which is claimed to be fixed by 526682b458b1b56d2e0db027df535cb5cdcfde59 ("net: setsockopt: fix IPV6_UNICAST_IF option for connected sockets"). The fix commit was backported to upstream stable v6.0.16.

[Kleber Sacilotto de Souza (kleber-souza)]

This is also failing on kinetic/linux 5.19.0-30.31 (failing since 5.19.0-24.25):

https://autopkgtest.ubuntu.com/results/autopkgtest-kinetic/kinetic/amd64/s/systemd/20230110_014211_77011@/log.gz

[Timo Aaltonen (tjaalton)]

oem-6.0 won't get this fix and should migrate to oem-6.1 soon anyway, where this is fixed

[Utkarsh Gupta (utkarsh)]

Ubuntu 22.10 (Kinetic Kudu) has reached end of life, so this bug will not be fixed for that specific release.