Mark kprobe_args_user.tc in kselftest/ftrace as unsupported

Bug #1929527 reported by Po-Hsu Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-kernel-tests
Fix Released
Undecided
Po-Hsu Lin
linux (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Po-Hsu Lin
linux-oem-5.6 (Ubuntu)
Invalid
Undecided
Unassigned
Focal
Won't Fix
Undecided
Po-Hsu Lin

Bug Description

[Impact]
This kprobe_args_user.tc test will be marked as "unresolved" and once causing failures in ftrace of our ubuntu_kernel_selftests (lp:1869227)

Our workaround is to blacklist this test in autotest-client-tests [1]

Note that with patch b730d668138cb3 ("ftrace/selftest: make unresolved cases cause failure if --fail-unresolved set") available, an unresolved case will not be treated as a failure unless we requested so.

[1] https://kernel.ubuntu.com/git/ubuntu/autotest-client-tests.git/commit/ubuntu_kernel_selftests/ubuntu_kernel_selftests.py?id=a381d47a9004388730e825cd20566ef102a29399

[Fix]
* 1e11b7dbef17bb selftests/ftrace: Return unsupported for the unconfigured features

With this patch it will be marked as unsupported, easier to understand than unresolved.

This patch can be found in Groovy and newer releases, and this test does not exist in Bionic and older releases.

[Test]
Tested on s390x / PowerPC, this will be marked as unsupported:
$ sudo ./ftracetest test.d/kprobe/kprobe_args_user.tc
=== Ftrace unit tests ===
[1] Kprobe event user-memory access [UNSUPPORTED]

# of passed: 0
# of failed: 0
# of unresolved: 0
# of untested: 0
# of unsupported: 1
# of xfailed: 0
# of undefined(test bug): 0
$ echo $?
0

[Where problems could occur]
Changes limited to testing tool, should not impact real kernel functionality. With this patch and local workaround in autotest-client-tests removed we might see failures in s390x / PowerPC in the future.

Po-Hsu Lin (cypressyew)
summary: - Skip unsupported kprobe-direct.tc and kprobe_args_user.tc in
- kselftest/ftrace
+ Skip unsupported kprobe_args_user.tc in kselftest/ftrace
Po-Hsu Lin (cypressyew)
description: updated
Po-Hsu Lin (cypressyew)
description: updated
description: updated
Po-Hsu Lin (cypressyew)
description: updated
Po-Hsu Lin (cypressyew)
summary: - Skip unsupported kprobe_args_user.tc in kselftest/ftrace
+ Mark kprobe_args_user.tc in kselftest/ftrace as unsupported
Po-Hsu Lin (cypressyew)
Changed in linux-oem-5.6 (Ubuntu):
status: New → Invalid
Changed in linux (Ubuntu):
status: New → Fix Released
Changed in linux (Ubuntu Focal):
status: New → In Progress
Changed in linux-oem-5.6 (Ubuntu Focal):
status: New → In Progress
Changed in ubuntu-kernel-tests:
status: New → In Progress
Changed in linux (Ubuntu Focal):
assignee: nobody → Po-Hsu Lin (cypressyew)
Changed in ubuntu-kernel-tests:
assignee: nobody → Po-Hsu Lin (cypressyew)
Changed in linux-oem-5.6 (Ubuntu Focal):
assignee: nobody → Po-Hsu Lin (cypressyew)
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

BTW that patch b730d668138cb3 ("ftrace/selftest: make unresolved cases cause failure if --fail-unresolved set") has already landed in bug 1877958

Changed in linux (Ubuntu Focal):
status: In Progress → Fix Committed
Revision history for this message
Ubuntu Kernel Bot (ubuntu-kernel-bot) wrote :

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-focal' to 'verification-done-focal'. If the problem still exists, change the tag 'verification-needed-focal' to 'verification-failed-focal'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-focal
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Works as expected in 5.4.0-75.84-generic on Focal s390x

# [41] Kprobe event user-memory access [UNSUPPORTED]

tags: added: verification-done-focal
removed: verification-needed-focal
tags: added: 5.4 focal ubuntu-kernel-selftests
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (34.3 KiB)

This bug was fixed in the package linux - 5.4.0-77.86

---------------
linux (5.4.0-77.86) focal; urgency=medium

  * UAF on CAN J1939 j1939_can_recv (LP: #1932209)
    - SAUCE: can: j1939: delay release of j1939_priv after synchronize_rcu

  * UAF on CAN BCM bcm_rx_handler (LP: #1931855)
    - SAUCE: can: bcm: delay release of struct bcm_op after synchronize_rcu

linux (5.4.0-76.85) focal; urgency=medium

  * focal/linux: 5.4.0-76.85 -proposed tracker (LP: #1932123)

  * Upstream v5.9 introduced 'module' patches that removed exported symbols
    (LP: #1932065)
    - SAUCE: Revert "modules: inherit TAINT_PROPRIETARY_MODULE"
    - SAUCE: Revert "modules: return licensing information from find_symbol"
    - SAUCE: Revert "modules: rename the licence field in struct symsearch to
      license"
    - SAUCE: Revert "modules: unexport __module_address"
    - SAUCE: Revert "modules: unexport __module_text_address"
    - SAUCE: Revert "modules: mark each_symbol_section static"
    - SAUCE: Revert "modules: mark find_symbol static"
    - SAUCE: Revert "modules: mark ref_module static"

linux (5.4.0-75.84) focal; urgency=medium

  * focal/linux: 5.4.0-75.84 -proposed tracker (LP: #1930032)

  * Packaging resync (LP: #1786013)
    - update dkms package versions

  * CVE-2021-33200
    - bpf: Wrap aux data inside bpf_sanitize_info container
    - bpf: Fix mask direction swap upon off reg sign change
    - bpf: No need to simulate speculative domain for immediates

  * Realtek USB hubs in Dell WD19SC/DC/TB fail to work after exiting s2idle
    (LP: #1928242)
    - USB: Verify the port status when timeout happens during port suspend

  * CVE-2020-26145
    - ath10k: drop fragments with multicast DA for SDIO
    - ath10k: add CCMP PN replay protection for fragmented frames for PCIe
    - ath10k: drop fragments with multicast DA for PCIe

  * CVE-2020-26141
    - ath10k: Fix TKIP Michael MIC verification for PCIe

  * CVE-2020-24588
    - mac80211: properly handle A-MSDUs that start with an RFC 1042 header
    - cfg80211: mitigate A-MSDU aggregation attacks
    - mac80211: drop A-MSDUs on old ciphers
    - ath10k: drop MPDU which has discard flag set by firmware for SDIO

  * CVE-2020-26139
    - mac80211: do not accept/forward invalid EAPOL frames

  * CVE-2020-24586 // CVE-2020-24587 // CVE-2020-24587 for such cases.
    - mac80211: extend protection against mixed key and fragment cache attacks

  * CVE-2020-24586 // CVE-2020-24587
    - mac80211: prevent mixed key and fragment cache attacks
    - mac80211: add fragment cache to sta_info
    - mac80211: check defrag PN against current frame
    - mac80211: prevent attacks on TKIP/WEP as well

  * CVE-2020-26147
    - mac80211: assure all fragments are encrypted

  * raid10: Block discard is very slow, causing severe delays for mkfs and
    fstrim operations (LP: #1896578)
    - md: add md_submit_discard_bio() for submitting discard bio
    - md/raid10: extend r10bio devs to raid disks
    - md/raid10: pull the code that wait for blocked dev into one function
    - md/raid10: improve raid10 discard request
    - md/raid10: improve discard request for far layout
    - dm raid: remove unnecessary discard limi...

Changed in linux (Ubuntu Focal):
status: Fix Committed → Fix Released
Po-Hsu Lin (cypressyew)
Changed in linux-oem-5.6 (Ubuntu Focal):
status: In Progress → Won't Fix
Changed in ubuntu-kernel-tests:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers