ubuntu_xfstests_xfs failed to build on Groovy

[Po-Hsu Lin]

configure: WARNING: unrecognized options: --disable-nls
configure: WARNING: unrecognized options: --disable-nls
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
walk_tree.c: In function 'walk_tree_rec':
walk_tree.c:104:43: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
  104 | if ((flags & WALK_TREE_RECURSIVE) &&
      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
  105 | (!(flags & WALK_TREE_SYMLINK) && S_ISDIR(st.st_mode)) ||
      | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
In file included from /usr/include/string.h:519,
                 from libacl/__acl_to_any_text.c:24:
In function 'strcpy',
    inlined from '__acl_to_any_text' at libacl/__acl_to_any_text.c:90:3:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:90:10: warning: '__builtin_strcpy' writing 1 or more bytes into a region of size 0 overflows the destination [-Wstringop-overflow=]
   90 | return __builtin___strcpy_chk (__dest, __src, __bos (__dest));
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ar: `u' modifier ignored since `D' is the default (see `U')
ar: `u' modifier ignored since `D' is the default (see `U')
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
test1.c:164:35: warning: suggest parentheses around arithmetic in operand of '|' [-Wparentheses]
  164 | { "bits", '\0', POPT_ARG_BITSET|POPT_ARGFLAG_DOC_HIDDEN, &aBits, 0,
      | ^
poptint.c:12:28: warning: 'utf8_skip_data' defined but not used [-Wunused-const-variable=]
   12 | static const unsigned char utf8_skip_data[256] = {
      | ^~~~~~~~~~~~~~
poptconfig.c: In function 'poptReadConfigFile':
poptconfig.c:399:9: warning: variable 'xx' set but not used [-Wunused-but-set-variable]
  399 | int xx;
      | ^~
popthelp.c: In function 'getArgDescrip':
popthelp.c:176:27: warning: unused parameter 'translation_domain' [-Wunused-parameter]
  176 | /*@null@*/ const char * translation_domain)
      | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
popthelp.c: In function 'singleOptionDefaultValue':
popthelp.c:230:27: warning: unused parameter 'translation_domain' [-Wunused-parameter]
  230 | /*@null@*/ const char * translation_domain)
      | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
popthelp.c: In function 'singleOptionHelp':
popthelp.c:325:9: warning: variable 'xx' set but not used [-Wunused-but-set-variable]
  325 | int xx;
      | ^~
popthelp.c: In function 'singleTableHelp':
popthelp.c:606:9: warning: variable 'xx' set but not used [-Wunused-but-set-variable]
  606 | int xx;
      | ^~
popthelp.c: In function 'showHelpIntro':
popthelp.c:647:9: warning: variable 'xx' set but not used [-Wunused-but-set-variable]
  647 | int xx;
      | ^~
popthelp.c: In function 'poptPrintHelp':
popthelp.c:666:9: warning: variable 'xx' set but not used [-Wunused-but-set-variable]
  666 | int xx;
      | ^~
popt.c: In function 'execCommand':
popt.c:483:9: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
  483 | int rc;
      | ^~
ar: `u' modifier ignored since `D' is the default (see `U')
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
configure: WARNING: unrecognized options: --disable-nls
configure: WARNING: unrecognized options: --disable-nls
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
ar: creating libaio.a
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
config.status: WARNING: 'Makefile.in' seems to ignore the --datarootdir setting
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
snprintf.c: In function 'dopr':
snprintf.c:319:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
  319 | flags |= DP_F_UP;
      | ^
snprintf.c:320:4: note: here
  320 | case 'x':
      | ^~~~
snprintf.c:341:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
  341 | flags |= DP_F_UP;
      | ^
snprintf.c:342:4: note: here
  342 | case 'e':
      | ^~~~
snprintf.c:350:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
  350 | flags |= DP_F_UP;
      | ^
snprintf.c:351:4: note: here
  351 | case 'g':
      | ^~~~
dbench.c: In function 'main':
dbench.c:469:9: warning: variable 't' set but not used [-Wunused-but-set-variable]
  469 | double t, latency=0;
      | ^
fileio.c: In function 'nb_writex':
fileio.c:344:4: warning: ignoring return value of 'pread' declared with attribute 'warn_unused_result' [-Wunused-result]
  344 | pread(ftable[i].fd, &c, 1, offset);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fileio.c:351:4: warning: ignoring return value of 'ftruncate' declared with attribute 'warn_unused_result' [-Wunused-result]
  351 | ftruncate(ftable[i].fd, offset+1);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fileio.c: In function 'nb_cleanup':
fileio.c:508:2: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' [-Wunused-result]
  508 | asprintf(&dname, "%s/clients/client%d", child->directory, child->id);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fileio.c:512:2: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' [-Wunused-result]
  512 | asprintf(&dname, "%s%s", child->directory, "/clients");
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fileio.c: In function 'nb_deltree':
fileio.c:533:3: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' [-Wunused-result]
  533 | asprintf(&fname, "%s/%s", dname, de->d_name);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
child.c: In function 'child_run':
child.c:177:3: warning: ignoring return value of 'asprintf' declared with attribute 'warn_unused_result' [-Wunused-result]
  177 | asprintf(&child->cname,"client%d", child->id);
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
make[1]: warning: -j6 forced in submake: resetting jobserver mode.
In file included from xfs_ag.c:12:
xfs_ag.c: In function 'xfs_agflblock_init':
xfs_format.h:790:3: warning: taking address of packed member of 'struct xfs_agfl' may result in an unaligned pointer value [-Waddress-of-packed-member]
  790 | &(XFS_BUF_TO_AGFL(bp)->agfl_bno[0]) : \
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xfs_ag.c:231:13: note: in expansion of macro 'XFS_BUF_TO_AGFL_BNO'
  231 | agfl_bno = XFS_BUF_TO_AGFL_BNO(mp, bp);
      | ^~~~~~~~~~~~~~~~~~~
In file included from xfs_alloc.c:8:
xfs_alloc.c: In function 'xfs_alloc_get_freelist':
xfs_format.h:790:3: warning: taking address of packed member of 'struct xfs_agfl' may result in an unaligned pointer value [-Waddress-of-packed-member]
  790 | &(XFS_BUF_TO_AGFL(bp)->agfl_bno[0]) : \
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xfs_alloc.c:2431:13: note: in expansion of macro 'XFS_BUF_TO_AGFL_BNO'
 2431 | agfl_bno = XFS_BUF_TO_AGFL_BNO(mp, agflbp);
      | ^~~~~~~~~~~~~~~~~~~
xfs_alloc.c: In function 'xfs_alloc_put_freelist':
xfs_format.h:790:3: warning: taking address of packed member of 'struct xfs_agfl' may result in an unaligned pointer value [-Waddress-of-packed-member]
  790 | &(XFS_BUF_TO_AGFL(bp)->agfl_bno[0]) : \
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xfs_alloc.c:2568:13: note: in expansion of macro 'XFS_BUF_TO_AGFL_BNO'
 2568 | agfl_bno = XFS_BUF_TO_AGFL_BNO(mp, agflbp);
      | ^~~~~~~~~~~~~~~~~~~
xfs_alloc.c: In function 'libxfs_agfl_walk':
xfs_format.h:790:3: warning: taking address of packed member of 'struct xfs_agfl' may result in an unaligned pointer value [-Waddress-of-packed-member]
  790 | &(XFS_BUF_TO_AGFL(bp)->agfl_bno[0]) : \
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
xfs_alloc.c:3159:13: note: in expansion of macro 'XFS_BUF_TO_AGFL_BNO'
 3159 | agfl_bno = XFS_BUF_TO_AGFL_BNO(mp, agflbp);
      | ^~~~~~~~~~~~~~~~~~~
xfs_rmap_btree.c: In function 'xfs_rmapbt_init_high_key_from_rec':
xfs_rmap_btree.c:192:15: warning: taking address of packed member of 'struct xfs_rmap_key' may result in an unaligned pointer value [-Waddress-of-packed-member]
  192 | be32_add_cpu(&key->rmap.rm_startblock, adj);
      | ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/string.h:519,
                 from ../include/platform_defs.h:17,
                 from handle.c:8:
In function 'strncpy',
    inlined from 'path_to_fshandle' at handle.c:110:3:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: '__builtin_strncpy' specified bound 4096 equals destination size [-Wstringop-truncation]
  106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/bin/ld: ../libxfs/.libs/libxfs.a(init.o):xfstests-bld/xfsprogs-dev/libxfs/init.c:27: multiple definition of `progname'; xfs_mdrestore.o:xfstests-bld/xfsprogs-dev/mdrestore/xfs_mdrestore.c:10: first defined here
collect2: error: ld returned 1 exit status
gmake[3]: *** [../include/buildrules:65: xfs_mdrestore] Error 1
gmake[2]: *** [include/buildrules:35: mdrestore] Error 2
gmake[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:92: default] Error 2
make: *** [Makefile:32: all] Error 2

[Po-Hsu Lin (cypressyew)]

With the latest SHA1 head:
14b5274a2201484dee675c3a79879c1889d92fbb for xfstest-bld
37d4f926b525fbba8aa579b9eea4ae0921ea7b7b for xfstest-dev

This test can be built on G, however this will break the build on X, with:
  xqmstats.c: In function ‘main’:
  xqmstats.c:43:3: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
     fgets(buffer, 256, stats);
     ^
  quotastats.c: In function ‘get_proc_num’:
  quotastats.c:51:2: warning: ignoring return value of ‘fscanf’, declared with attribute warn_unused_result [-Wunused-result]
    fscanf(f, "%d", &ret);
    ^
  quota.c: In function ‘main’:
  quota.c:388:16: warning: implicit declaration of function ‘reallocarray’ [-Wimplicit-function-declaration]
        fsnames = reallocarray(fsnames, fscount, sizeof(char *));
                  ^
  quota.c:388:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
        fsnames = reallocarray(fsnames, fscount, sizeof(char *));
                ^
  ar: `u' modifier ignored since `D' is the default (see `U')
  quota.o: In function `main':
  xfstests-bld/quota/quota.c:388: undefined reference to `reallocarray'
  collect2: error: ld returned 1 exit status
  make[3]: *** [quota] Error 1
  make[3]: *** Waiting for unfinished jobs....
  make[2]: *** [all-recursive] Error 1
  make[1]: *** [all] Error 2
  make: *** [all] Error 1

This will need some more investigation