rtnetlink.sh in net from ubuntu_kernel_selftests is returning 1 for a skipped test

Bug #1895258 reported by Po-Hsu Lin on 2020-09-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-kernel-tests
Undecided
Po-Hsu Lin
linux (Ubuntu)
Undecided
Unassigned
Bionic
Undecided
Po-Hsu Lin

Bug Description

== SRU Justification ==
The rtnetlink.sh in kselftest/net from 4.15 kernel will fail with:
 selftests: rtnetlink.sh
 ========================================
 PASS: policy routing
 PASS: route get
 PASS: preferred_lft addresses have expired
 PASS: tc htb hierarchy
 PASS: gre tunnel endpoint
 PASS: bridge setup
 PASS: ipv6 addrlabel
 PASS: set ifalias e1dfde61-e5a7-415f-8bd9-924e9796038f for test-dummy0
 PASS: vrf
 PASS: vxlan
 SKIP: fou: iproute2 too old
 SKIP: macsec: iproute2 too old
 not ok 1..10 selftests: rtnetlink.sh [FAIL]

The return value for this script is 1.

Look into the code, it's the kci_test_encap_fou() test that causes
this issue:

      ip fou help 2>&1 |grep -q 'Usage: ip fou'
      if [ $? -ne 0 ];then
            echo "SKIP: fou: iproute2 too old"
            return 1
      fi

It should at least return ksft_skip=4 (or 0 with older release that
does not support this skip code in kselftest framework)

== Fix ==
* 57aefc7c226d ("selftests: net: return Kselftest Skip code for
skipped tests")

This patch needs to be backported into Bionic, as some newer tests
does not exist in Bionic.

== Test ==
Tested directly on the affected kernel, the test will be marked as:
not ok 1..10 selftests: rtnetlink.sh [SKIP]

== Regression Potential ==
Low, changes limited to test scripts. And the kselftest framework in
Bionic can handle this ksft_skip=4 return code properly, tests won't
be marked as failed because of this.

Although IMO in this case the test should be marked as PASS instead of
SKIP in the end, as not all tests were skipped, but that's something
we could fix with upstream in the future.

Po-Hsu Lin (cypressyew) on 2020-09-11
Changed in linux (Ubuntu Bionic):
status: New → In Progress
assignee: nobody → Po-Hsu Lin (cypressyew)
Changed in linux (Ubuntu):
status: New → Fix Released
Changed in ubuntu-kernel-tests:
status: New → In Progress
assignee: nobody → Po-Hsu Lin (cypressyew)
tags: added: 4.15 bionic kqa-blocker sru-20200831 ubuntu-kernel-selftests
Po-Hsu Lin (cypressyew) on 2020-09-11
description: updated
Po-Hsu Lin (cypressyew) on 2020-09-11
description: updated
Po-Hsu Lin (cypressyew) on 2020-09-11
description: updated
Changed in linux (Ubuntu Bionic):
status: In Progress → Fix Committed

This bug is awaiting verification that the kernel in -proposed solves the problem. Please test the kernel and update this bug with the results. If the problem is solved, change the tag 'verification-needed-bionic' to 'verification-done-bionic'. If the problem still exists, change the tag 'verification-needed-bionic' to 'verification-failed-bionic'.

If verification is not done by 5 working days from today, this fix will be dropped from the source code, and this bug will be closed.

See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you!

tags: added: verification-needed-bionic
Po-Hsu Lin (cypressyew) wrote :

Checked with 4.15.0-1097.107~16.04.1, it will return SKIP now:
 not ok 1..10 selftests: rtnetlink.sh [SKIP]

tags: added: verification-done-bionic
removed: verification-needed-bionic
Changed in ubuntu-kernel-tests:
status: In Progress → Fix Released
Launchpad Janitor (janitor) wrote :
Download full text (25.4 KiB)

This bug was fixed in the package linux - 4.15.0-121.123

---------------
linux (4.15.0-121.123) bionic; urgency=medium

  * Packaging resync (LP: #1786013)
    - update dkms package versions

linux (4.15.0-120.122) bionic; urgency=medium

  * CVE-2020-16119
    - SAUCE: dccp: avoid double free of ccid on child socket

  * CVE-2020-16120
    - Revert "UBUNTU: SAUCE: overlayfs: ensure mounter privileges when reading
      directories"
    - ovl: pass correct flags for opening real directory
    - ovl: switch to mounter creds in readdir
    - ovl: verify permissions in ovl_path_open()

linux (4.15.0-119.120) bionic; urgency=medium

  * bionic/linux: 4.15.0-119.120 -proposed tracker (LP: #1896040)

  * gtp: unable to associate contextes to interfaces (LP: #1894605)
    - gtp: add GTPA_LINK info to msg sent to userspace

  * uvcvideo: add mapping for HEVC payloads (LP: #1895803)
    - media: videodev2.h: Add v4l2 definition for HEVC
    - SAUCE: media: uvcvideo: Add mapping for HEVC payloads

  * Novalink (mkvterm command failure) (LP: #1892546)
    - tty: hvcs: Don't NULL tty->driver_data until hvcs_cleanup()

  * rtnetlink.sh in net from ubuntu_kernel_selftests is returning 1 for a
    skipped test (LP: #1895258)
    - selftests: net: return Kselftest Skip code for skipped tests

  * Bionic update: upstream stable patchset 2020-09-16 (LP: #1895873)
    - net: Fix potential wrong skb->protocol in skb_vlan_untag()
    - tipc: fix uninit skb->data in tipc_nl_compat_dumpit()
    - ipvlan: fix device features
    - gre6: Fix reception with IP6_TNL_F_RCV_DSCP_COPY
    - ALSA: pci: delete repeated words in comments
    - ASoC: tegra: Fix reference count leaks.
    - mfd: intel-lpss: Add Intel Emmitsburg PCH PCI IDs
    - arm64: dts: qcom: msm8916: Pull down PDM GPIOs during sleep
    - powerpc/xive: Ignore kmemleak false positives
    - media: pci: ttpci: av7110: fix possible buffer overflow caused by bad DMA
      value in debiirq()
    - blktrace: ensure our debugfs dir exists
    - scsi: target: tcmu: Fix crash on ARM during cmd completion
    - iommu/iova: Don't BUG on invalid PFNs
    - drm/amdkfd: Fix reference count leaks.
    - drm/radeon: fix multiple reference count leak
    - drm/amdgpu: fix ref count leak in amdgpu_driver_open_kms
    - drm/amd/display: fix ref count leak in amdgpu_drm_ioctl
    - drm/amdgpu: fix ref count leak in amdgpu_display_crtc_set_config
    - drm/amdgpu/display: fix ref count leak when pm_runtime_get_sync fails
    - scsi: lpfc: Fix shost refcount mismatch when deleting vport
    - selftests/powerpc: Purge extra count_pmc() calls of ebb selftests
    - omapfb: fix multiple reference count leaks due to pm_runtime_get_sync
    - PCI: Fix pci_create_slot() reference count leak
    - rtlwifi: rtl8192cu: Prevent leaking urb
    - mips/vdso: Fix resource leaks in genvdso.c
    - cec-api: prevent leaking memory through hole in structure
    - f2fs: fix use-after-free issue
    - drm/nouveau/drm/noveau: fix reference count leak in nouveau_fbcon_open
    - drm/nouveau: Fix reference count leak in nouveau_connector_detect
    - locking/lockdep: Fix overflow in presentation of average lock-time
    - scsi: iscsi: Do not put h...

Changed in linux (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers