| 2020-03-26 07:11:00 |
Po-Hsu Lin |
bug |
|
|
added bug |
| 2020-03-26 07:11:47 |
Po-Hsu Lin |
tags |
|
sru-20200316 |
|
| 2020-03-26 07:12:07 |
Po-Hsu Lin |
tags |
sru-20200316 |
5.3 eoan s390x sru-20200316 ubuntu-kernel-selftests |
|
| 2020-03-26 07:12:52 |
Po-Hsu Lin |
description |
Issue found on Eoan (5.3.0-43.36-generic) with all s390x instances:
- LPAR s2lp4
- zVM kernel03
- zKVM s2lp6g003
# selftests: net: tcp_fastopen_backup_key.sh
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# FAIL: TcpExtTCPFastOpenPassiveFail non-zero
not ok 30 selftests: net: tcp_fastopen_backup_key.sh # exit=1 |
Issue found on Eoan (5.3.0-42.34, 5.3.0-43.36) with all s390x instances:
- LPAR s2lp4
- zVM kernel03
- zKVM s2lp6g003
# selftests: net: tcp_fastopen_backup_key.sh
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# FAIL: TcpExtTCPFastOpenPassiveFail non-zero
not ok 30 selftests: net: tcp_fastopen_backup_key.sh # exit=1 |
|
| 2020-07-20 08:05:41 |
Po-Hsu Lin |
tags |
5.3 eoan s390x sru-20200316 ubuntu-kernel-selftests |
5.3 5.4 eoan focal s390x sru-20200316 sru-20200629 ubuntu-kernel-selftests |
|
| 2020-07-31 15:28:14 |
Colin Ian King |
ubuntu-kernel-tests: importance |
Undecided |
High |
|
| 2020-07-31 15:28:16 |
Colin Ian King |
ubuntu-kernel-tests: assignee |
|
Colin Ian King (colin-king) |
|
| 2020-07-31 15:28:19 |
Colin Ian King |
ubuntu-kernel-tests: status |
New |
In Progress |
|
| 2020-08-11 15:54:55 |
Colin Ian King |
description |
Issue found on Eoan (5.3.0-42.34, 5.3.0-43.36) with all s390x instances:
- LPAR s2lp4
- zVM kernel03
- zKVM s2lp6g003
# selftests: net: tcp_fastopen_backup_key.sh
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# FAIL: TcpExtTCPFastOpenPassiveFail non-zero
not ok 30 selftests: net: tcp_fastopen_backup_key.sh # exit=1 |
== SRU Justification Focal, Groovy ==
Running the tcp_fastopen_backup_key.sh from net in ubuntu_kernel_selftests fails on little endian systems. This is a regression that occurred because of commit 438ac88009bc ("net: fastopen: robustness and endianness fixes for SipHash").
== Fix ==
Upstream (linux-next) fix:
commit f19008e676366c44e9241af57f331b6c6edf9552
Author: Jason Baron <jbaron@akamai.com>
Date: Mon Aug 10 13:38:39 2020 -0400
tcp: correct read of TFO keys on big endian systems
== Test case ==
Run the kernel self tests tcp_fastopen_backup_key.sh. Currently this generally fails on the last few test cases. With the fix the test passes.
== Regression Potential ==
This fix touches the tcp fast open code paths so it can potentially impact TCP fast opening and perhaps the TCP opening. However, this has been tested on big and little endian systems with the regression tests, so the regression risk is low with this fix.
----
Issue found on Eoan (5.3.0-42.34, 5.3.0-43.36) with all s390x instances:
- LPAR s2lp4
- zVM kernel03
- zKVM s2lp6g003
# selftests: net: tcp_fastopen_backup_key.sh
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# FAIL: TcpExtTCPFastOpenPassiveFail non-zero
not ok 30 selftests: net: tcp_fastopen_backup_key.sh # exit=1 |
|
| 2020-08-11 16:03:10 |
Colin Ian King |
bug task added |
|
linux (Ubuntu) |
|
| 2020-08-11 16:03:20 |
Colin Ian King |
nominated for series |
|
Ubuntu Groovy |
|
| 2020-08-11 16:03:20 |
Colin Ian King |
bug task added |
|
linux (Ubuntu Groovy) |
|
| 2020-08-11 16:03:20 |
Colin Ian King |
nominated for series |
|
Ubuntu Focal |
|
| 2020-08-11 16:03:20 |
Colin Ian King |
bug task added |
|
linux (Ubuntu Focal) |
|
| 2020-08-11 16:03:28 |
Colin Ian King |
linux (Ubuntu Focal): importance |
Undecided |
High |
|
| 2020-08-11 16:03:30 |
Colin Ian King |
linux (Ubuntu Focal): assignee |
|
Colin Ian King (colin-king) |
|
| 2020-08-11 16:03:33 |
Colin Ian King |
linux (Ubuntu Groovy): importance |
Undecided |
High |
|
| 2020-08-11 16:03:36 |
Colin Ian King |
linux (Ubuntu Groovy): assignee |
|
Colin Ian King (colin-king) |
|
| 2020-08-11 16:03:38 |
Colin Ian King |
linux (Ubuntu Focal): status |
New |
In Progress |
|
| 2020-08-11 16:03:40 |
Colin Ian King |
linux (Ubuntu Groovy): status |
New |
In Progress |
|
| 2020-08-12 07:18:45 |
Colin Ian King |
description |
== SRU Justification Focal, Groovy ==
Running the tcp_fastopen_backup_key.sh from net in ubuntu_kernel_selftests fails on little endian systems. This is a regression that occurred because of commit 438ac88009bc ("net: fastopen: robustness and endianness fixes for SipHash").
== Fix ==
Upstream (linux-next) fix:
commit f19008e676366c44e9241af57f331b6c6edf9552
Author: Jason Baron <jbaron@akamai.com>
Date: Mon Aug 10 13:38:39 2020 -0400
tcp: correct read of TFO keys on big endian systems
== Test case ==
Run the kernel self tests tcp_fastopen_backup_key.sh. Currently this generally fails on the last few test cases. With the fix the test passes.
== Regression Potential ==
This fix touches the tcp fast open code paths so it can potentially impact TCP fast opening and perhaps the TCP opening. However, this has been tested on big and little endian systems with the regression tests, so the regression risk is low with this fix.
----
Issue found on Eoan (5.3.0-42.34, 5.3.0-43.36) with all s390x instances:
- LPAR s2lp4
- zVM kernel03
- zKVM s2lp6g003
# selftests: net: tcp_fastopen_backup_key.sh
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# FAIL: TcpExtTCPFastOpenPassiveFail non-zero
not ok 30 selftests: net: tcp_fastopen_backup_key.sh # exit=1 |
== SRU Justification Focal, Groovy ==
Running the tcp_fastopen_backup_key.sh from net in ubuntu_kernel_selftests fails on big endian systems. This is a regression that occurred because of commit 438ac88009bc ("net: fastopen: robustness and endianness fixes for SipHash").
The test rotates TFO keys for ipv4/ipv6. It demonstrate how the primary and backup TFO keys can be rotated while minimizing the number of client cookies that are rejected. Due to an endianess issue, big endian systems were getting endian reversed values, so the values being from /proc/sys/net/ipv4/tcp_fastopen_key were reversed.
/proc/sys/net/ipv4/tcp_fastopen_key
== Fix ==
Upstream (linux-next) fix:
commit f19008e676366c44e9241af57f331b6c6edf9552
Author: Jason Baron <jbaron@akamai.com>
Date: Mon Aug 10 13:38:39 2020 -0400
tcp: correct read of TFO keys on big endian systems
== Test case ==
Run the kernel self tests tcp_fastopen_backup_key.sh. Currently this generally fails on the last few test cases. With the fix the test passes.
== Regression Potential ==
This fix touches the reading of the tcp fast open key proc interface /proc/sys/net/ipv4/tcp_fastopen_key and the getsockopt TCP_FASTOPEN_KEY interface so there is a potential for a regression when accessing data from these read-only interfaces.
There is some data copying to keys using unaligned puts and memcpy() so there is a potential that we may have data bounds errors causing memory corruption.
----
Issue found on Eoan (5.3.0-42.34, 5.3.0-43.36) with all s390x instances:
- LPAR s2lp4
- zVM kernel03
- zKVM s2lp6g003
# selftests: net: tcp_fastopen_backup_key.sh
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# PASS
# FAIL: TcpExtTCPFastOpenPassiveFail non-zero
not ok 30 selftests: net: tcp_fastopen_backup_key.sh # exit=1 |
|
| 2020-08-12 08:29:59 |
Stefan Bader |
linux (Ubuntu Focal): importance |
High |
Medium |
|
| 2020-08-20 21:52:19 |
Ian May |
linux (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2020-08-31 21:03:03 |
Ubuntu Kernel Bot |
tags |
5.3 5.4 eoan focal s390x sru-20200316 sru-20200629 ubuntu-kernel-selftests |
5.3 5.4 eoan focal s390x sru-20200316 sru-20200629 ubuntu-kernel-selftests verification-needed-focal |
|
| 2020-09-01 12:54:19 |
Colin Ian King |
tags |
5.3 5.4 eoan focal s390x sru-20200316 sru-20200629 ubuntu-kernel-selftests verification-needed-focal |
5.3 5.4 eoan focal s390x sru-20200316 sru-20200629 ubuntu-kernel-selftests verification-done-focal |
|
| 2020-09-03 21:55:34 |
Launchpad Janitor |
linux (Ubuntu Groovy): status |
In Progress |
Fix Released |
|
| 2020-09-03 21:55:34 |
Launchpad Janitor |
cve linked |
|
2019-19770 |
|
| 2020-09-21 10:38:15 |
Launchpad Janitor |
linux (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2020-09-21 10:38:15 |
Launchpad Janitor |
cve linked |
|
2020-12888 |
|
| 2020-09-30 03:00:56 |
Po-Hsu Lin |
ubuntu-kernel-tests: status |
In Progress |
Fix Released |
|
