Activity log for bug #1862114

Date Who What changed Old value New value Message
2020-02-06 06:18:34 Po-Hsu Lin bug added bug
2020-02-06 06:18:45 Po-Hsu Lin tags eoan sru-20200127 ubuntu-ltp
2020-02-06 06:19:01 Po-Hsu Lin tags eoan sru-20200127 ubuntu-ltp 5.3 eoan sru-20200127 ubuntu-ltp
2020-02-06 06:19:07 Po-Hsu Lin bug task added linux (Ubuntu)
2020-02-06 06:19:22 Po-Hsu Lin summary pty03 from ubuntu_ltp failed on Eoan pty03 from pty in ubuntu_ltp failed on Eoan
2020-02-06 06:19:29 Po-Hsu Lin nominated for series Ubuntu Eoan
2020-02-06 06:19:29 Po-Hsu Lin bug task added linux (Ubuntu Eoan)
2020-02-06 06:22:35 Po-Hsu Lin linux (Ubuntu Eoan): status New Confirmed
2020-02-06 06:22:55 Po-Hsu Lin description startup='Thu Feb 6 02:45:23 2020' tst_test.c:1215: INFO: Timeout per run is 0h 05m 00s pty03.c:101: INFO: Creating PTY with SLIP line discipline Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Test timeouted, sending SIGKILL! Cannot kill test processes! Congratulation, likely test hit a kernel bug. Exitting uncleanly... tag=pty03 stime=1580957123 dur=350 exit=exited stat=1 core=no cu=0 cs=0 startup='Thu Feb 6 02:45:23 2020'  tst_test.c:1215: INFO: Timeout per run is 0h 05m 00s  pty03.c:101: INFO: Creating PTY with SLIP line discipline  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Cannot kill test processes!  Congratulation, likely test hit a kernel bug.  Exitting uncleanly...  tag=pty03 stime=1580957123 dur=350 exit=exited stat=1 core=no cu=0 cs=0 This is a new test case, so it's not a regression.
2020-02-06 06:30:09 Ubuntu Kernel Bot linux (Ubuntu): status New Incomplete
2020-02-06 06:39:15 Po-Hsu Lin nominated for series Ubuntu Bionic
2020-02-06 06:39:15 Po-Hsu Lin bug task added linux (Ubuntu Bionic)
2020-02-06 06:59:16 Po-Hsu Lin linux (Ubuntu): status Incomplete Confirmed
2020-02-06 06:59:21 Po-Hsu Lin linux (Ubuntu Bionic): status New Confirmed
2020-02-06 06:59:25 Po-Hsu Lin ubuntu-kernel-tests: status New Confirmed
2020-02-06 07:11:06 Po-Hsu Lin nominated for series Ubuntu Xenial
2020-02-06 07:11:06 Po-Hsu Lin bug task added linux (Ubuntu Xenial)
2020-02-06 07:11:16 Po-Hsu Lin linux (Ubuntu Xenial): status New Confirmed
2020-02-06 08:09:04 Po-Hsu Lin nominated for series Ubuntu Disco
2020-02-06 08:09:04 Po-Hsu Lin bug task added linux (Ubuntu Disco)
2020-02-06 08:36:05 Po-Hsu Lin linux (Ubuntu Bionic): status Confirmed In Progress
2020-02-06 08:36:08 Po-Hsu Lin linux (Ubuntu Bionic): assignee Po-Hsu Lin (cypressyew)
2020-02-06 08:36:10 Po-Hsu Lin ubuntu-kernel-tests: assignee Po-Hsu Lin (cypressyew)
2020-02-06 08:36:15 Po-Hsu Lin ubuntu-kernel-tests: status Confirmed In Progress
2020-02-06 10:37:17 Po-Hsu Lin description startup='Thu Feb 6 02:45:23 2020'  tst_test.c:1215: INFO: Timeout per run is 0h 05m 00s  pty03.c:101: INFO: Creating PTY with SLIP line discipline  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Cannot kill test processes!  Congratulation, likely test hit a kernel bug.  Exitting uncleanly...  tag=pty03 stime=1580957123 dur=350 exit=exited stat=1 core=no cu=0 cs=0 This is a new test case, so it's not a regression. == Justification == The test case pty03 from pty in ubuntu_ltp is failing with kernel NULL pointer dereference: [ 951.306823] BUG: kernel NULL pointer dereference, address: 0000000000000020 [ 951.309960] #PF: supervisor write access in kernel mode [ 951.312130] #PF: error_code(0x0002) - not-present page [ 951.314227] PGD 0 P4D 0 [ 951.315278] Oops: 0002 [#1] SMP PTI [ 951.316705] CPU: 1 PID: 39102 Comm: pty03 Not tainted 5.4.0-12-generic #15-Ubuntu [ 951.319737] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014 [ 951.322713] RIP: 0010:queue_work_on+0x1b/0x50 [ 951.352494] Call Trace: [ 951.353244] slip_write_wakeup+0x25/0x30 [slip] [ 951.354600] tty_wakeup+0x5b/0x70 [ 951.355539] pty_unthrottle+0x19/0x30 [ 951.356560] tty_unthrottle+0x42/0x60 [ 951.357566] __tty_perform_flush+0x87/0x90 [ 951.358768] n_tty_ioctl_helper+0xcc/0x150 [ 951.359955] n_tty_ioctl+0x2d/0x100 [ 951.360930] tty_ioctl+0x3c0/0x8e0 [ 951.361882] ? __switch_to_asm+0x34/0x70 [ 951.363049] ? __switch_to_asm+0x40/0x70 [ 951.364191] ? __switch_to_asm+0x34/0x70 [ 951.365261] ? __switch_to_asm+0x40/0x70 [ 951.366382] ? __switch_to_asm+0x34/0x70 [ 951.367452] ? __switch_to_asm+0x40/0x70 [ 951.368523] ? __switch_to_asm+0x34/0x70 [ 951.369693] ? __switch_to_asm+0x40/0x70 [ 951.370829] ? __switch_to_asm+0x34/0x70 [ 951.371923] ? __switch_to_asm+0x40/0x70 [ 951.372998] ? __switch_to_asm+0x34/0x70 [ 951.374097] ? __switch_to_asm+0x40/0x70 [ 951.375183] ? __switch_to_asm+0x34/0x70 [ 951.376288] ? __switch_to_asm+0x40/0x70 [ 951.377390] ? __switch_to+0x110/0x470 [ 951.378863] do_vfs_ioctl+0x407/0x670 [ 951.380269] ? __schedule+0x2eb/0x740 [ 951.381761] ksys_ioctl+0x67/0x90 [ 951.383076] __x64_sys_ioctl+0x1a/0x20 [ 951.384510] do_syscall_64+0x57/0x190 [ 951.385896] entry_SYSCALL_64_after_hwframe+0x44/0xa9 == Fixes == Indicated by the test case, this issue can be fixed by: * 0ace17d5 (can, slip: Protect tty->disc_data in write_wakeup and close with RCU) This patch can be cherry-picked into all of our kernels. == Test == Test kernels could be found here: https://people.canonical.com/~phlin/kernel/lp-1862114-pty03/ Tested on KVM nodes and the patched kernels work as expected, there will be no more kernel null pointer dereference issue, and the test can finish properly. == Regression potential == Low, changes limited to two specific drivers for serial line TTY. This issue can be reproduced quite easily and the patched kernels show positive results. == Original Bug Report == startup='Thu Feb 6 02:45:23 2020'  tst_test.c:1215: INFO: Timeout per run is 0h 05m 00s  pty03.c:101: INFO: Creating PTY with SLIP line discipline  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Test timeouted, sending SIGKILL!  Cannot kill test processes!  Congratulation, likely test hit a kernel bug.  Exitting uncleanly...  tag=pty03 stime=1580957123 dur=350 exit=exited stat=1 core=no cu=0 cs=0 This is a new test case, so it's not a regression.
2020-02-06 10:37:19 Po-Hsu Lin linux (Ubuntu): status Confirmed In Progress
2020-02-06 10:37:30 Po-Hsu Lin linux (Ubuntu): assignee Po-Hsu Lin (cypressyew)
2020-02-06 10:37:36 Po-Hsu Lin linux (Ubuntu Eoan): assignee Po-Hsu Lin (cypressyew)
2020-02-06 10:37:39 Po-Hsu Lin linux (Ubuntu Disco): assignee Po-Hsu Lin (cypressyew)
2020-02-06 10:37:46 Po-Hsu Lin linux (Ubuntu Xenial): assignee Po-Hsu Lin (cypressyew)
2020-02-06 10:38:13 Po-Hsu Lin linux (Ubuntu Xenial): status Confirmed In Progress
2020-02-06 10:38:15 Po-Hsu Lin linux (Ubuntu Disco): status New In Progress
2020-02-06 10:38:18 Po-Hsu Lin linux (Ubuntu Eoan): status Confirmed In Progress
2020-02-14 04:24:44 Khaled El Mously linux (Ubuntu Xenial): status In Progress Fix Committed
2020-02-14 04:24:46 Khaled El Mously linux (Ubuntu Bionic): status In Progress Fix Committed
2020-02-14 04:24:48 Khaled El Mously linux (Ubuntu Disco): status In Progress Fix Committed
2020-02-14 04:24:51 Khaled El Mously linux (Ubuntu Eoan): status In Progress Fix Committed
2020-02-17 21:02:19 Ubuntu Kernel Bot tags 5.3 eoan sru-20200127 ubuntu-ltp 5.3 eoan sru-20200127 ubuntu-ltp verification-needed-xenial
2020-02-17 21:28:39 Ubuntu Kernel Bot tags 5.3 eoan sru-20200127 ubuntu-ltp verification-needed-xenial 5.3 eoan sru-20200127 ubuntu-ltp verification-needed-bionic verification-needed-xenial
2020-02-17 22:52:06 Ubuntu Kernel Bot tags 5.3 eoan sru-20200127 ubuntu-ltp verification-needed-bionic verification-needed-xenial 5.3 eoan sru-20200127 ubuntu-ltp verification-needed-bionic verification-needed-eoan verification-needed-xenial
2020-02-18 06:44:38 Po-Hsu Lin tags 5.3 eoan sru-20200127 ubuntu-ltp verification-needed-bionic verification-needed-eoan verification-needed-xenial 5.3 eoan sru-20200127 ubuntu-ltp verification-done-bionic verification-needed-eoan verification-needed-xenial
2020-03-05 07:03:05 Po-Hsu Lin tags 5.3 eoan sru-20200127 ubuntu-ltp verification-done-bionic verification-needed-eoan verification-needed-xenial 5.3 eoan sru-20200127 ubuntu-ltp verification-done-bionic verification-done-eoan verification-needed-xenial
2020-03-05 07:14:26 Po-Hsu Lin tags 5.3 eoan sru-20200127 ubuntu-ltp verification-done-bionic verification-done-eoan verification-needed-xenial 5.3 eoan sru-20200127 ubuntu-ltp verification-done-bionic verification-done-eoan verification-done-xenial
2020-03-05 07:14:46 Po-Hsu Lin ubuntu-kernel-tests: status In Progress Fix Released
2020-03-05 08:05:21 Sean Feole tags 5.3 eoan sru-20200127 ubuntu-ltp verification-done-bionic verification-done-eoan verification-done-xenial 5.3 eoan sru-20200127 sru-20200217 ubuntu-ltp verification-done-bionic verification-done-eoan verification-done-xenial
2020-03-16 10:39:46 Launchpad Janitor linux (Ubuntu Eoan): status Fix Committed Fix Released
2020-03-16 10:39:46 Launchpad Janitor cve linked 2019-3016
2020-03-16 10:39:46 Launchpad Janitor cve linked 2020-2732
2020-03-16 10:53:57 Launchpad Janitor linux (Ubuntu Bionic): status Fix Committed Fix Released
2020-03-16 10:53:57 Launchpad Janitor cve linked 2019-14615
2020-03-16 10:53:57 Launchpad Janitor cve linked 2020-8832
2020-03-16 14:25:28 Launchpad Janitor linux (Ubuntu Xenial): status Fix Committed Fix Released
2020-03-30 08:31:37 Po-Hsu Lin linux (Ubuntu): status In Progress Fix Released
2020-07-02 20:02:44 Steve Langasek linux (Ubuntu Disco): status Fix Committed Won't Fix