Zesty: gnome-software crashes on start if gnome-software-plugin-flatpak is installed

[Jeremy Bícha]

What Happens
============
* From Ubuntu 17.04 Alpha, install gnome-software-plugin-flatpak

gnome-software will now refuse to start.

* When I run it from the command line, I get this output:

I kill all running instances of gnome-software before starting it:
$ pkill gnome-software
$ gnome-software
06:15:12:0290 GLib-GObject cannot register existing type 'GsFlatpak'
06:15:12:0290 GLib g_once_init_leave: assertion 'result != 0' failed
06:15:12:0290 GLib-GObject g_object_new: assertion 'G_TYPE_IS_OBJECT (object_type)' failed

I am unable to reproduce this crash on Debian. Installing gnome-software-plugin-flatpak there works fine.

If we can't fix this, I believe we have no choice but to disable the Flatpak plugin. Installing something from the Ubuntu archives can't be allowed to break such a critical app.

Other things I've tried
=======================
- Rebasing the Ubuntu patches on top of 3.22.4 instead of 3.22.2
- Building the PackageKit plugin instead of Ubuntu's custom apt plugin

[Richard Hughes (richard-hughes)]

Can you show me the patches that you're applying on top of the tarball? It looks like something is using GsFlatpak from outside the flatpak plugin. Could you also please grab the entire --verbose log please with no other gnome-software's running. Thanks.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Jeremy Bícha (jbicha)]

$ pkill gnome-software
$ gnome-software --verbose
16:36:53:0973 Gs compatible-project: GNOME
16:36:53:0973 Gs compatible-project: KDE
16:36:53:0973 Gs compatible-project: XFCE
16:36:53:0973 As run GsPlugin::setup
16:36:53:0973 Gs searching for plugins in /usr/lib/gs-plugins-11
16:36:53:0975 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_apt.so: apt
16:36:53:0976 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_shell-extensions.so: shell-extensions
16:36:53:0976 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_key-colors.so: key-colors
16:36:53:0976 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_desktop-categories.so: desktop-categories
16:36:53:0976 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_epiphany.so: epiphany
16:36:53:0994 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_ubuntu-reviews.so: ubuntu-reviews
16:36:53:0994 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit-refine.so: packagekit-refine
16:36:53:0994 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_hardcoded-popular.so: hardcoded-popular
16:36:53:0994 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_provenance.so: provenance
16:36:54:0006 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_modalias.so: modalias
16:36:54:0006 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit-offline.so: packagekit-offline
16:36:54:0007 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit-proxy.so: packagekit-proxy
16:36:54:0008 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_appstream.so: appstream
16:36:54:0008 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit-upgrade.so: packagekit-upgrade
16:36:54:0009 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit-origin.so: packagekit-origin
16:36:54:0009 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_dummy.so: dummy
16:36:54:0010 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_odrs.so: odrs
16:36:54:0010 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_steam.so: steam
16:36:54:0031 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_snap.so: snap
16:36:54:0032 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit-local.so: packagekit-local
16:36:54:0032 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_hardcoded-featured.so: hardcoded-featured
16:36:54:0041 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_fwupd.so: fwupd
16:36:54:0042 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit-history.so: packagekit-history
16:36:54:0043 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_provenance-license.so: provenance-license
16:36:54:0044 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_ubuntuone.so: ubuntuone
16:36:54:0044 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit.so: packagekit
16:36:54:0045 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_icons.so: icons
16:36:54:0045 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_packagekit-refresh.so: packagekit-refresh
16:36:54:0087 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_flatpak-user.so: flatpak-user
16:36:54:0088 Gs opened plugin /usr/lib/gs-plugins-11/libgs_plugin_hardcoded-b...

[Jeremy Bícha (jbicha)]

The only Ubuntu patches used can be found at
https://git.gnome.org/browse/gnome-software/log/?h=wip/ubuntu-zesty

I also rebased on top of gnome-software 3.22.4 but I noticed some regressions for Ubuntu so didn't push to zesty yet. I haven't looked into what commits caused the problems.

https://git.launchpad.net/~jbicha/gnome-software/log/?h=wip/ubuntu-zesty

Ubuntu zesty does have a little older ostree and flatpak: ostree 2016.13-1 and flatpak 0.6.13-1. I'll try again with ostree 2016.15-2ubuntu1 and flatpak 0.6.14-3 later.

Debian and Ubuntu do not ship gnome-software's ostree plugin.

[Jeremy Bícha (jbicha)]

Still fails with flatpak 0.6.14

[Jeremy Bícha (jbicha)]

/usr/bin/gnome-software:11:gs_flatpak_new:gs_plugin_initialize:gs_plugin_loader_run:gs_plugin_loader_setup:gs_application_initialize_plugins

The Ubuntu Error Tracker has been receiving reports about a problem regarding gnome-software. This problem was most recently seen with package version 3.22.2+git20161108.0.a58dfc7-0ubuntu5, the problem page at https://errors.ubuntu.com/problem/cf5b08f19986d36b76789dc63943c60a0ee6ce23 contains more details, including versions of packages affected, stacktrace or traceback, and individual crash reports.

If you do not have access to the Ubuntu Error Tracker you can request it at https://forms.canonical.com/reports/.

[AsciiWolf (asciiwolf)]

Still the same problem with flatpak-0.8.0-1 and gnome-software-plugin-flatpak-3.22.2+git20161108.0.a58dfc7-0ubuntu5.

[Iain Lane (laney)]

Try building without -Bsymbolic-functions

[Jeremy Bícha (jbicha)]

Thanks, that fixes this.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-software - 3.22.5+really-3.22.4-0ubuntu1

---------------
gnome-software (3.22.5+really-3.22.4-0ubuntu1) zesty; urgency=medium

  * Merge with Debian and build from the upstream tarball instead
    of from a wip/ubuntu* branch. Remaining changes:
    - Add "Ubuntu Software" package
    - debian/control.in:
      + Build-Depend on libsnapd-glib-dev and enable snap plugin
      + Build-Depend on libapt-pkg-dev
      + Depend on aptdaemon
      + Depend on gnome-software-plugin-snap
      + Bump gnome-software-plugin-snap's Breaks/Replaces
        since we took the split later
    - debian/rules:
      + Don't enable PackageKit
    - debian/gnome-software.gsettings-override.in, debian/rules:
      + Add 'universe' to free-sources
    - Add patches numbered 0001-0013 from the git branch.
      Read the patch descriptions for more information.
  * debian/rules: Build without symbolic functions to fix Flatpak plugin.
    Thanks again Iain Lane (LP: #1650783)
  * Add 1001-trivial-Fix-a-deadlock-when-setting-the-origin-multi.patch:
    - Add commit from upstream 3.22 branch to fix regression in 3.22.4
  * Drop debian/README.source, unneeded since we don't build from git now

gnome-software (3.22.4-1) unstable; urgency=medium

  [ Jeremy Bicha ]
  * debian/gnome-software.gsettings-override.in, debian/rules:
    - Use Ubuntu's licensing URL when built on Ubuntu
  * debian/rules:
    - Enable Ubuntu Reviews on Ubuntu

  [ Laurent Bigonville ]
  * New upstream release
    - Bump libappstream-glib-dev and libflatpak-dev build-dependencies
    - Drop debian/patches/01_pkgname-sanity.patch and
      debian/patches/02_packagekit-linking.patch, applied upstream
    - Disable gnome-software-plugin-snap package, it now requires snapd-glib
      which is not in debian yet

 -- Jeremy Bicha <email address hidden> Thu, 12 Jan 2017 16:50:03 -0500