viewMethod (Icons/List) is handled as translated string, which makes all files invisible between language changes

[Alexey Dokuchaev]

viewMethod property of filemanager.qml is stored as either i18n.tr("Icons") or i18n.tr("List") instead of e.g. 0 or 1, which is very fragile logic; saved settings should never depend on user's locale. As a result, changing system language will render all your files and directories invisible, because, in FolderListPage.qml, both "visible: viewMethod === i18n.tr("Icons")" and "visible: viewMethod === i18n.tr("List")" checks will now return false. Users would have to reselect "View As" to see their files again, every time they change system language.

In ViewPopover.qml, "selectedIndex: values.indexOf(viewMethod)" is bogus even on the readability level: selectedIndex should naturally be just indexOf(viewMethod), without the "values." prefix.