ActionSelectionPopover does not handle the 'visible' property of actions properly

[Niklas Wenzel]

When setting the 'visible' property of an action in an ActionList of an ActionSelectionPopover to false, the delegate will not be hidden but instead be shown at the top of the list behind the first visible delegate. (Check out the screenshot.)

Demo code (containing an outcommented workaround):

import QtQuick 2.3
import Ubuntu.Components 1.1
import Ubuntu.Components.Popups 1.0
import Ubuntu.Components.ListItems 1.0

MainView {
    width: units.gu(50)
    height: units.gu(75)

    Page {
        title: i18n.tr("ActionSelectionPopover Fix")

        Button {
            id: button
            width: parent.width

            text: i18n.tr("Show popover")

            onClicked: {
                PopupUtils.open(actionSelectionPopoverComponent, button)
            }
        }

        Component {
            id: actionSelectionPopoverComponent

            ActionSelectionPopover {
                actions: ActionList {
                    Action {
                        text: "Action one"
                    }
                    Action {
                        text: "Action two"
                    }
                    Action {
                        text: "Hidden action"
                        visible: false
                    }
                }

                // Uncomment the following for a temporary workaround:

// delegate: Empty {
// id: listItem
// Label {
// text: listItem.text
// anchors {
// verticalCenter: parent.verticalCenter
// horizontalCenter: parent.horizontalCenter
// }
// wrapMode: Text.Wrap
// color: Theme.palette.normal.overlayText
// }
// /*! \internal */
// onTriggered: popover.hide()
// visible: enabled && ((action === undefined) || action.visible)
// height: visible ? implicitHeight : 0
// }
            }
        }
    }
}

[Niklas Wenzel (nikwen)]

I just added the ubuntu-filemanager-app project to this bug report as that's where the issue first occured. It currently uses the workaround from the bug description and will remove it as soon as possible.
https://code.launchpad.net/~nikwen/ubuntu-filemanager-app/zips/+merge/239662

[Niklas Wenzel (nikwen)]

Zoltan, thank you for assigning this to the right project. Should I always file bugs against "ubuntu-ui-toolkit (Ubuntu)" instead of "ubuntu-ui-toolkit"?

[Pat McGowan (pat-mcgowan)]

fix in the first update

[Niklas Wenzel (nikwen)]

Thanks, Pat. :)

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1403+15.04.20150206-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1403+15.04.20150206-0ubuntu1) vivid; urgency=medium

  [ Albert Astals Cid ]
  * Adapt to behaviour change in handling of QVariants from QML to
    C++ in Qt 5.4
  * Don't use Qt::PopupFocusReason to change the focus Even if it
    is the correct reason QtQuick is since 5.4 ignoring focus changes
    due to PopupFocusReason. Fixes LP: #1395014.
  * Fix test failure with Qt 5.4 ExpandablesColumn::test_expandedItem()
    In Qt 5.4 an alias to a null variable is correctly null instead of
    undefined like it was in 5.3, since we still want 5.3 support i'm
    conveting it to a verify with == that uses JS loose comparison to
    accept both null and undefined. Fixes LP: #1395012.

  [ Alexandre Abreu ]
  * Remove the unecessary DBUS bindingi to global address
    org.freedesktop.Application by the UriHAndler. It actually fails
    for confined apps and the uri-dispatcher anyway does not work by
    directly calling into the exposed "well known names" exposed on
    the bus as TEd explains here LP: #1342129 but by directly calling
     into the process dbus connection. Fixes LP: #1378823.

  [ Benjamin Zeller ]
  * Fix scripts to work in shadowbuild mode.
  * Shadowbuild support for ubuntu-ui-toolkit.

  [ Christian Dywan ]
  * Abort export_modules_dir.sh and ergo run_tests.sh if binaries are
    absent. Fixes LP: #1415973.
  * Asterisk are needed for cp -R.
  * Ensure adb is running (and fallback arch if dpkg-dev is missing).
    Fixes LP: #1417997.
  * Get arch for push_to_phone.sh from device and handle adb refusal.
  * Implement and unit-test i18n.(c)tag. Fixes LP: #1417031.
  * Print component creation errors in popupUtils.open.
    Fixes LP: #1418507.
  * Use correct unfocussed text field color. Fixes LP: #1396062.

  [ Daniel d'Andrada ]
  * Refactor OrientationHelper Simplify animation code and make it
    more robust. It now survives changes in Screen.primaryOrientation
    and Screen.orientation happening one right after the other.

  [ Daniel Holbach ]
  * Fix broken link to developer site.

  [ Giulio Collura ]
  * This is a bugfix for bug LP: #1341814 and bug LP: #1400297.
    Essentially we have to force the removal of the previous
    'contents' item by removing its parent. This way we ensure that
    the contents are correctly hidden, focused and removed, without
    destroying them.

  [ Loïc Molinari ]
  * Removed unused variables breaking debug builds.

  [ Michael Sheldon ]
  * Only use stableOrientationAngleTimer in the OrientationHelper when
    the orientationAngle has been set automatically.
    Fixes LP: #1409027.

  [ Niklas Wenzel ]
  * Fixes LP: #1395118

  [ nskaggs ]
  * Re-add autopilot helper documentation and update. Fixes
    LP: #1409778, LP: #1410477.

  [ Tim Peeters ]
  * Add a preview of the new list items to the UITK component gallery.
  * Add performance test for MainView.
  * Clean python code to follow pep257 standards.
  * Fix incorrect header contents width when navigating back from a
    page with a lot of actions. Fixes LP: #1408481.
  * Split up MainView in MainView and ...

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-ui-toolkit - 1.1.1298+15.04.20150218.1~rtm-0ubuntu1

---------------
ubuntu-ui-toolkit (1.1.1298+15.04.20150218.1~rtm-0ubuntu1) 14.09; urgency=medium

  [ Niklas Wenzel ]
  * ActionSelectionPopover: Handle the 'visible' property of actions
    properly (LP: #1395118)
 -- CI Train Bot <email address hidden> Wed, 18 Feb 2015 16:59:43 +0000

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-filemanager-app at revision 458, scheduled for release in ubuntu-filemanager-app, milestone alpha-1