Remove duplicate uses of 'folder' and 'path'
Bug #1331702 reported by
David Planella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu File Manager App |
Fix Released
|
Low
|
David Planella | ||
Bug Description
Right now we're using two variables on the folder list model to track the current path: 'folder' and 'path'. We should be removing one of them.
Related branches
lp:~dpm/ubuntu-filemanager-app/placesmodel-2
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Michael Spencer: Approve
-
Diff: 1213 lines (+558/-263)22 files modifieddebian/control (+12/-1)
debian/qtdeclarative5-placesmodel0.1.install (+1/-0)
src/app/qml/components/FolderIconDelegate.qml (+1/-1)
src/app/qml/components/FolderListDelegate.qml (+1/-1)
src/app/qml/components/PathBar.qml (+2/-1)
src/app/qml/components/PlacesSidebar.qml (+15/-37)
src/app/qml/filemanager.qml (+7/-2)
src/app/qml/ui/FileDetailsPopover.qml (+2/-2)
src/app/qml/ui/FolderListPage.qml (+148/-165)
src/app/qml/ui/GoToDialog.qml (+1/-1)
src/app/qml/ui/PlacesPopover.qml (+5/-38)
src/app/qml/ui/ViewPopover.qml (+2/-2)
src/plugin/CMakeLists.txt (+1/-0)
src/plugin/placesmodel/CMakeLists.txt (+35/-0)
src/plugin/placesmodel/placesmodel.cpp (+174/-0)
src/plugin/placesmodel/placesmodel.h (+64/-0)
src/plugin/placesmodel/placesmodel_plugin.cpp (+34/-0)
src/plugin/placesmodel/placesmodel_plugin.h (+39/-0)
src/plugin/placesmodel/qmldir (+2/-0)
tests/autopilot/filemanager/tests/__init__.py (+6/-6)
tests/autopilot/filemanager/tests/test_filemanager.py (+5/-5)
tests/autopilot/filemanager/tests/test_places.py (+1/-1)
| Changed in ubuntu-filemanager-app: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| assignee: | nobody → David Planella (dpm) |
| Changed in ubuntu-filemanager-app: | |
| status: | Triaged → In Progress |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-filemanager-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-filemanager-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-filemanager-app at revision 213, scheduled for release in ubuntu-