Ctrl+L shortcut does not work

[David Planella]

Trying to use the Ctrl+L shortcut with the app running on the desktop does not work, issuing the following error:

src/app/qml/ui/FolderListPage.qml:703: ReferenceError: goToButton is not defined

This happens because the goToButton the popup is referring to is defined in another QML file.

[Jason (gerlowskija)]

So I took a quick look at this. The line causing trouble (the same one mentioned in the description above) is:

PopupUtils.open(Qt.resolvedUrl("GoToDialog.qml"), goToButton)

The fix looks pretty straightforward. I tried replacing "goToButton" with an ID from some of the high level components (specifically: "mainView" and "pageStack")...and it worked! So the fix for this might be easy.

Before I push up a branch with a fix though, I wanted to double-check my understanding of what that second argument of PopupUtils.open() does. I've looked around a few times for documentation on what the arguments are, but been unsuccessful. My understanding is that the second argument is the parent component for the new pop-up, but that's just a guess. Can anyone confirm that?

[David Planella (dpm)]

Hi Jason,

The second argument for PopUputils.open() is the caller of the function.
You can also use a third argument to pass parameters, and see more context
here, including a link to the source code.

http://askubuntu.com/a/306562/9781

Cheers,
David.

On Sat, Jun 28, 2014 at 4:02 PM, Jason <email address hidden> wrote:

> So I took a quick look at this. The line causing trouble (the same one
> mentioned in the description above) is:
>
> PopupUtils.open(Qt.resolvedUrl("GoToDialog.qml"), goToButton)
>
> The fix looks pretty straightforward. I tried replacing "goToButton"
> with an ID from some of the high level components (specifically:
> "mainView" and "pageStack")...and it worked! So the fix for this might
> be easy.
>
> Before I push up a branch with a fix though, I wanted to double-check my
> understanding of what that second argument of PopupUtils.open() does.
> I've looked around a few times for documentation on what the arguments
> are, but been unsuccessful. My understanding is that the second
> argument is the parent component for the new pop-up, but that's just a
> guess. Can anyone confirm that?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> Matching subscriptions: File Manager App Bugmail
> https://bugs.launchpad.net/bugs/1331333
>
> Title:
> Ctrl+L shortcut does not work
>
> Status in File Manager application for Ubuntu devices:
> Triaged
>
> Bug description:
> Trying to use the Ctrl+L shortcut with the app running on the desktop
> does not work, issuing the following error:
>
> src/app/qml/ui/FolderListPage.qml:703: ReferenceError: goToButton is
> not defined
>
> This happens because the goToButton the popup is referring to is
> defined in another QML file.
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1331333/+subscriptions
>

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-filemanager-app at revision 221, scheduled for release in ubuntu-filemanager-app, milestone alpha-1