broken test test_cut_directory

[Timo Jyrinki]

It seems filemanager.tests.test_filemanager.TestFolderListPage.test_cut_directory(with touch) may fail sometimes on the test infrastructure, so it should be made more trustworthy.

Attached is a log

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-filemanager-app at revision 173, scheduled for release in ubuntu-filemanager-app, milestone alpha-1

[Chris Gagnon (chris.gagnon)]

There is still flakyness in this test, re-opening bug

[Alan Pope 🍺🐧🐱 🦄 (popey)]

I ran the full set of tests on #37 (proposed) mako and found the device white screens through the tests on and off.
I ran the same tests on #27 (devel) and they all pass.
Seems something broke on the platform between 27 and 37.

[Chris Gagnon (chris.gagnon)]

This is not a bug in the tests but a bug in the application it self, it starts with a white screen and never loads all the way.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

The issue only seems to present itself during tests though. There's something IMO about the way the tests launch the application (or perhaps the way they re-launch the application repeatedly) which triggers the event. More investigation is required, but I have yet to be able to reproduce this when just launching the app "normally" by a human.

[Jean-Baptiste Lallement (jibel)]

I confirm that running the test step by step manually (without autopilot) on the phone (build 51) succeeds. I also started the application several times and it always loaded successfully even if it takes a moment to start but not more than 3 to 5 seconds.

@ChrisGagnon, could you look at the autopilot test and find out why the application doesn't start when launched with AP?

[I Ahmad (iahmad)]

Adding to what jibel said above, it seems sequence of test is playing a role in failure. So when executing the individual test test_cut_directory in a loop for several time, it passes but when executing multiple tests and test_cut_directory is not the firs one then it could fail while manually doing the same is not reproducing the issue. So this could be the problem with the tool or the way test is written. Tests execution sequence should not play any role in pass or failure unless sequence of action itself is being tested in which case the entire sequence should be tested in one test.

[Chris Gagnon (chris.gagnon)]

On tests that fail I see

file:///usr/share/click/preinstalled/com.ubuntu.filemanager/0.3.173/qml/components/PathBar.qml:124: TypeError: Cannot read property of null
void DirModel::setPath(const QString&) DirModel_QML_120(0x15f5a70) Ignoring path change request, request already running

This should be fixed to ruled out as the cause of issue, null properties can cause a white screen from what I've discussed with members of the apps team.

[Nicholas Skaggs (nskaggs)]

I'd like to bring back up Alan's point; he was kind enough to confirm something in the image caused the regression (unless someone else can dispute it):

https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1316677/comments/4

Chris, have you been able to finish the tool that would make it easy for us to isolate the change causing this issue?

[Victor Thompson (vthompson)]

I've related a branch [1] that fixes the null error reported in comment #9 by Chris [2]. Unfortunately, this does not seem to fix the test failures or the whitescreen issue.

[1] https://code.launchpad.net/~vthompson/ubuntu-filemanager-app/fix-null-error-1316677
[2] https://bugs.launchpad.net/ubuntu-filemanager-app/+bug/1316677/comments/9

[Jean-Baptiste Lallement (jibel)]

Chris, could you have another look with Vicor's patch applied? Thanks.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-filemanager-app at revision 199, scheduled for release in ubuntu-filemanager-app, milestone alpha-1

[Leo Arias (elopio)]

I'm readding the broken test tag so this one appears on our search.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

balloons asked to see a video of the AP tests running. Here it is.

http://youtu.be/r0wiBwbme6E

http://paste.ubuntu.com/7653494/

[Victor Thompson (vthompson)]

I think this goes hand in hand with the other flaky tests. I think starting and stopping maliit-server, aka the OSK, seems to be playing a large role in this. I did two runs of the complete tests and have thus far only had one fauilure with "test_copy_file" using the lp:~vthompson/ubuntu-filemanager-app/fix-test-issues branch linked.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-filemanager-app at revision 205, scheduled for release in ubuntu-filemanager-app, milestone alpha-1