trademark.css not loaded

Bug #688289 reported by Pierre Buyle on 2010-12-09
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
UD Theme
Low
Unassigned

Bug Description

For some reason, sometime the trademark.css does not load on ubuntu-be.org.

It doesn't load in Chrome or Firefox, unless I log into the site and then it works (see screenshots)

Related branches

Pierre Buyle (mongolito404) wrote :
Pierre Buyle (mongolito404) wrote :
Pierre Buyle (mongolito404) wrote :

The issue seems to be with hosting the file on LP. I suggest to change the behavior of the theme and to download to file into Drupal's temporary directory when the the trigger the use of the trademark.css file is set. That way we don't distribute the trademarked file on drupal.org and we require a user interaction to download it.

Is there any chance you could offer a patch to change this behavior? I like the idea but don't have the time to change it.

Also, in Drupal 7, it's easily possible to include an external style sheets and seems to work pretty reliably. Any chance you could see how it's being done in the D7 version and tell me if it works any better?

The only issue I see with downloading the file is when it's updated and needs to be downloaded again. There's no cron hook for themes to even check that the file has changed.

Pierre Buyle (mongolito404) wrote :

Fix commited in the D6 branch. D7 version needed.

Changed in ubuntu-drupal-theme:
status: New → In Progress

Did you get anywhere with the D7 version?

$download = !file_exists($filepath);
if (!$download) {
}
if ($download) {
}

I was just thinking that maybe this would be better?
if (file_exists($filepath)) {
}
else {
}

That might be a little more clean, but looks amazing otherwise. :)

Pierre, do you still have intentions of pushing this into the D7 version as well?

Changed in ubuntu-drupal-theme:
importance: Undecided → Low
assignee: nobody → Michael Lustfield (mtecknology)

Looks like Pierre took into account some things I didn't. I'm pretty excited about how well this piece works. :)

Changed in ubuntu-drupal-theme:
assignee: Michael Lustfield (mtecknology) → nobody
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers