Use t() or l() where appropriate

Bug #443439 reported by Pierre Buyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
UD Countdown
Fix Released
Medium
Michael Lustfield
UD Header
Fix Released
Medium
Michael Lustfield
UD Sidebar
Fix Released
Medium
Michael Lustfield
UD Theme
Fix Released
Medium
Michael Lustfield

Bug Description

I'm in the process to use this module for the Ubuntu-be.org website. Being Belgium we have four languages for our website. It would be nice to support the standard i18n for headers' text.

As a quick hack, I wrapped $rslt['centertext'] and $rslt['righttext'] into t() in udheader_build_block so the original text (presumably in English) can be translated with Drupal "Translate interface" admin page.

A better solution would be to have multiple text area (one for each language) when editing an header.

summary: - Support i18n
+ Use t() or l() where appropriate
Revision history for this message
Michael Lustfield (michaellustfield) wrote :

This is more of a generic bug across all modules I've developed. I need to use t() and l() when I'm controlling data that will print to the screen. When I have some time I will run through everything and take care of it.

"A better solution would be to have multiple text area (one for each language) when editing an header."
 - This would be very sub-optimal. It is a better idea to leave the translations to drupal by using the correct functions.

Changed in ubuntu-drupal-theme:
assignee: nobody → Michael Lustfield (mtecknology)
importance: Undecided → Medium
status: New → Triaged
Changed in ubuntu-drupal-sidebar:
assignee: nobody → Michael Lustfield (mtecknology)
importance: Undecided → Medium
status: New → Triaged
Changed in ubuntu-drupal-header:
assignee: nobody → Michael Lustfield (mtecknology)
importance: Undecided → Medium
status: New → Triaged
Changed in ubuntu-drupal-countdown:
assignee: nobody → Michael Lustfield (mtecknology)
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Michael Lustfield (michaellustfield) wrote :

This has been taken care of in udheader r22.

Changed in ubuntu-drupal-header:
status: Triaged → Fix Committed
Revision history for this message
Michael Lustfield (michaellustfield) wrote :

udcountdown r34

Changed in ubuntu-drupal-countdown:
status: Triaged → Fix Committed
Revision history for this message
Michael Lustfield (michaellustfield) wrote :

udsidebar r9

Changed in ubuntu-drupal-sidebar:
status: Triaged → Fix Committed
Revision history for this message
Michael Lustfield (michaellustfield) wrote :

udtheme r148

Changed in ubuntu-drupal-theme:
status: Triaged → Fix Committed
Revision history for this message
Michael Lustfield (michaellustfield) wrote :

These fixes has been merged into drupal.org.

Changed in ubuntu-drupal-theme:
status: Fix Committed → Fix Released
Changed in ubuntu-drupal-sidebar:
status: Fix Committed → Fix Released
Changed in ubuntu-drupal-header:
status: Fix Committed → Fix Released
Changed in ubuntu-drupal-countdown:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.