| 2009-05-21 21:07:51 |
Rocky Road |
bug |
|
|
added bug |
| 2009-05-21 21:07:51 |
Rocky Road |
attachment added |
|
columns-layout.patch http://launchpadlibrarian.net/27029798/columns-layout.patch |
|
| 2009-05-21 23:22:38 |
Michael Lustfield |
ubuntu-drupal-theme: importance |
Undecided |
Low |
|
| 2009-05-21 23:22:38 |
Michael Lustfield |
ubuntu-drupal-theme: status |
New |
Triaged |
|
| 2009-05-21 23:22:38 |
Michael Lustfield |
ubuntu-drupal-theme: assignee |
|
Rocky Road (m-baert) |
|
| 2009-05-24 08:38:35 |
Rocky Road |
description |
Now that most (sigh) css rules are in css file, I'll try to help fixing them.
== Unused or misnamed container ids ==
Looking at page.tpl.php, I see that the main content is organised with
the following hierarchy:
#container
$breadcrumb
#container3
#container2
#container1
#col1
#col2
#col3
so selectors with #container0, container-1, container-2, container-3 will be ignored.
I removed them in the patch below.
Also, #container3 and #container2 are just bare wrappers (no extra content) which
just add confusion in the stylesheet. I propose to remove all rules for them,
as well as the elements themselves.
== Misuse of "right" css property ==
See http://www.w3.org/TR/1998/REC-CSS2-19980512/visuren.html#propdef-right
"This property specifies how far a box's right content edge is offset to the left of the right edge of the box's containing block. "
Then in #container1, I read
width: 100%;
right: 75%;
This implies that left is now -75%, and it sadly means that the offsets of all inner elements have to balance this strange offset.
Recall that width percentage is calculated with respect to the width of the generated box's containing block. ( http://www.w3.org/TR/1998/REC-CSS2-19980512/visudet.html#the-width-property )
== overflow settings ==
Most rules in the layout section define "overflow=hidden".
This makes the errors related to above one, very critical !
http://www.w3.org/TR/1998/REC-CSS2-19980512/visufx.html#overflow-clipping
Moreover, this property's (as well as "position"'s) default value is "inherit", so there's no need to repeat it in inner elements.
http://www.w3.org/TR/1998/REC-CSS2-19980512/cascade.html#value-def-inherit
Also, I'm not sure that defining overflow where width=100% makes sense.
== Columns positionning ==
Why not leaving "float:left" doing the job of setting the "left" value ? just set "width"
I'd tend to see float and left as conflicting ways of specifing horizontal position of the box.
Better choose one and stick to it.
As I prefer the more modern fluid layouts, I'd try float.
== The patch ==
Values are only rough settings, there is some work to get a good rendering, I leave this to you.
But I'm sure it should be far easier with this new structure. |
Follows bug #379084
Now that most (sigh) css rules are in css file, I'll try to help fixing them.
== Unused or misnamed container ids ==
Looking at page.tpl.php, I see that the main content is organised with
the following hierarchy:
#container
$breadcrumb
#container3
#container2
#container1
#col1
#col2
#col3
so selectors with #container0, container-1, container-2, container-3 will be ignored.
I removed them in the patch below.
Also, #container3 and #container2 are just bare wrappers (no extra content) which
just add confusion in the stylesheet. I propose to remove all rules for them,
as well as the elements themselves.
== Misuse of "right" css property ==
See http://www.w3.org/TR/1998/REC-CSS2-19980512/visuren.html#propdef-right
"This property specifies how far a box's right content edge is offset to the left of the right edge of the box's containing block. "
Then in #container1, I read
width: 100%;
right: 75%;
This implies that left is now -75%, and it sadly means that the offsets of all inner elements have to balance this strange offset.
Recall that width percentage is calculated with respect to the width of the generated box's containing block. ( http://www.w3.org/TR/1998/REC-CSS2-19980512/visudet.html#the-width-property )
== overflow settings ==
Most rules in the layout section define "overflow=hidden".
This makes the errors related to above one, very critical !
http://www.w3.org/TR/1998/REC-CSS2-19980512/visufx.html#overflow-clipping
Moreover, this property's (as well as "position"'s) default value is "inherit", so there's no need to repeat it in inner elements.
http://www.w3.org/TR/1998/REC-CSS2-19980512/cascade.html#value-def-inherit
Also, I'm not sure that defining overflow where width=100% makes sense.
== Columns positionning ==
Why not leaving "float:left" doing the job of setting the "left" value ? just set "width"
I'd tend to see float and left as conflicting ways of specifing horizontal position of the box.
Better choose one and stick to it.
As I prefer the more modern fluid layouts, I'd try float.
== The patch ==
Apply patch for #379084 first !
Values are only rough settings, there is some work to get a good rendering, I leave this to you.
But I'm sure it should be far easier with this new structure. |
|
| 2009-05-24 08:39:13 |
Rocky Road |
description |
Follows bug #379084
Now that most (sigh) css rules are in css file, I'll try to help fixing them.
== Unused or misnamed container ids ==
Looking at page.tpl.php, I see that the main content is organised with
the following hierarchy:
#container
$breadcrumb
#container3
#container2
#container1
#col1
#col2
#col3
so selectors with #container0, container-1, container-2, container-3 will be ignored.
I removed them in the patch below.
Also, #container3 and #container2 are just bare wrappers (no extra content) which
just add confusion in the stylesheet. I propose to remove all rules for them,
as well as the elements themselves.
== Misuse of "right" css property ==
See http://www.w3.org/TR/1998/REC-CSS2-19980512/visuren.html#propdef-right
"This property specifies how far a box's right content edge is offset to the left of the right edge of the box's containing block. "
Then in #container1, I read
width: 100%;
right: 75%;
This implies that left is now -75%, and it sadly means that the offsets of all inner elements have to balance this strange offset.
Recall that width percentage is calculated with respect to the width of the generated box's containing block. ( http://www.w3.org/TR/1998/REC-CSS2-19980512/visudet.html#the-width-property )
== overflow settings ==
Most rules in the layout section define "overflow=hidden".
This makes the errors related to above one, very critical !
http://www.w3.org/TR/1998/REC-CSS2-19980512/visufx.html#overflow-clipping
Moreover, this property's (as well as "position"'s) default value is "inherit", so there's no need to repeat it in inner elements.
http://www.w3.org/TR/1998/REC-CSS2-19980512/cascade.html#value-def-inherit
Also, I'm not sure that defining overflow where width=100% makes sense.
== Columns positionning ==
Why not leaving "float:left" doing the job of setting the "left" value ? just set "width"
I'd tend to see float and left as conflicting ways of specifing horizontal position of the box.
Better choose one and stick to it.
As I prefer the more modern fluid layouts, I'd try float.
== The patch ==
Apply patch for #379084 first !
Values are only rough settings, there is some work to get a good rendering, I leave this to you.
But I'm sure it should be far easier with this new structure. |
Follows bug #379084
Now that most (sigh) css rules are in css file, I'll try to help fixing them.
== Unused or misnamed container ids ==
Looking at page.tpl.php, I see that the main content is organised with
the following hierarchy:
#container
$breadcrumb
#container3
#container2
#container1
#col1
#col2
#col3
so selectors with #container0, container-1, container-2, container-3 will be ignored.
I removed them in the patch below.
Also, #container3 and #container2 are just bare wrappers (no extra content) which
just add confusion in the stylesheet. I propose to remove all rules for them,
as well as the elements themselves.
== Misuse of "right" css property ==
See http://www.w3.org/TR/1998/REC-CSS2-19980512/visuren.html#propdef-right
"This property specifies how far a box's right content edge is offset to the left of the right edge of the box's containing block. "
Then in #container1, I read
width: 100%;
right: 75%;
This implies that left is now -75%, and it sadly means that the offsets of all inner elements have to balance this strange offset.
Recall that width percentage is calculated with respect to the width of the generated box's containing block. ( http://www.w3.org/TR/1998/REC-CSS2-19980512/visudet.html#the-width-property )
== overflow settings ==
Most rules in the layout section define "overflow=hidden".
This makes the errors related to above one, very critical !
http://www.w3.org/TR/1998/REC-CSS2-19980512/visufx.html#overflow-clipping
Moreover, this property's (as well as "position"'s) default value is "inherit", so there's no need to repeat it in inner elements.
http://www.w3.org/TR/1998/REC-CSS2-19980512/cascade.html#value-def-inherit
Also, I'm not sure that defining overflow where width=100% makes sense.
== Columns positionning ==
Why not leaving "float:left" doing the job of setting the "left" value ? just set "width"
I'd tend to see float and left as conflicting ways of specifing horizontal position of the box.
Better choose one and stick to it.
As I prefer the more modern fluid layouts, I'd try float.
== The patch ==
Apply patch for bug #379084 first !
Values are only rough settings, there is some work to get a good rendering, I leave this to you.
But I'm sure it should be far easier with this new structure. |
|
| 2009-05-24 09:45:05 |
Rocky Road |
branch linked |
|
lp:~m-baert/ubuntu-drupal-theme/theme-patches |
|
| 2009-05-24 09:45:49 |
Rocky Road |
ubuntu-drupal-theme: status |
Triaged |
Fix Committed |
|
| 2009-06-01 04:36:07 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu-drupal-theme |
|
| 2009-06-01 04:38:08 |
Michael Lustfield |
ubuntu-drupal-theme: status |
Fix Committed |
Fix Released |
|
| 2009-06-01 04:38:08 |
Michael Lustfield |
ubuntu-drupal-theme: assignee |
Rocky Road (m-baert) |
Michael Lustfield (mtecknology) |
|
