udm falls over on the switch from wifi to 3g meaning ota are stuck and the system can't recover till reboot
Bug #1390205 reported by
Dave Morley
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Critical
|
Manuel de la Peña |
Bug Description
STEPS:
1. Install an old image (102 in my case (current image is 148))
2. Click on system settings
3. Wait for the updates available to appear
4. Click on updates tag
5. Click on the system image to start it downloading
6. Walk out of wifi range
7. After a few minute walk back into wifi range
EXPECTED:
I expect the image to continue to downloading once I am in wifi ranger again.
ACTUAL:
Instead the image disappears from view, running system-image-cli -n does nothing, click on updates does nothing.
Temp work around:
Reboot the phone this remove the tmp file and allows you to search and download the update once more.
Related branches
lp:~mandel/ubuntu-download-manager/adapt-network-changes
- Manuel de la Peña (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
- Barry Warsaw (community): Approve
-
Diff: 2377 lines (+565/-611)47 files modifiedCMakeLists.txt (+0/-1)
debian/changelog (+8/-0)
debian/control (+2/-3)
src/common/priv/CMakeLists.txt (+4/-4)
src/common/priv/ubuntu/transfers/queue.cpp (+8/-11)
src/common/priv/ubuntu/transfers/queue.h (+3/-1)
src/common/priv/ubuntu/transfers/system/dbus_proxy.h (+1/-1)
src/common/priv/ubuntu/transfers/system/network_reply.cpp (+4/-1)
src/common/priv/ubuntu/transfers/system/network_session.cpp (+162/-0)
src/common/priv/ubuntu/transfers/system/network_session.h (+80/-0)
src/common/priv/ubuntu/transfers/system/nm_interface.cpp (+26/-0)
src/common/priv/ubuntu/transfers/system/nm_interface.h (+48/-0)
src/common/priv/ubuntu/transfers/system/system_network_info.cpp (+0/-237)
src/common/priv/ubuntu/transfers/system/system_network_info.h (+0/-104)
src/common/priv/ubuntu/transfers/transfer.cpp (+17/-14)
src/common/priv/ubuntu/transfers/transfer.h (+2/-2)
src/downloads/priv/CMakeLists.txt (+0/-1)
src/downloads/priv/ubuntu/downloads/download.h (+0/-1)
src/downloads/priv/ubuntu/downloads/factory.h (+0/-1)
src/downloads/priv/ubuntu/downloads/file_download.cpp (+2/-3)
src/downloads/test-daemon/CMakeLists.txt (+0/-2)
src/uploads/priv/CMakeLists.txt (+0/-1)
src/uploads/priv/ubuntu/uploads/factory.h (+0/-1)
tests/common/CMakeLists.txt (+5/-7)
tests/common/daemon_testcase.cpp (+1/-0)
tests/common/network_session.h (+54/-0)
tests/common/system_network_info.h (+0/-61)
tests/downloads/client/CMakeLists.txt (+1/-2)
tests/downloads/daemon/CMakeLists.txt (+0/-1)
tests/downloads/daemon/test_daemon.cpp (+3/-1)
tests/downloads/daemon/test_download.cpp (+114/-126)
tests/downloads/daemon/test_download.h (+3/-3)
tests/downloads/daemon/test_download_factory.cpp (+2/-1)
tests/downloads/daemon/test_download_factory.h (+0/-1)
tests/downloads/daemon/test_download_manager.cpp (+2/-2)
tests/downloads/daemon/test_download_manager.h (+1/-1)
tests/downloads/daemon/test_downloads_db.cpp (+2/-2)
tests/downloads/daemon/test_group_download.cpp (+1/-1)
tests/downloads/daemon/test_group_download.h (+2/-2)
tests/downloads/daemon/test_transfers_queue.cpp (+3/-3)
tests/downloads/daemon/test_transfers_queue.h (+2/-2)
tests/downloads/qml/CMakeLists.txt (+0/-1)
tests/uploads/daemon/CMakeLists.txt (+0/-1)
tests/uploads/daemon/test_file_upload.h (+0/-1)
tests/uploads/daemon/test_mms_upload.h (+0/-1)
tests/uploads/daemon/test_upload_factory.cpp (+1/-1)
tests/uploads/daemon/test_upload_factory.h (+1/-1)
Changed in ubuntu-download-manager: | |
importance: | Undecided → High |
description: | updated |
Changed in ubuntu-download-manager: | |
assignee: | nobody → Manuel de la Peña (mandel) |
description: | updated |
tags: | added: rtm14 |
Changed in ubuntu-download-manager: | |
importance: | High → Critical |
Changed in ubuntu-download-manager: | |
status: | New → In Progress |
Changed in ubuntu-download-manager: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
system-image (dbus or cli) just sets the flag in udm, and let's udm handle all the details. One thing that would be interesting is to know whether leaving and returning to your wifi, with wifi-only downloads enabled, crashes udm or not. If udm crashes without sending any further signals to s-i, then s-i-dbus will just continue to spin until its own internal timeout triggers (defaulting to 10m). After 10m with no response from udm, the reactor will timeout, cause a s-i-dbus error and that process should exit. s-i-cli should, after 10 minutes of no response from udm, also timeout its reactor, and exit with an exception on the console (and log file).
If this is reproducible, then tailing /var/log/ system- image/client. log, the udm log file (don't remember where the system bus udm log file lives), and ps'ing 'ubuntu- download- manager' to see if it crashes would all be useful things.
Ultimately you're right by filing the bug here. s-i does not currently do any direct querying of the network status.