Fakes can be changed by mocks created by google mocks
Bug #1300243 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-download-manager |
Fix Released
|
Medium
|
Manuel de la Peña | ||
ubuntu-download-manager (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The fakes add a lot of code and does not provide something that cannot be done with google mock.
Related branches
lp:~mandel/ubuntu-download-manager/remove-fakes
- Diego Sarmentero (community): Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 19053 lines (+6902/-7870)141 files modifiedCMakeLists.txt (+7/-7)
cmake/modules/FindGtest.cmake (+53/-0)
download-manager.pro.THIS (+0/-50)
tests/CMakeLists.txt (+112/-27)
tests/apparmor.h (+7/-27)
tests/application.h (+49/-0)
tests/base_testcase.cpp (+1/-13)
tests/base_testcase.h (+0/-12)
tests/cryptographic_hash.h (+55/-0)
tests/daemon_testcase.h (+1/-3)
tests/database.h (+31/-0)
tests/dbus_connection.h (+54/-0)
tests/download.h (+31/-30)
tests/factory.h (+22/-47)
tests/file_manager.h (+22/-24)
tests/filename_mutex.h (+48/-0)
tests/group_download.h (+5/-22)
tests/local_tree_testcase.h (+1/-1)
tests/manager.h (+25/-23)
tests/matchers.h (+128/-0)
tests/network_reply.h (+60/-0)
tests/process.h (+15/-45)
tests/process_factory.h (+5/-6)
tests/queue.h (+12/-18)
tests/request_factory.h (+10/-27)
tests/sm_file_download.h (+25/-58)
tests/system_network_info.h (+20/-33)
tests/test_apn_request_factory.cpp (+2/-6)
tests/test_apn_request_factory.h (+36/-4)
tests/test_base_download.cpp (+53/-41)
tests/test_base_download.h (+8/-5)
tests/test_cancel_download_transition.cpp (+12/-15)
tests/test_cancel_download_transition.h (+6/-5)
tests/test_client_download.cpp (+1/-1)
tests/test_client_manager.cpp (+1/-1)
tests/test_client_manager.h (+0/-1)
tests/test_daemon.cpp (+389/-202)
tests/test_daemon.h (+8/-7)
tests/test_download.cpp (+2463/-1571)
tests/test_download.h (+19/-26)
tests/test_download_factory.cpp (+139/-168)
tests/test_download_factory.h (+9/-15)
tests/test_download_manager.cpp (+233/-236)
tests/test_download_manager.h (+21/-18)
tests/test_download_manager_watch.cpp (+10/-10)
tests/test_download_manager_watch.h (+5/-7)
tests/test_download_watch.h (+0/-1)
tests/test_downloads_db.cpp (+7/-11)
tests/test_downloads_db.h (+1/-4)
tests/test_file_download_sm.cpp (+55/-59)
tests/test_file_download_sm.h (+5/-5)
tests/test_filename_mutex.cpp (+0/-4)
tests/test_filename_mutex.h (+3/-4)
tests/test_final_state.h (+2/-3)
tests/test_group_download.cpp (+1123/-467)
tests/test_group_download.h (+18/-20)
tests/test_metadata.cpp (+3/-4)
tests/test_metadata.h (+3/-6)
tests/test_mms_download.h (+2/-4)
tests/test_network_error_transition.cpp (+8/-12)
tests/test_network_error_transition.h (+5/-4)
tests/test_resume_download_transition.cpp (+12/-13)
tests/test_resume_download_transition.h (+5/-5)
tests/test_ssl_error_transition.cpp (+8/-9)
tests/test_ssl_error_transition.h (+6/-5)
tests/test_start_download_transition.cpp (+11/-13)
tests/test_start_download_transition.h (+5/-4)
tests/test_stop_request_transition.cpp (+11/-13)
tests/test_stop_request_transition.h (+5/-4)
tests/test_transfers_queue.cpp (+782/-315)
tests/test_transfers_queue.h (+15/-20)
tests/testing_interface.cpp (+26/-0)
tests/testing_interface.h (+87/-0)
tests/timer.h (+49/-0)
tests/transfer.h (+37/-20)
tests/uuid_factory.h (+6/-10)
ubuntu-download-manager-client-tests/CMakeLists.txt (+0/-80)
ubuntu-download-manager-client-tests/main.cpp.THIS (+0/-25)
ubuntu-download-manager-client-tests/ubuntu-download-manager-client-tests.pro.THIS (+0/-75)
ubuntu-download-manager-common-tests/CMakeLists.txt (+0/-50)
ubuntu-download-manager-common-tests/main.cpp (+0/-25)
ubuntu-download-manager-common-tests/ubuntu-download-manager-common-tests.pro.THIS (+0/-52)
ubuntu-download-manager-priv/ubuntu/downloads/download.h (+1/-1)
ubuntu-download-manager-priv/ubuntu/downloads/factory.cpp (+36/-59)
ubuntu-download-manager-priv/ubuntu/downloads/factory.h (+3/-6)
ubuntu-download-manager-priv/ubuntu/downloads/file_download.cpp (+16/-12)
ubuntu-download-manager-priv/ubuntu/downloads/file_download.h (+4/-4)
ubuntu-download-manager-priv/ubuntu/downloads/group_download.cpp (+11/-1)
ubuntu-download-manager-priv/ubuntu/downloads/group_download.h (+1/-0)
ubuntu-download-manager-priv/ubuntu/downloads/queue.h (+3/-3)
ubuntu-download-manager-priv/ubuntu/downloads/sm_file_download.h (+1/-1)
ubuntu-download-manager-test-daemon/CMakeLists.txt (+21/-4)
ubuntu-download-manager-test-daemon/main.cpp (+1/-1)
ubuntu-download-manager-test-lib/CMakeLists.txt (+0/-64)
ubuntu-download-manager-test-lib/ubuntu-download-manager-test-lib.pro.THIS (+0/-63)
ubuntu-download-manager-test-lib/ubuntu-download-manager-test-lib_global.h (+0/-12)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/download.cpp (+0/-158)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/factory.cpp (+0/-149)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/group_download.cpp (+0/-81)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/manager.cpp (+0/-80)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/queue.cpp (+0/-60)
ubuntu-download-manager-test-lib/ubuntu/download_manager/tests/server/sm_file_download.cpp (+0/-210)
ubuntu-download-manager-tests/main.cpp.THIS (+0/-25)
ubuntu-download-manager-tests/ubuntu-download-manager-tests.pro.THIS (+0/-95)
udm-common/CMakeLists.txt (+4/-0)
udm-priv-common-tests/CMakeLists.txt (+0/-43)
udm-priv-common-tests/transfer.cpp (+0/-112)
udm-priv-common/CMakeLists.txt (+3/-0)
udm-priv-common/ubuntu/transfers/queue.cpp (+6/-1)
udm-priv-common/ubuntu/transfers/system/apparmor.cpp (+76/-71)
udm-priv-common/ubuntu/transfers/system/apparmor.h (+18/-11)
udm-priv-common/ubuntu/transfers/system/cryptographic_hash.cpp (+92/-0)
udm-priv-common/ubuntu/transfers/system/cryptographic_hash.h (+71/-0)
udm-priv-common/ubuntu/transfers/system/file_manager.h (+9/-9)
udm-priv-common/ubuntu/transfers/transfer.h (+11/-11)
udm-testing/CMakeLists.txt (+0/-63)
udm-testing/ubuntu/transfers/tests/fake.cpp (+0/-247)
udm-testing/ubuntu/transfers/tests/fake.h (+0/-156)
udm-testing/ubuntu/transfers/tests/system/apn_request_factory.cpp (+0/-64)
udm-testing/ubuntu/transfers/tests/system/apn_request_factory.h (+0/-56)
udm-testing/ubuntu/transfers/tests/system/apparmor.cpp (+0/-101)
udm-testing/ubuntu/transfers/tests/system/application.cpp (+0/-68)
udm-testing/ubuntu/transfers/tests/system/application.h (+0/-54)
udm-testing/ubuntu/transfers/tests/system/dbus_connection.cpp (+0/-158)
udm-testing/ubuntu/transfers/tests/system/dbus_connection.h (+0/-92)
udm-testing/ubuntu/transfers/tests/system/file_manager.cpp (+0/-94)
udm-testing/ubuntu/transfers/tests/system/filename_mutex.cpp (+0/-72)
udm-testing/ubuntu/transfers/tests/system/filename_mutex.h (+0/-55)
udm-testing/ubuntu/transfers/tests/system/network_reply.cpp (+0/-179)
udm-testing/ubuntu/transfers/tests/system/network_reply.h (+0/-91)
udm-testing/ubuntu/transfers/tests/system/process.cpp (+0/-120)
udm-testing/ubuntu/transfers/tests/system/process_factory.cpp (+0/-59)
udm-testing/ubuntu/transfers/tests/system/qnetwork_reply.cpp (+0/-90)
udm-testing/ubuntu/transfers/tests/system/qnetwork_reply.h (+0/-56)
udm-testing/ubuntu/transfers/tests/system/request_factory.cpp (+0/-98)
udm-testing/ubuntu/transfers/tests/system/system_network_info.cpp (+0/-94)
udm-testing/ubuntu/transfers/tests/system/timer.cpp (+0/-89)
udm-testing/ubuntu/transfers/tests/system/timer.h (+0/-57)
udm-testing/ubuntu/transfers/tests/system/uuid_factory.cpp (+0/-53)
udm-testing/ubuntu/transfers/tests/test_runner.h (+0/-87)
udm-testing/udm-testing_global.h (+0/-12)
Changed in ubuntu-download-manager: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
This bug was fixed in the package ubuntu- download- manager - 0.3+14. 10.20140430- 0ubuntu1
--------------- download- manager (0.3+14. 10.20140430- 0ubuntu1) utopic; urgency=low
ubuntu-
[ Manuel de la Peña ]
* Add upload definitions and autogenerated adaptors.
* Reorg the code so that it is simpler to share code between the
uploader and the downloader. Cmake has been added as the new build
system.
* Generalize the daemon so that it can be used for the uploader too.
* Split the different tests now that we are going to support uploads.
* Split the daemon test code.
* Refactor q code so that it can be used by uploads and downloads.
* Remove the use of fakes in favour of google mock. libgoogle-glog-dev
was added as a dependency. (LP: #1300243)
* Refactor downloads so that they inherit from transfer and can be
used in the new q implementation.
* Provide the factories needed by the uploads.
* Provide the class that will be performing uploads.
* Provide the class that will perform mms uploads.
* Provide factory implementation.
* Add uploads manager implementation. (LP: #1300178)
* Organize project simpler so that new developers find it easier to
move arround the code. (LP: #1300184)
* Allow the clients to change the destination directory of the
download. (LP: #1271507)
* Provide the methods that allow to get all the downloads and all the
downloads with a given metadata value. (LP: #1233149)
[ CI bot ]
* Provide factory implementation.
* Add uploads manager implementation. (LP: #1300178)
-- Ubuntu daily release <email address hidden> Wed, 30 Apr 2014 00:10:00 +0000