Error handling missing in our libreofficekit plugin

Bug #1514458 reported by Stefano Verzegnassi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Document Viewer App
Fix Released
Critical
Stefano Verzegnassi

Bug Description

Having a look at the blueprint for the LibreOffice integration, I've seen that the "error handling" task has been marked as postponed.

Since we have a testing version of docviewer out, and then assuming we're almost there for a stable release, we need to handle some exception more carefully, in order to avoid unwanted crashes of the app.

A first list of exceptions to handle:
1) LibreOffice binaries not found.
       -> Config::getLibreOfficePath() returning NULL when called from LODocument::loadDocument(...)
2) LibreOffice not initialized.
       -> LODocument::s_office is NULL after lok::lok_cpp_init(...) during the execution of LODocument::loadDocument(...)
3) Document not loaded.
       -> LODocument::m_document is NULL after s_office->documentLoad(...) during the execution of LODocument::loadDocument(...)

We should show an Ubuntu.Dialog, in order to tell the user what went wrong, and return to the documents list page when the user closes the dialog.

Tags: loviewer

Related branches

Changed in ubuntu-docviewer-app:
assignee: nobody → Stefano Verzegnassi (verzegnassi-stefano)
Changed in ubuntu-docviewer-app:
status: Triaged → In Progress
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-docviewer-app/reboot at revision 197, scheduled for release in ubuntu-docviewer-app, milestone Unknown

Changed in ubuntu-docviewer-app:
status: In Progress → Fix Committed
Changed in ubuntu-docviewer-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.