Error handling missing in our libreofficekit plugin
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Document Viewer App |
Fix Released
|
Critical
|
Stefano Verzegnassi |
Bug Description
Having a look at the blueprint for the LibreOffice integration, I've seen that the "error handling" task has been marked as postponed.
Since we have a testing version of docviewer out, and then assuming we're almost there for a stable release, we need to handle some exception more carefully, in order to avoid unwanted crashes of the app.
A first list of exceptions to handle:
1) LibreOffice binaries not found.
-> Config:
2) LibreOffice not initialized.
-> LODocument:
3) Document not loaded.
-> LODocument:
We should show an Ubuntu.Dialog, in order to tell the user what went wrong, and return to the documents list page when the user closes the dialog.
Related branches
- Jenkins Bot: Approve (continuous-integration)
- Roman Shchekin: Approve
-
Diff: 569 lines (+207/-58)13 files modified.bzrignore (+1/-0)
CMakeLists.txt (+3/-0)
src/app/qml/common/ErrorDialog.qml (+0/-2)
src/app/qml/loView/LOViewPage.qml (+25/-0)
src/app/qml/ubuntu-docviewer-app.qml (+6/-2)
src/plugin/libreofficetoolkit-qml-plugin/CMakeLists.txt (+1/-0)
src/plugin/libreofficetoolkit-qml-plugin/lodocument.cpp (+52/-12)
src/plugin/libreofficetoolkit-qml-plugin/lodocument.h (+16/-7)
src/plugin/libreofficetoolkit-qml-plugin/loerror.h (+37/-0)
src/plugin/libreofficetoolkit-qml-plugin/loview.cpp (+44/-24)
src/plugin/libreofficetoolkit-qml-plugin/loview.h (+15/-7)
src/plugin/libreofficetoolkit-qml-plugin/plugin.cpp (+5/-3)
src/plugin/libreofficetoolkit-qml-plugin/qml/Viewer.qml (+2/-1)
Changed in ubuntu-docviewer-app: | |
assignee: | nobody → Stefano Verzegnassi (verzegnassi-stefano) |
Changed in ubuntu-docviewer-app: | |
status: | Triaged → In Progress |
Changed in ubuntu-docviewer-app: | |
status: | Fix Committed → Fix Released |
Fix committed into lp:ubuntu-docviewer-app/reboot at revision 197, scheduled for release in ubuntu- docviewer- app, milestone Unknown