DocviewerFile class sends pathChanged signal twice
Bug #1445011 reported by
Stefano Verzegnassi
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Document Viewer App |
Fix Released
|
Low
|
Stefano Verzegnassi | ||
Bug Description
DocviewerFile class needs a refactoring in order to improve its signals/slots usage.
In particular, it sends pathChanged signal multiple times for a single file, making the PDF plugin load pages twice.
We used to workaround this by disabling the binding for the event, but it actually needs to be solved.
Related branches
lp:~verzegnassi-stefano/ubuntu-docviewer-app/plugins-renaming
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Alan Pope 🍺🐧🐱 🦄 (community): Approve
-
Diff: 5183 lines (+1090/-1540)62 files modifiedpo/am.po (+13/-28)
po/ast.po (+13/-28)
po/br.po (+27/-42)
po/ca.po (+13/-28)
po/com.ubuntu.docviewer.pot (+11/-11)
po/cs.po (+13/-28)
po/da.po (+13/-28)
po/de.po (+44/-65)
po/el.po (+13/-28)
po/en_AU.po (+13/-28)
po/en_GB.po (+24/-39)
po/eo.po (+13/-28)
po/es.po (+13/-28)
po/eu.po (+13/-28)
po/fi.po (+13/-28)
po/fr.po (+26/-41)
po/gd.po (+13/-28)
po/gl.po (+14/-29)
po/hu.po (+25/-40)
po/it.po (+13/-28)
po/lo.po (+13/-28)
po/lv.po (+13/-28)
po/nb.po (+13/-28)
po/nl.po (+13/-28)
po/ny.po (+13/-28)
po/pa.po (+25/-40)
po/pl.po (+41/-58)
po/pt.po (+13/-28)
po/pt_BR.po (+13/-28)
po/ru.po (+13/-28)
po/sl.po (+13/-28)
po/tr.po (+13/-28)
po/uk.po (+13/-28)
po/zh_CN.po (+13/-28)
po/zh_TW.po (+13/-28)
src/app/CMakeLists.txt (+0/-1)
src/app/command-line-parser.cpp (+25/-1)
src/app/command-line-parser.h (+2/-0)
src/app/docviewer-application.cpp (+10/-3)
src/app/docviewer-application.h (+2/-0)
src/app/qml/common/DetailsPage.qml (+4/-4)
src/app/qml/documentPage/DeleteFileDialog.qml (+2/-2)
src/app/qml/documentPage/DocumentGridView.qml (+1/-1)
src/app/qml/documentPage/DocumentListView.qml (+6/-5)
src/app/qml/pdfView/PdfView.qml (+2/-2)
src/app/qml/textView/TextViewDefaultHeader.qml (+1/-1)
src/app/qml/ubuntu-docviewer-app.qml (+22/-3)
src/plugin/file-qml-plugin/CMakeLists.txt (+4/-3)
src/plugin/file-qml-plugin/backend.cpp (+6/-7)
src/plugin/file-qml-plugin/backend.h (+2/-2)
src/plugin/file-qml-plugin/documentmodel.cpp (+127/-114)
src/plugin/file-qml-plugin/documentmodel.h (+32/-28)
src/plugin/file-qml-plugin/docviewerfile.cpp (+70/-71)
src/plugin/file-qml-plugin/docviewerfile.h (+22/-39)
src/plugin/file-qml-plugin/fileReader.cpp (+0/-99)
src/plugin/file-qml-plugin/fileReader.h (+0/-56)
src/plugin/file-qml-plugin/fswatcher.cpp (+118/-0)
src/plugin/file-qml-plugin/fswatcher.h (+52/-0)
src/plugin/file-qml-plugin/qmldir (+1/-1)
src/plugin/poppler-qml-plugin/CMakeLists.txt (+1/-1)
src/plugin/poppler-qml-plugin/plugin.cpp (+2/-2)
src/plugin/poppler-qml-plugin/qmldir (+1/-1)
| summary: |
- DocviewerFile class send pathChanged signal twice + DocviewerFile class sends pathChanged signal twice |
| Changed in ubuntu-docviewer-app: | |
| milestone: | 2015-04-16 → 2015-04-30 |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-docviewer-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-docviewer-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-docviewer-app at revision 143, scheduled for release in ubuntu-