Opening a document via content hub doesn't actually open it
Bug #1437626 reported by
Cris Dywan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Document Viewer App |
Fix Released
|
Medium
|
Stefano Verzegnassi |
Bug Description
When I open documents from another app in the document viewer they are imported but never actually open unless I manually pick it from the list of documents.
Related branches
lp:~verzegnassi-stefano/ubuntu-docviewer-app/adv-import-handler
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Alan Pope 🍺🐧🐱 🦄 (community): Approve
-
Diff: 3642 lines (+847/-811)43 files modifiedpo/am.po (+9/-23)
po/ast.po (+9/-23)
po/br.po (+9/-23)
po/ca.po (+9/-23)
po/com.ubuntu.docviewer.pot (+42/-6)
po/cs.po (+9/-23)
po/da.po (+9/-23)
po/de.po (+9/-23)
po/el.po (+9/-23)
po/en_AU.po (+9/-23)
po/en_GB.po (+9/-23)
po/eo.po (+9/-23)
po/es.po (+9/-23)
po/eu.po (+9/-23)
po/fi.po (+9/-23)
po/fr.po (+46/-13)
po/gd.po (+10/-24)
po/gl.po (+10/-24)
po/hu.po (+10/-24)
po/it.po (+9/-23)
po/lo.po (+9/-23)
po/lv.po (+9/-23)
po/nb.po (+9/-23)
po/nl.po (+9/-23)
po/ny.po (+9/-23)
po/pa.po (+10/-24)
po/pl.po (+9/-23)
po/pt.po (+9/-23)
po/pt_BR.po (+9/-23)
po/ru.po (+9/-23)
po/sl.po (+9/-23)
po/tr.po (+9/-23)
po/uk.po (+9/-23)
po/zh_CN.po (+9/-23)
po/zh_TW.po (+9/-23)
src/app/content-communicator.cpp (+63/-25)
src/app/content-communicator.h (+3/-1)
src/app/qml/common/FileNotFoundDialog.qml (+1/-1)
src/app/qml/common/PickImportedDialog.qml (+50/-0)
src/app/qml/common/RejectedImportDialog.qml (+45/-0)
src/app/qml/common/Toast.qml (+82/-0)
src/app/qml/common/ToastWithAction.qml (+117/-0)
src/app/qml/ubuntu-docviewer-app.qml (+97/-2)
Changed in ubuntu-docviewer-app: | |
milestone: | none → 2015-04-09 |
Changed in ubuntu-docviewer-app: | |
status: | Triaged → In Progress |
assignee: | nobody → Stefano Verzegnassi (verzegnassi-stefano) |
Changed in ubuntu-docviewer-app: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
This is actually the behaviour used also in gallery-app. I decided to handle imported document in this way in order to provide a consistent behaviour with the rest of the platform.
To be fair, there's an issue here: gallery-app has some animations that highlight the entry of the imported image as side-effect. It's still not possible to archive this in docviewer beacuse the FileWatcher we use is still in an early stage.
Also, there are two user scenarios while handling with content-hub import:
1) A third party application that wants to store a document in the user's folder. In this case, opening automatically a document is an unwanted behaviour, IMHO.
2) An user that chooses the docviewer as a peer for opening a document that he wants to see (e.g. when downloding via webbrowser-app). In this case, the document should be automatically opened.
I think we could go for a third way. modified/ deleted.
By default, no document is automatically opened. A toast notification is shown instead on the bottom edge of the screen, informing the user that the document has been successfully imported.
This notification will also provide a button, that the user can tap to open the document.
For design references, I suggest to see how Quick Memo (it's an application that I wrote some time ago) works. It provides toast notifications when a note is created/
I feel like this solution is the less invasive for both the scenarios, and it's informative enough to be useful for users.