Id and objectName properties of QML Item/Objects should be in sync
Bug #1416068 reported by
Stefano Verzegnassi
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Document Viewer App |
Fix Released
|
Low
|
Stefano Verzegnassi | ||
Bug Description
In "ubuntu-
MainView {
id: mainView
objectName: "docviewer"
...
}
DESIRED SOLUTION:
According to [1], the id and objectName properties should be the same value. Use "mainView" or "root" instead.
Also, we need to check if this happens in all the QML files.
[1]: https:/
Related branches
lp:~verzegnassi-stefano/ubuntu-docviewer-app/coding-style
- Filippo Scognamiglio (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Ubuntu Document Viewer Developers: Pending requested
-
Diff: 306 lines (+41/-68)9 files modifiedpo/com.ubuntu.docviewer.pot (+5/-5)
src/app/qml/ErrorDialog.qml (+3/-3)
src/app/qml/PdfView.qml (+0/-4)
src/app/qml/PdfViewDefaultHeader.qml (+1/-1)
src/app/qml/PdfViewGotoDialog.qml (+5/-7)
src/app/qml/UnknownTypeDialog.qml (+5/-8)
src/app/qml/loadComponent.js (+14/-21)
src/app/qml/ubuntu-docviewer-app.qml (+4/-7)
src/app/qml/utils.js (+4/-12)
| summary: |
- Id and objectName properties of QML Item/Objects should be consistent + Id and objectName properties of QML Item/Objects should be in sync |
| Changed in ubuntu-docviewer-app: | |
| assignee: | nobody → Stefano Verzegnassi (verzegnassi-stefano) |
| status: | Triaged → In Progress |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-docviewer-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-docviewer-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-docviewer-app at revision 62, scheduled for release in ubuntu-