Restructure project file and folders
Bug #1395111 reported by
Stefano Verzegnassi
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Document Viewer App |
Fix Released
|
Undecided
|
Stefano Verzegnassi | ||
Bug Description
Since the application will become more complex in the future, it may be useful to provide a stronger separation between QML files.
A proposal for this is:
./src/app/qml
|- [folder] common (QML files used by multiple "ui" files, or by WelcomePage.qml)
|- [folder] imageview (QML files used by ImageView.qml)
|- [folder] pdfview (QML files used by PdfView.qml)
|- [folder] textview (QML files used by TextView.qml)
|- [folder] ui (UI pages)
L ubuntu-
Moreover, as rotation and/or text search will land in our poppler-qml-plugin, it's possible that PdfView.qml will become very large: we will probably need to split some files into smaller logical units and, by this folder restructure, it would be easier to browse those project files.
Related branches
lp:~verzegnassi-stefano/ubuntu-docviewer-app/document-hub2
- Alan Pope 🍺🐧🐱 🦄 (community): Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Riccardo Padovani (community): Approve (code)
-
Diff: 7414 lines (+4916/-1923)75 files modifiedCMakeLists.txt (+2/-2)
com.ubuntu.docviewer.desktop.in.in (+3/-1)
com.ubuntu.docviewer.url-dispatcher (+5/-0)
debian/changelog (+12/-2)
debian/control (+1/-1)
docviewer-content.json (+4/-3)
docviewer.apparmor (+7/-0)
manifest.json.in (+3/-2)
po/com.ubuntu.docviewer.pot (+155/-85)
src/app/CMakeLists.txt (+22/-1)
src/app/command-line-parser.cpp (+105/-0)
src/app/command-line-parser.h (+56/-0)
src/app/content-communicator.cpp (+188/-0)
src/app/content-communicator.h (+69/-0)
src/app/docviewer-application.cpp (+298/-0)
src/app/docviewer-application.h (+92/-0)
src/app/graphics/select-none.svg (+153/-0)
src/app/graphics/select.svg (+158/-0)
src/app/main.cpp (+10/-98)
src/app/qml/ContentHubPicker.qml (+0/-71)
src/app/qml/ContentHubProxy.qml (+0/-38)
src/app/qml/DetailsPage.qml (+0/-58)
src/app/qml/EmptyState.qml (+0/-59)
src/app/qml/ErrorDialog.qml (+0/-32)
src/app/qml/ImageView.qml (+0/-48)
src/app/qml/ImageViewDefaultHeader.qml (+0/-74)
src/app/qml/PageWithBottomEdge.qml (+0/-407)
src/app/qml/PdfContentsPage.qml (+0/-60)
src/app/qml/PdfView.qml (+0/-107)
src/app/qml/PdfViewDefaultHeader.qml (+0/-96)
src/app/qml/PdfViewDelegate.qml (+0/-95)
src/app/qml/PdfViewGotoDialog.qml (+0/-60)
src/app/qml/TextView.qml (+0/-70)
src/app/qml/TextViewDefaultHeader.qml (+0/-82)
src/app/qml/UnknownTypeDialog.qml (+0/-43)
src/app/qml/WelcomePage.qml (+0/-42)
src/app/qml/ZoomableImage.qml (+0/-155)
src/app/qml/common/DetailsPage.qml (+58/-0)
src/app/qml/common/ErrorDialog.qml (+32/-0)
src/app/qml/common/UnknownTypeDialog.qml (+43/-0)
src/app/qml/common/loadComponent.js (+38/-0)
src/app/qml/common/utils.js (+34/-0)
src/app/qml/documentPage/DeleteFileDialog.qml (+58/-0)
src/app/qml/documentPage/DocumentEmptyState.qml (+34/-0)
src/app/qml/documentPage/DocumentGridDelegate.qml (+178/-0)
src/app/qml/documentPage/DocumentGridView.qml (+76/-0)
src/app/qml/documentPage/DocumentListDelegate.qml (+108/-0)
src/app/qml/documentPage/DocumentListView.qml (+156/-0)
src/app/qml/documentPage/DocumentPage.qml (+76/-0)
src/app/qml/documentPage/DocumentPageDefaultHeader.qml (+34/-0)
src/app/qml/documentPage/DocumentPagePickModeHeader.qml (+63/-0)
src/app/qml/documentPage/DocumentPageSelectionModeHeader.qml (+94/-0)
src/app/qml/loadComponent.js (+0/-45)
src/app/qml/pdfView/PdfContentsPage.qml (+60/-0)
src/app/qml/pdfView/PdfView.qml (+109/-0)
src/app/qml/pdfView/PdfViewDefaultHeader.qml (+96/-0)
src/app/qml/pdfView/PdfViewDelegate.qml (+95/-0)
src/app/qml/pdfView/PdfViewGotoDialog.qml (+60/-0)
src/app/qml/textView/TextView.qml (+70/-0)
src/app/qml/textView/TextViewDefaultHeader.qml (+82/-0)
src/app/qml/ubuntu-docviewer-app.qml (+63/-37)
src/app/qml/upstreamComponents/EmptyState.qml (+62/-0)
src/app/qml/upstreamComponents/HeaderButton.qml (+65/-0)
src/app/qml/upstreamComponents/ListItemWithActions.qml (+453/-0)
src/app/qml/upstreamComponents/ListItemWithActionsCheckBox.qml (+25/-0)
src/app/qml/upstreamComponents/MultipleSelectionGridView.qml (+199/-0)
src/app/qml/upstreamComponents/MultipleSelectionListView.qml (+199/-0)
src/app/qml/upstreamComponents/MultipleSelectionVisualModel.qml (+31/-0)
src/app/qml/upstreamComponents/PageWithBottomEdge.qml (+407/-0)
src/app/qml/utils.js (+0/-34)
src/app/quick/documentmodel.cpp (+212/-0)
src/app/quick/documentmodel.h (+89/-0)
src/app/urlhandler.cpp (+70/-0)
src/app/urlhandler.h (+43/-0)
tests/autopilot/ubuntu_docviewer_app/tests/test_docviewer.py (+1/-15)
| Changed in ubuntu-docviewer-app: | |
| status: | New → In Progress |
| assignee: | nobody → Stefano Verzegnassi (verzegnassi-stefano) |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-docviewer-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-docviewer-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-docviewer-app at revision 86, scheduled for release in ubuntu-