Update-Maintainer silently fails when Maintainer-Field contains a comment in brackets

[Andreas Moog]

Binary package hint: ubuntu-dev-tools

When the maintainer-field contains brackets, update-maintainer silently fails to set the maintainerfield.

I discovered this when working on the package "hercules":

Source: hercules
Section: otherosfs
Priority: extra
Maintainer: Peter De Schrijver (p2) <email address hidden>

The comment "(p2)" results in update-maintainer to fail when writing the new file, because this:

debian_control_file.write(re.sub(original_maintainer, final_addition, file_contents))

treats the "()" as part of the regular expression. By rewriting the line to:

debian_control_file.write(re.sub(re.escape(original_maintainer), final_addition, file_contents))

this does not happen anymore.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ubuntu-dev-tools - 0.76

---------------
ubuntu-dev-tools (0.76) karmic; urgency=low

  [ Nicolas Valcárcel ]
  * mk-sbuild-lv:
    - Add check for built-in dm_snapshot (LP: #398414)

  [ Andreas Moog ]
  * update-maintainer:
    - Don't silently fail when Maintainer-Field contains a comment
      in brackets. (LP: #397144)
    - Don't add second XSBC-Original-Maintainer if Maintainer was set
      to Motu or Core-Dev.

  [ Michael Bienia ]
  * Drop python-launchpad-bugs from Depends.
  * Add python-lazr-restfulclient to Depends.
  * buildd: Add a --batch mode for batch retrying/rescoring of packages.
  * requestsync:
    - Use UBU* environment variables before the DEB* ones (lp: #400133)
    - Split requestsync into a "mail" module and a "lpapi" module and use
      the LP API only when --lp was used. In "mail" mode requestsync has
      to ask some more questions for parts it can't find out without LP API.
      (lp: #406659, #416955)

  [ Iain Lane ]
  * requestsync:
    - Guard some calls when -n is specified
    - Fetch changelog of specified version, not current version. If an
      experimenal upload happened after the unstable one we're syncing, this
      is considered to be current by p.d.o and we would get those changelog
      entries in the sync request
    - Remove trailing fullstop from sync bug title
  * suspicious-source: Add *.hs *.el *.css to whitelist

  [ Siegfried-Angel Gevatter Pujals ]
  * pbuilder-dist:
     - Expand "~" in PBUILDFOLDER to the user's home directory.
     - If there's a "etc/<distro>/apt.conf" file inside the build result
       directory, pass it to pbuilder as --aptconfdir. Thanks to Paul Novotny
       and Ryan Pavlik (LP: #363043).

  [ Luca Falavigna ]
  * Switch to python-support to ease initial import into Debian:
    - debian/control: build-depend on python-support instead of pycentral,
      also remove unneeded XB-Python-Version field from binary stanza.
    - debian/rules: set DEB_PYTHON_SYSTEM to pysupport.
    - ubuntu-dev-tools.preinst: remove stale pycentral files on upgrades.

  [ Nathan Handler ]
  * Add pull-revu-source and doc/pull-revu-source.1
  * Update debian/copyright to include pull-revu-source

 -- Nathan Handler <email address hidden> Sun, 30 Aug 2009 17:24:23 +0000