limited upload rights no longer give series nomination accept/decline rights

[Andy Whitcroft]

I have limited upload rights to the kernel packages. When I first had this I could accept/decline series nominations for those packages. Somewhen recently this ability has stopped working, the accept/decline markers have gone away again. This affects both apw and stefan-bader-canonical; we both have kernel upload rights.

It is possible that this stopped working in step with our upload rights movingg from being directly attached to me in acls list, to being attached indirectly via a 'group' (this is likely not the official term).

The original bug to get this added was bug #373172, it is possible this is related to bug #376006.

[Andy Whitcroft (apw)]

Note that the above was tested on edge. Just checked on www.launchpad.net and the issue appears the same there.

[Deryck Hodge (deryck)]

Un-assigning to milestone because we're no longer targeting bugs to milestones until they are ready to land. This is no indication in a change of priority for fixing this.

[Andy Whitcroft (apw)]

/me wonders if there is any timescale for this fix. this is a pretty significant part of the utility of package sets and those are the direction that all upload rights are moving. You may find this becomes suddenly very urgent on you.

[Jonathan Lange (jml)]

Note that there are now public methods for checking to see whether a person has upload permissions (see IArchive.checkUpload and others), and that IBugNomination.canApprove implements its own version. This duplication is perhaps the source of this bug.

[Colin Watson (cjwatson)]

We've raised this as part of the (long and complicated) discussion around bug 174375.

[Francis J. Lacoste (flacoste)]

Escalated on the stakedholders list.

[Kees Cook (kees)]

This bug got hit again today. I've added brad-figg to ubuntu-drivers for now (to gain bugtask series nomination approval super-powers).

[Launchpad QA Bot (lpqabot)]

Fixed in stable r13011 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13011>.

[William Grant (wgrant)]

+nominations still doesn't render on qastaging. But while each nomination is now roughly 7 queries instead of 5, the new queries are 3-4ms and still dominated by latest_published_component.

[Martin Pitt (pitti)]

Micah confirmed that this works now, thanks for the fix!