Require a comment for a Failure
Bug #1492320 reported by
Nicholas Skaggs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox Converged |
Fix Released
|
Medium
|
Maciej Kisielewski | ||
| PlainBox (Toolkit) |
Fix Released
|
Medium
|
Maciej Kisielewski | ||
| Ubuntu Community Testing |
Fix Released
|
High
|
Unassigned | ||
Bug Description
Is it possible to require a comment if a 'NO' is given? Since the test could have failed for many reasons, it would be useful to at least prompt for some text from the user about the test.
We should also give them direction, saying 'tell us what happened'.
Related branches
lp:~kissiel/checkbox/fix-1492320-comment-on-manual-fail
- Zygmunt Krynicki (community): Approve
- Paul Larson: Approve
-
Diff: 175 lines (+65/-12)6 files modifiedcheckbox-touch/checkbox-touch.qml (+14/-1)
plainbox/docs/changelog.rst (+5/-0)
plainbox/docs/manpages/plainbox-job-units.rst (+6/-0)
plainbox/plainbox/impl/commands/inv_run.py (+8/-0)
plainbox/plainbox/impl/unit/job.py (+21/-11)
plainbox/plainbox/impl/unit/test_job.py (+11/-0)
Revision history for this message
| Zygmunt Krynicki (zyga) wrote | #1 |
| Changed in checkbox-converged: | |
| status: | New → Incomplete |
| status: | Incomplete → Triaged |
| Changed in plainbox: | |
| status: | New → Triaged |
Revision history for this message
| Nicholas Skaggs (nskaggs) wrote | #2 |
| Changed in ubuntu-community-testing: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
Revision history for this message
| Nicholas Skaggs (nskaggs) wrote | #3 |
| Changed in ubuntu-community-testing: | |
| importance: | Low → High |
| summary: |
- Require comment for a 'NO' answer + Require a comment for a Failure |
| Changed in checkbox-converged: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Maciej Kisielewski (kissiel) |
| Changed in plainbox: | |
| assignee: | nobody → Maciej Kisielewski (kissiel) |
| importance: | Undecided → Medium |
| Changed in checkbox-converged: | |
| importance: | Undecided → Medium |
| milestone: | none → 1.2.3 |
| Changed in plainbox: | |
| milestone: | none → 0.25 |
| status: | Triaged → In Progress |
| Changed in checkbox-converged: | |
| milestone: | 1.2.3 → 1.2.4 |
| Changed in checkbox-converged: | |
| status: | In Progress → Fix Committed |
| Changed in plainbox: | |
| status: | In Progress → Fix Committed |
| Changed in plainbox: | |
| status: | Fix Committed → Fix Released |
| Changed in checkbox-converged: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-community-testing: | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
Let's add a flag to the job that controls this (plainbox).
For checkbox: UX design, ack, change and land