Edited alarm cannot be saved if any point clock app loses focus

Bug #1487789 reported by Nekhelesh Ramananthan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Clock App
Fix Released
Critical
Nekhelesh Ramananthan

Bug Description

Steps to reproduce bug:
1. Edit an alarm
2. Switch apps or open the indicator or anything to make clock app lose active focus.
3. Press the save header button to save the alarm

What happens:
Pressing the save button does nothing

What is expected:
Edited alarm is saved correctly

Log Error: L103 EditAlarmPage: TypeError: Cannot assign to null [1]

What happens is that the "tempAlarm" variable becomes undefined after content-hub is used to import a new custom sound. As a result, the line tempAlarm.message = _alarm.message naturally fails [2]

[1] http://bazaar.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/utopic-3.0/view/head:/app/alarm/EditAlarmPage.qml#L103

[2] http://bazaar.launchpad.net/~ubuntu-clock-dev/ubuntu-clock-app/utopic-3.0/view/head:/app/alarm/AlarmList.qml#L74

Related branches

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote : Re: Edited alarm cannot be saved after importing a custom-sound

Currently investigating with Kenvandine as to why the tempAlarm variable becomes undefined after using content-hub. Will update bug report with findings.

summary: - Edited alarm cannot be saved after adding a custom-sound
+ Edited alarm cannot be saved after importing a custom-sound
Changed in ubuntu-clock-app:
assignee: nobody → Nekhelesh Ramananthan (nik90)
description: updated
Changed in ubuntu-clock-app:
status: Triaged → In Progress
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

It turns out that this issue is more widespread than originally anticipated. If the user while editing an alarm switches applications (clock app loses focus), the alarmModel is reloaded and the tempAlarm becomes invalid as a result. Raising bug priority to critical since this is more than a content-hub issue.

Content-hub just made the problem appear consistently enough to be detected!

Changed in ubuntu-clock-app:
importance: High → Critical
summary: - Edited alarm cannot be saved after importing a custom-sound
+ Edited alarm cannot be saved if any point clock app loses focus
description: updated
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-clock-app at revision 354, scheduled for release in ubuntu-clock-app, milestone 3.5

Changed in ubuntu-clock-app:
status: In Progress → Fix Committed
Changed in ubuntu-clock-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.