Clock App crashes when clicking on the settings icon

[Victor Thompson]

The app crashes when the settings icon is tapped. This occurs in vivid image #130 on mako.

Steps to reproduce the bug:

1. Open the clock app
2. Tap the settings icon in the upper right hand corner

Expected results: The app does not crash

Actual results: The clock app crashes

The following can be found in the logs sometimes, as a result:

file:///usr/share/click/preinstalled/com.ubuntu.clock/3.3.192/share/qml/alarm/AlarmDelegate.qml:78: TypeError: Cannot read property 'enabled' of null
file:///usr/share/click/preinstalled/com.ubuntu.clock/3.3.192/share/qml/alarm/AlarmUtils.qml:142: TypeError: Cannot read property 'enabled' of null
file:///usr/share/click/preinstalled/com.ubuntu.clock/3.3.192/share/qml/alarm/AlarmDelegate.qml:78: TypeError: Cannot read property 'enabled' of null
file:///usr/share/click/preinstalled/com.ubuntu.clock/3.3.192/share/qml/alarm/AlarmUtils.qml:142: TypeError: Cannot read property 'enabled' of null

[Nekhelesh Ramananthan (nik90)]

Hi Victor, Thanks for the crasher update. Would you mind testing v3.3.2.17 from trunk to see if it fixes the crash pls? There was a similar crasher bug [1] that I fixed in rev 216 [2] that hasn't made it to the store. That bug also started since the recent upload of UITK to the store last friday.

[1] https://bugs.launchpad.net/ubuntu-clock-app/+bug/1429273
[2] https://code.launchpad.net/~nik90/ubuntu-clock-app/fix-alarm-crash/+merge/252150

[Nekhelesh Ramananthan (nik90)]

Michael Sheldon also confirmed on IRC that this bug occurs occasionally when opening/closing the settings page. I am sincerely hoping that this bug gets fixes by rev 216, as I haven't made any other change to the clock app recently w.r.t alarms.

[Victor Thompson (vthompson)]

Hi Nik, sadly it doesn't seem like the MP you pointed out fixes this. However, on my flo device (that had no alarms) didn't seem to be affected by this bug, however, once I added and deleted some alarms it seems like it is affected. I wonder if there's somewhere else that needs a change similar to the one you pointed out?

[Nekhelesh Ramananthan (nik90)]

hmm that's really bad :/ .. I will test this out and try to see where the issue is...the strange part is that AlarmDelegate.qml is used only within AlarmsPage.qml which is not called when opening the Settings page. So I am not sure how the output log displays that. I will investigate more in the morning.

[Zsombor Egri (zsombi)]

This seems to be related to the AlarmModel.get() function, so I add toolkit to it.