Default Alarm frequency should be 'null' (one off)
Bug #1358320 reported by
Giorgio Venturi
This bug affects 4 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Clock App |
Fix Released
|
High
|
Nekhelesh Ramananthan | ||
Ubuntu UX |
Fix Released
|
High
|
Unassigned |
Bug Description
Default Alarm frequency should be null (one-off). Setting up a frequency should be optional. By default, if the alarm goes off, it must be turned on manually, unless a frequency is set
Related branches
lp:~nik90/ubuntu-clock-app/onetime-alarms
- PS Jenkins bot: Approve (continuous-integration)
- Ubuntu Phone Apps Jenkins Bot: Needs Fixing (continuous-integration)
- Riccardo Padovani: Approve
- Alan Pope 🍺🐧🐱 🦄 (community): Approve
-
Diff: 390 lines (+156/-55)6 files modifiedapp/alarm/AlarmDelegate.qml (+2/-1)
app/alarm/AlarmRepeat.qml (+27/-5)
app/alarm/AlarmUtils.qml (+18/-1)
app/alarm/EditAlarmPage.qml (+35/-6)
debian/changelog (+1/-0)
tests/unit/tst_alarmRepeat.qml (+73/-42)
Changed in ubuntu-ux: | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Giorgio Venturi (giorgio-venturi) |
Changed in ubuntu-clock-app: | |
status: | New → Triaged |
milestone: | none → rtm |
importance: | Undecided → High |
Changed in ubuntu-clock-app: | |
assignee: | nobody → Nekhelesh Ramananthan (nik90) |
status: | Triaged → In Progress |
Changed in ubuntu-clock-app: | |
status: | In Progress → Triaged |
status: | Triaged → Confirmed |
Changed in ubuntu-clock-app: | |
status: | Confirmed → In Progress |
description: | updated |
summary: |
- Default Alarm frequency should be 'never' + Default Alarm frequency should be 'null' (one off) |
description: | updated |
Changed in ubuntu-clock-app: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
There are a couple of design questions I had during the implementation,
- If the frequency is set to "Never", in the alarm list page do we also display "Never" below the alarm label? Or should we display today's day since it will ring today as a one time alarm?
- How does a user differentiate between a single alarm and a repeating alarm?
- What should happen if a user sets this alarm before the current local time? So for instance if the current local time is 16:00 and the user is trying to set an alarm for 13:00, the SDK will reject them. Should we display a message saying that the time is invalid and to try again?
Note: This wasn't an issue with repeating alarms since if you set an alarm for an earlier time, it rings next week.