Activity log for bug #1815592

Date Who What changed Old value New value Message
2019-02-12 11:34:20 Łukasz Zemczak bug added bug
2019-02-12 11:38:57 Łukasz Zemczak ubuntu-cdimage: assignee Łukasz Zemczak (sil2100)
2019-02-12 11:38:59 Łukasz Zemczak ubuntu-cdimage: status New In Progress
2019-02-12 11:52:20 Łukasz Zemczak branch linked lp:~sil2100/ubuntu-cdimage/checksum-mtime-only
2019-02-12 15:26:39 Łukasz Zemczak description The bin/checksum-directory script is intended to create checksums of all images in a given directory. The script itself offers a functionality of adding additional 'old directories' where it should look for existing checksums for images in the new directory and try re-using those - instead of re-checksumming the files all over again (to save time). This doesn't seem to work. The checksum-directory merging of checksums works in such a way that each entry in the current directory is checked to see if it can be re-used from one of the olddirs. First there's a check for symlinks. If the entry is not a symlink, then the next method of 'checking' is checking the timestamps of the files. The current design of the timestamp checking makes it basically impossible to re-use checksums from other directories though. Each file is checked for max(st.st_mtime, st.st_ctime) and then compared (entry_time > dir_time). Every move, hard-link or copy operation of an image file modifies at least one of the timestamps, resulting in checksum-directory not considering re-using the checksum. The bin/checksum-directory script is intended to create checksums of all images in a given directory. The script itself offers a functionality of adding additional 'old directories' where it should look for existing checksums for images in the new directory and try re-using those - instead of re-checksumming the files all over again (to save time). This doesn't seem to work. The checksum-directory merging of checksums works in such a way that each entry in the current directory is checked to see if it can be re-used from one of the olddirs. First there's a check for symlinks. If the entry is not a symlink, then the next method of 'checking' is checking the timestamps of the files against the checksum-storage files. The current design of the timestamp checking makes it basically impossible to re-use checksums from other directories though. Each image file is checked for max(st.st_mtime, st.st_ctime) and then compared with the old directory's checksums file (for instance, MD5SUMS) mtime (entry_time > dir_time). Every move, hard-link or copy operation of an image file modifies at least one of the timestamps (usually st_ctime), resulting in checksum-directory not considering re-using the checksum. I think only mtime should be checked?
2019-06-26 09:43:09 Łukasz Zemczak ubuntu-cdimage: status In Progress Triaged