d390.ins file on CD does not point to correct files under /boot

[bugproxy]

== Comment: #0 - Thorsten Diehl <email address hidden> - 2016-01-21 09:20:20 ==
---Problem Description---
d390.ins file does not point to correct files under /boot

Contact Information = <email address hidden>

---uname output---
Linux version 4.3.0-6-generic (buildd@z13-009) (gcc version 5.3.1 20160108 (Ubuntu 5.3.1-5ubuntu2) ) #17-Ubuntu SMP Mon Jan 11 21:29:24 UTC 2016

Machine Type = 2964-702

---boot type---
CDROM / ISO image

---Install repository type---
n/a

---Point of failure---
Failed during boot of installer

The d390.ins file in the root directory of the CD as of 2016-01-20 looks like this:
* Debian GNU/Linux for S/390 (boot from CD-ROM or FTP-Server)
boot/linux_vm 0x00000000
boot/root.off 0x0001040c
boot/root.siz 0x00010414
boot/parmfile 0x00010480
boot/root.bin 0x01000000

and similarly the d390.ins file under /boot:
* Debian GNU/Linux for S/390 (boot from CD-ROM or FTP-Server)
linux_vm 0x00000000
root.off 0x0001040c
root.siz 0x00010414
parmfile 0x00010480
root.bin 0x01000000

However, there are no files: linux_vm, parmfile and root.bin, but:
initrd.debian
kernel.debian
parmfile.debian
root.off
root.siz

I suggest to rename in the ins-file
linux_vm to kernel.debian
parmfile to parmfile.debian
root.bin to initrd.debian

or in any other meaningful way to match the ins file to the exisiting files.

== Comment: #3 - Thorsten Diehl <email address hidden> - 2016-01-21 09:29:30 ==
(In reply to comment #0)
>
> I suggest to rename in the ins-file
> linux_vm to kernel.debian
> parmfile to parmfile.debian
> root.bin to initrd.debian
>
>
and in addition I suggest to rename in ins file AND in /boot:
root.off to initrd.off
root.siz to initrd.siz

[Ubuntu Foundations Team Bug Bot (crichton)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people interested in the package can find the bugs about it. You can find some hints about determining what package your bug might be about at https://wiki.ubuntu.com/Bugs/FindRightPackage. You might also ask for help in the #ubuntu-bugs irc channel on Freenode.

To change the source package that this bug is filed about visit https://bugs.launchpad.net/ubuntu/+bug/1536981/+editstatus and add the package name in the text box next to the word Package.

[This is an automated message. I apologize if it reached you inappropriately; please just reply to this message indicating so.]

[Steve Langasek (vorlon)]

I think this may have just been fixed in the rollout of the latest changes to our image generation, but assigning to Dimitri to confirm.

[Dimitri John Ledkov (xnox)]

Hello,

indeed d390.ins files were incorrect. The first image that has correct ins file is the http://cdimage.ubuntu.com/ubuntu-server/daily/20160122.1/ which is called /boot/ubuntu.ins.

Could you please validate that 20160122.1 is correct, or any later one?

Regards,

Dimitri.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2016-01-25 03:35 EDT-------
Hi Dimitri,

(In reply to comment #7)
> indeed d390.ins files were incorrect. The first image that has correct ins
> file is the http://cdimage.ubuntu.com/ubuntu-server/daily/20160122.1/ which
> is called /boot/ubuntu.ins.
>

Is there a particular package or git tree where the ISO creation files are maintained? I suspect that this is not debian-cd. Just wondering because calculating initrd sizes and offsets are a common issue across distributions and it would make sense to review the whole creation.

Thanks and kind regards,
Hendrik

[Dimitri John Ledkov (xnox)]

It is debian-cd based, there is a bzr tree available. There are a few more ubuntu specific additions - livefs creation (which is requested and done in launchpad) and fetching the d-i images.

The ubuntu fork of debian-cd is available here: https://code.launchpad.net/~ubuntu-cdimage/debian-cd/ubuntu

The things specific to s390x on ubuntu are here:
http://bazaar.launchpad.net/~ubuntu-cdimage/debian-cd/ubuntu/view/head:/tools/boot/xenial/boot-s390x

and

http://bazaar.launchpad.net/~ubuntu-cdimage/debian-cd/ubuntu/files/head:/data/xenial/s390x/

It is still pending to add El Torito booting to above, which I have started last week, and will propose for merging & deployment shortly.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2016-01-25 10:49 EDT-------
I just checked the CD images as of 2016-01-11 and 2016-01-25 and found the following on xenial-server-s390x.iso 25-Jan-2016 07:01 581M Server install image for IBM System z computers (standard download):

/boot/ubuntu.ins is OK
/ubuntu.ins is missing (/d390.ins was not replaced, but deleted)

Please create an /ubuntu.ins with proper paths to /boot/, too.

[Dimitri John Ledkov (xnox)]

Hello Thorsten,

Thank you for your review. Would you be able to elaborate a bit more.

Are both files actually required? And wouldn't just one or the other ubuntu.ins be sufficient? I know that other distributions ship two .ins files, but is there a technical reason to do so? Such that I can make sure our testing and validation covers the required cases.

I'll prepare changes to generate two ubuntu.ins, but ideally I would prefer to ship just one - e.g. either top-level one, or the one in the boot sub-directory.

Regards,

Dimitri.

[Dimitri John Ledkov (xnox)]

Images as off 20160127.1 and later have two ubuntu.ins files, a top level one and one under the boot/ directory. Please validate, and request which one to drop, if redundant.

[Dimitri John Ledkov (xnox)]

No comment from reporter. Assuming fixed. Marking bug as fix released.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2016-02-03 11:03 EDT-------
Successfully verified with daily CD xenial-server-s390x.iso of 2016-02-03
Both ins-files were correct and working as expected and resulting in a startup of the installer.

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2016-02-03 11:16 EDT-------
Sorry, Dimitri, I missed your question.
It is a good choice to have both ins files.
1. The ins file under / is used when IPLing the CD/DVD in the HMC - and the z Systems users are used NOT to enter an additional path, just IPL the DVD.
2. The ins file under /boot is required for those users who are copying the content of /boot to their own ftp server.
Thus I recommend to have both ins files.