Have a Lunar Calendar for Chinese user

Bug #1513099 reported by Yuan-Chen Cheng
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
Medium
Yuan-Chen Cheng
Ubuntu Calendar App
Fix Released
Medium
Gary.Wang

Bug Description

ubuntu have a liblunar-1-0 package that you can get lunar calendar !

Will be useful if we can have it integrated in to the calendar app.

Related branches

Changed in savilerow:
assignee: nobody → Yuan-Chen Cheng (ycheng-twn)
importance: Undecided → High
status: New → Triaged
Revision history for this message
RaphAstronome (postmakter) wrote :

Lunar phases in calendar also interest me for astronomy.

Changed in canonical-devices-system-image:
status: New → Confirmed
importance: Undecided → Wishlist
assignee: nobody → Yuan-Chen Cheng (ycheng-twn)
Revision history for this message
Gary.Wang (gary-wzl77) wrote :

For calendar app, we didn't import c++ qml plugin in this project so we prefer to keep this project written in plain qml by importing lunar.js instead of import c++ plugin based on liblunar-1-0 package.
A little concerns about importing lunar.js file is it will increment app startup time, which doesn't make sense for users who don't use lunar calendar.

Changed in ubuntu-calendar-app:
assignee: nobody → Gary.Wang (gary-wzl77)
status: New → In Progress
importance: Undecided → Medium
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote : Re: [Bug 1513099] [NEW] Have a Lunar Calendar for Chinese user

>
> It it possible to know how much extra time is needed to import libnuar.js ?

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Try qml profiler to analysis compile time, basically loading time can be ignored for non-lunar calendar user.
Enclosed please find screenshots of calendar app which has lunar calendar supported.
It's better that UX team can have UI review at first.
Thanks.

Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

@gary, who is testing it ?

Changed in canonical-devices-system-image:
status: Confirmed → In Progress
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

@ethan, is this assigned to you to test it ? If yes, can you share some result ?

Revision history for this message
Ethan Chang (ethan.chang) wrote :

Verified with com.ubuntu.calendar 0.4 , the lunar calendar works well with calendar app.

Changed in savilerow:
importance: High → Medium
Changed in canonical-devices-system-image:
importance: Wishlist → Medium
Revision history for this message
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-calendar-app at revision None, scheduled for release in ubuntu-calendar-app, milestone rtm14

Changed in ubuntu-calendar-app:
status: In Progress → Fix Committed
Changed in ubuntu-calendar-app:
milestone: none → 0.5
Revision history for this message
Foucrier (u-michel) wrote :

When the "Show lunar calendar" is set on, several Chinese characters are displayed in frenche version!
OTA-9.1 and before
Aquaris E4.5

no longer affects: savilerow
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

@gary, are we ready to land this ?

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Yes, will land into 0.5.0(OTA-10)

Changed in canonical-devices-system-image:
status: In Progress → Fix Committed
Changed in ubuntu-calendar-app:
status: Fix Committed → Fix Released
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.