Do not notify for events marked as not attending
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
Ubuntu UX |
Triaged
|
Medium
|
Paty Davila | ||
indicator-datetime (Ubuntu) |
Fix Released
|
High
|
Renato Araujo Oliveira Filho |
Bug Description
This is a follow-up from bug #1371871. While it was marked as Fix Released, it doesn't seem to have had any effect. I'm reporting it as two separate bugs to reopen it now.
I've got a few events in my calendar for meetings where I'm marked as not going, which I still want to see in my calendar unless I explicitly delete them.
An example is a recurring event which I've got on my work calendar. During my holiday:
- I'll mark myself as not attending
- I will not delete the event
- I don't expect to be notified
As I'm not marked as attending, I wouldn't expect to get a reminder notification, even less if I'm in a different timezone and it's 3:00 a.m. :)
See bug 1508440 for the "display events not being attended clearly" part.
Related branches
- Charles Kerr (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
- Arthur Mello (community): Approve
-
Diff: 1145 lines (+497/-214)20 files modifiedCMakeLists.txt (+3/-2)
debian/control (+2/-0)
include/datetime/engine-eds.h (+3/-2)
include/datetime/myself.h (+62/-0)
src/CMakeLists.txt (+1/-0)
src/engine-eds.cpp (+185/-196)
src/main.cpp (+2/-1)
src/myself.cpp (+76/-0)
tests/CMakeLists.txt (+3/-1)
tests/run-eds-ics-test.sh (+9/-1)
tests/test-eds-ics-all-day-events.cpp (+3/-2)
tests/test-eds-ics-missing-trigger.cpp (+2/-1)
tests/test-eds-ics-non-attending-alarms.cpp (+79/-0)
tests/test-eds-ics-non-attending-alarms.ics.in (+53/-0)
tests/test-eds-ics-nonrepeating-events.cpp (+3/-2)
tests/test-eds-ics-repeating-events.cpp (+3/-2)
tests/test-eds-ics-repeating-valarms.cpp (+2/-1)
tests/test-eds-ics-tzids-2.cpp (+2/-1)
tests/test-eds-ics-tzids-utc.cpp (+2/-1)
tests/test-eds-ics-tzids.cpp (+2/-1)
description: | updated |
Changed in ubuntu-calendar-app: | |
assignee: | nobody → Kunal Parmar (pkunal-parmar) |
importance: | Undecided → High |
status: | New → Triaged |
Changed in ubuntu-calendar-app: | |
assignee: | Kunal Parmar (pkunal-parmar) → Renato Araujo Oliveira Filho (renatofilho) |
milestone: | none → 0.5 |
status: | Triaged → Confirmed |
Changed in indicator-datetime (Ubuntu): | |
assignee: | nobody → Renato Araujo Oliveira Filho (renatofilho) |
importance: | Undecided → High |
status: | New → Confirmed |
tags: | added: indicator |
Changed in ubuntu-calendar-app: | |
milestone: | 0.5 → 0.6 |
Changed in indicator-datetime (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in ubuntu-calendar-app: | |
status: | Confirmed → In Progress |
Changed in indicator-datetime (Ubuntu): | |
status: | In Progress → Fix Committed |
status: | Fix Committed → In Progress |
no longer affects: | ubuntu-calendar-app |
affects: | indicator-datetime → canonical-devices-system-image |
Changed in canonical-devices-system-image: | |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Committed |
Changed in indicator-datetime (Ubuntu): | |
status: | In Progress → Fix Released |
Changed in canonical-devices-system-image: | |
importance: | Undecided → High |
milestone: | none → 11 |
Changed in canonical-devices-system-image: | |
status: | Fix Committed → Fix Released |
Changed in ubuntu-ux: | |
assignee: | nobody → Paty Davila (dizzypaty) |
importance: | Undecided → Medium |
status: | New → Triaged |
I think best place to resolve this issue is notification system, then can check status before firing the notification and act accordingly.