getRecurrenceString() function needs to be rewritten
Bug #1372054 reported by
David Planella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Calendar App |
Fix Released
|
Medium
|
Mihir Soni | ||
Bug Description
The getRecurrenceSt
- It doesn't have translatable strings for recurring events happening weekly on a given day
- It uses chained ? : statements that make the code difficult to read (where if/else statements could be used)
- It redefines Qt enums as numerical indexes to be used for different purposes, indexing global arrays outside of the function. That makes the code extremely difficult to follow, and very prone to errors.
I'd suggest reviewing and rewriting it addressing those issues.
Related branches
lp:~mihirsoni/ubuntu-calendar-app/rewriteGetRecurrenceString
- Kunal Parmar: Approve
- Ubuntu Phone Apps Jenkins Bot: Approve (continuous-integration)
- Nicholas Skaggs (community): Needs Fixing
- David Planella: Needs Fixing
-
Diff: 232 lines (+93/-55)4 files modifiedEventRepetition.qml (+6/-5)
EventUtils.qml (+54/-48)
Recurrence.js (+31/-0)
RecurrenceLabelDefines.qml (+2/-2)
| Changed in ubuntu-calendar-app: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| description: | updated |
| Changed in ubuntu-calendar-app: | |
| assignee: | nobody → Mihir Soni (mihirsoni) |
| milestone: | none → rtm14 |
| Changed in ubuntu-calendar-app: | |
| status: | Triaged → In Progress |
Revision history for this message
| Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote | #1 |
| Changed in ubuntu-calendar-app: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-calendar-app: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:ubuntu-calendar-app at revision 496, scheduled for release in ubuntu-