test_fill_form and test_add_new_event_with_default_values failed on mako image #120

[Brendan Donegan]

These two tests are failing since mako image #120 with the following error(s):

Traceback (most recent call last):
  File "/home/phablet/autopilot/calendar_app/tests/test_custom_proxy_objects.py", line 27, in test_fill_form
    new_event_page._fill_form(test_event)
  File "/usr/lib/python3/dist-packages/autopilot/logging.py", line 46, in inner
    return f(instance, *args, **kwargs)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 397, in _fill_form
    self._fill_location(event_information.location)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 423, in _fill_location
    self._ensure_entry_field_visible_and_write('eventLocationInput', value)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 406, in _ensure_entry_field_visible_and_write
    self._ensure_visible_and_write(name_text_field, value)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 413, in _ensure_visible_and_write
    text_field.write(value)
  File "/home/phablet/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_textfield.py", line 42, in write
    self.focus.wait_for(True)
  File "/usr/lib/python3/dist-packages/autopilot/introspection/types.py", line 181, in wait_for
    failure_msg))
AssertionError: After 10.0 seconds test on NewEventEntryField.focus failed: True != dbus.Boolean(False, variant_level=1)

Traceback (most recent call last):
  File "/home/phablet/autopilot/calendar_app/tests/test_new_event.py", line 66, in test_add_new_event_with_default_values
    day_view = new_event_page.add_event(test_event)
  File "/usr/lib/python3/dist-packages/autopilot/logging.py", line 46, in inner
    return f(instance, *args, **kwargs)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 376, in add_event
    self._fill_form(event_information)
  File "/usr/lib/python3/dist-packages/autopilot/logging.py", line 46, in inner
    return f(instance, *args, **kwargs)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 397, in _fill_form
    self._fill_location(event_information.location)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 423, in _fill_location
    self._ensure_entry_field_visible_and_write('eventLocationInput', value)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 406, in _ensure_entry_field_visible_and_write
    self._ensure_visible_and_write(name_text_field, value)
  File "/home/phablet/autopilot/calendar_app/emulators.py", line 413, in _ensure_visible_and_write
    text_field.write(value)
  File "/home/phablet/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_textfield.py", line 42, in write
    self.focus.wait_for(True)
  File "/usr/lib/python3/dist-packages/autopilot/introspection/types.py", line 181, in wait_for
    failure_msg))
AssertionError: After 10.0 seconds test on NewEventEntryField.focus failed: True != dbus.Boolean(False, variant_level=1)

The root cause seems to be identical in that the test is trying to fill out the new event form and does not scroll the view (or the application does not do that).

[Tim Peeters (tpeeters)]

I can fix it with this:

=== modified file NewEvent.qml
--- NewEvent.qml 2014-06-26 22:48:45 +0000
+++ NewEvent.qml 2014-07-09 14:11:22 +0000
@@ -537,7 +537,7 @@
         anchors {
             left: parent.left
             right: parent.right
- bottom: parent.bottom
+ bottom: keyboard.top
         }
         height: units.gu(6)
         acceptAction: Action {

still investigating further, I thought the MainView should handle that already

[Nicholas Skaggs (nskaggs)]

I don't believe this is still an issue. Please confirm if so.

[Brendan Donegan (brendan-donegan)]

Indeed, this doesn't happen anymore