Icon not shipped in the .deb package

[David Planella]

The debian package does not ship the icon file, so when the app is installed as a .deb, neither the apps scope nor the launcher display its icon.

To reproduce, either build the package locally and install, or alternatively install directly from this PPA: https://launchpad.net/~dpm/+archive/ubuntu/ppa?field.series_filter=vivid

This can be tested on a desktop with either a unity 7 or unity 8 session.

[Victor Thompson (vthompson)]

I can confirm this is an issue with the Weather app's reboot series. I don't know if it is an issue or not with the current version of the app in trunk--but it's probably only worth fixing in the reboot series. More specifically, it needs to be fixed in the reboot series.

[David Planella (dpm)]

Indeed. Looking at how we do it on Music, it would seem that the only part missing is the installation rule

Something along the lines of this on the top CMakeLists.txt file:

install(FILES ${SRC_FILES} ${ICON_FILE} DESTINATION ${DATA_DIR})

Or alternatively, this shouldn't be conditional. That is, the rule should be executed regardless of the click mode, as otherwise the icon will not be installed in the .deb build:

http://bazaar.launchpad.net/~ubuntu-calculator-dev/ubuntu-calculator-app/reboot/view/head:/app/CMakeLists.txt#L8

[David Planella (dpm)]

That was for Calculator, but it applies to Weather (reboot) too.

For docviewer I'm not sure what's going on, as there seems to be an install rule that should be executed in the .deb build, so it might require a bit more of investigation:

http://bazaar.launchpad.net/~ubuntu-docviewer-dev/ubuntu-docviewer-app/trunk/view/head:/CMakeLists.txt#L106

[Bartosz Kosiorek (gang65)]

Hi Victor.

For standard Weather application everything is working perfectly fine.

For reboot, another error is displayed. I submitted bug for that:
https://bugs.launchpad.net/ubuntu-weather-app/+bug/1468418

[David Planella (dpm)]

Thanks Bartosz. The fact that it's the Weather reboot series that is affected does not qualify the bug as Invalid, and neither does the fact that the packaging is affected by another bug, thus reopening the Weather bug task.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-docviewer-app at revision 155, scheduled for release in ubuntu-docviewer-app, milestone 2014-10-30

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-calculator-app at revision 200, scheduled for release in ubuntu-calculator-app, milestone Unknown

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-weather-app/reboot at revision 61, scheduled for release in ubuntu-weather-app, milestone 2.0