Pressing minus and plus keys followed by a number produces odd results

Bug #1273555 reported by Victor Thompson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Calculator App
Fix Released
Medium
Samer Masterson

Bug Description

To reproduce open calculator app and do the following:
1. Press minus (-)
2. Press plus (+) followed by 6. Note that it allows the calculation to continue with the calculation (see minus-plus-number.png) finishing this calculation will produce -+6 or -6 if the number 6 is hit next.
3. Pres clear (c) twice to reset.
4. Press plus (+)
5. Press minus (-) followed by 6. Note that it shows the calculation to be "+-6" (see plus-minus-number.png)

Expected results: Step #2 should not allow the plus (+) to continue the calculation, it should behave similar to pressing times (x). Step #5 should either replace the plus (+) with a minus (-) when the minus is hit, or preferably, not allow the plus to be used to start a calculation--similar to pressing times (x)

Difficulty: MEDIUM
###### Desidered solution #####
1. Remove the option to add a + after a minus (hint: find the code that prevents to add a * or a / after a minus)
2. Remove the option to add a + as first operator (hint: find the function that prevents to add a * or a / as first operation

If you need an help, join #ubuntu-app-devel and ping WebbyIT

Tags: hackday

Related branches

Revision history for this message
Victor Thompson (vthompson) wrote :
Revision history for this message
Victor Thompson (vthompson) wrote :
description: updated
tags: added: hackday
Changed in ubuntu-calculator-app:
status: New → Triaged
importance: Undecided → Medium
Changed in ubuntu-calculator-app:
assignee: nobody → Samer Masterson (samer-f)
status: Triaged → In Progress
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

Fix committed into lp:ubuntu-calculator-app at revision None, scheduled for release in ubuntu-calculator-app, milestone coreapps-2014-week-4

Changed in ubuntu-calculator-app:
status: In Progress → Fix Committed
Changed in ubuntu-calculator-app:
milestone: none → 1.6
Revision history for this message
Victor Thompson (vthompson) wrote :

This bug still exists for the first two steps (minus followed by plus) in the bug description.

Changed in ubuntu-calculator-app:
status: Fix Committed → Confirmed
Revision history for this message
Riccardo Padovani (rpadovani) wrote :

Are you sure? I'm not able to reproduce on rev 213 (code has been merged in rev 212)

Changed in ubuntu-calculator-app:
status: Confirmed → Incomplete
Revision history for this message
Victor Thompson (vthompson) wrote :

Nevermind. I didn't push the Javascript file to the phone.

Changed in ubuntu-calculator-app:
status: Incomplete → Fix Committed
Changed in ubuntu-calculator-app:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.