[Calculator app] [Visual design] Button padding/spacing inconsistent

[Alan Pope 🍺🐧🐱 🦄]

The button spacing in qmlscene on the desktop is fine, with the padding between C, 7, 4, 1, 0 and the left edge, and X, -, + and = and the right edge being fine. However on the mobile device the padding is no longer there, and the buttons are hard up against the edge of the device screen. The buttons should line up in the same way on device as in qmlscene on the desktop.

Are we using grid-units to place the buttons correctly?

[Dalius (dalius-sandbox)]

We are using grid units correctly. However we might have made wrong assumption about device size.

[Dalius (dalius-sandbox)]

If possible please give:

1) device resolution;

2) grid unit size;

3) screenshot;

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Will do. Saw this over a google hangout with the design guys. Will try and get a screenshot on my own device. Thanks.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Screenshot from a nexus 7, 1280x800. Seems the issue goes the other way here. on the 4" phone there is not enough space between buttons and the edge, with the 7" tablet there's too much.

[Dalius (dalius-sandbox)]

The problem is simple. Our development grid is 50x75. Nexus 7 grid size is: 57x73 (grid's unit size 14 pixels).

I have tried enforcing grid's size to 50 units. Alan, could you test it on Nexus 7 and share how it looks like:
https://code.launchpad.net/~dalius-sandbox/ubuntu-calculator-app/grid-issue

Alternatively we should talk with design team about this one. There are reasons why grid's size is different on different devices and it might be undesired to have oversized calculator on big tablet :-)

[Arnaud Ober (user-deactivated-80571)]

Here is a screenshot of the bug (on the last daily build).

[Dalius (dalius-sandbox)]

Experimental fix pushed to main branch. Please let me know how it works on your device.

[Arnaud Ober (user-deactivated-80571)]

No, still bug on my GNexus. :/

[Dalius (dalius-sandbox)]

Arnaud, maybe fix is not in build yet as I have pushed fix only today?

[Arnaud Ober (user-deactivated-80571)]

Yeah but I downloaded last bzr branche and push it on my Galaxy Nexus, and nothing news... Except that tabs are no more showed. Thus a bug which is corrected. But buttons too large still exists...

[Dalius (dalius-sandbox)]

Arnaud, thanks for info. I will try different approach then.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

Fix committed into lp:ubuntu-calculator-app at revision 46, scheduled for release in ubuntu-calculator-app, milestone alpha-1

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Much better.. See attached.