Bantracker should /msg the op on kick/remove/ban/quiet with the ID requesting a comment
Bug #521516 reported by
Terence Simpson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu IRC Bots |
Fix Released
|
Low
|
m4v |
Bug Description
When someone is kicked/removed or banned/quieted the bot should /msg the op with a message similar to "Please comment on the $type of $nick_or_host in $channel with the ID $id"
Where $type is one of "removal", "ban" or "quiet";
$channel is the channel the event occurred in;
$nick_or_host is the nickname or hostmask of the $type;
and $id is the issue ID which can be used with the @comment command
Exmaple:
op kicks user1 from #channel
bot send /msg op Please comment on the removal of user1!ident@host in #channel with the ID 12345
op sets mode +b *!*@host in #channel
bot send /msg op Please comment on the ban of *!*@host in #channel with the ID 12346
Related branches
lp:~m4v/ubuntu-bots/bugfixes
- Terence Simpson: Approve
-
Diff: 197 lines (+91/-10)2 files modifiedBantracker/config.py (+30/-3)
Bantracker/plugin.py (+61/-7)
Changed in ubuntu-bots: | |
importance: | Undecided → Low |
status: | New → Confirmed |
Changed in ubuntu-bots: | |
assignee: | nobody → m4v (symphony) |
Changed in ubuntu-bots: | |
status: | Confirmed → In Progress |
Changed in ubuntu-bots: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
made new branch https:/ /code.launchpad .net/~symphony/ ubuntu- bots/bugfixes where I try to implement this
I have an issue though, I believe it should only /msg the op in ban/quiet cases, /msg in removals as well can get a bit too verbose (like in a bankick, the op will get two messages, one for the kick and other for the ban) and might be a burden for the op having to look which one should comment on.
Commenting removals isn't as important as is commenting bans/quiets, and requesting it for only bans/quiets would stress this.
In any case I implemented as tsimpson described